Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 487668 - =dev-ruby/ffi-1.1.5 - Missing dependency on dev-ruby/builder
Summary: =dev-ruby/ffi-1.1.5 - Missing dependency on dev-ruby/builder
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-10-11 18:00 UTC by Christian Zuckschwerdt
Modified: 2014-07-21 14:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for upstreams rake file (ffi-1.1.5-builder.patch,312 bytes, patch)
2013-10-11 18:02 UTC, Christian Zuckschwerdt
Details | Diff
ebuild diff for the epatch above (ffi-1.1.5.ebuild.patch,333 bytes, patch)
2013-10-11 18:04 UTC, Christian Zuckschwerdt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Zuckschwerdt 2013-10-11 18:00:43 UTC
dev-ruby/ffi-1.1.5 depends on dev-ruby/builder but the ebuild doesn't DEPEND on it. This is on a fresh system with no ruby packages installed and using ruby19.

Also strangely enough installing dev-ruby/builder won't solve this completly. The "require" in the ffi's tasks/gem.rake seems to miss installed builder.

Fix attached, needs review.

Reproducible: Always

Steps to Reproduce:
1. emerge ffi
ALSO FAILS:
2. emerge builder ffi
Actual Results:  
>>> Emerging (1 of 1) dev-ruby/ffi-1.1.5
[...]
 * Running compile phase for ruby19 ...
rake aborted!
cannot load such file -- rubygems/builder
/tmp/portage/dev-ruby/ffi-1.1.5/work/ruby19/ffi-ffi-ed72479/tasks/gem.rake:5:in `<top (required)>'
 * ERROR: dev-ruby/ffi-1.1.5::gentoo failed (compile phase):


1. Possibly DEPEND on dev-ruby/builder.

2. Replace in tasks/gem.rake:
-require 'rubygems/builder'
+require 'builder'
Comment 1 Christian Zuckschwerdt 2013-10-11 18:02:40 UTC
Created attachment 360658 [details, diff]
Patch for upstreams rake file

This needs review. It works but I can't say if this is correct.
Comment 2 Christian Zuckschwerdt 2013-10-11 18:04:30 UTC
Created attachment 360662 [details, diff]
ebuild diff for the epatch above

Inserts the epatch command for the gem.rake patch above.
Comment 3 Hans de Graaff gentoo-dev Security 2013-10-12 09:28:23 UTC
Your patch works because you remove rubygems/builder, not because you add builder. :-)  rubygems/builder is gone in rubygems 2.x.

I've opted to fix this by stabling the newer ffi 1.4.0 in bug 487750, which was long overdue anyway.

Thanks for the report!
Comment 4 Manuel Rüger (RETIRED) gentoo-dev 2014-07-21 14:11:46 UTC
1.1.5 has been cleaned up.