Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 478126 - dev-perl/PortageXS 0.2.12 version bump
Summary: dev-perl/PortageXS 0.2.12 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PMASKED
Depends on: 477772
Blocks: 514490
  Show dependency tree
 
Reported: 2013-07-25 12:41 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2014-10-25 10:32 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-perl/PortageXS/PortageXS-0.2.12.ebuild (PortageXS-0.2.12.ebuild,1.43 KB, text/plain)
2013-07-25 12:41 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details
dev-perl/PortageXS/files/0.2.12/prefix.patch (prefix.patch,6.10 KB, patch)
2013-07-25 12:41 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
dev-perl/PortageXS/metadata.xml patch (metadataxml.patch,746 bytes, patch)
2013-07-25 12:42 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
dev-perl/PortageXS/files/0.2.12/prefix.patch # attempt 2 (prefix.patch,8.53 KB, patch)
2013-07-27 12:24 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details | Diff
dev-perl/PortageXS/PortageXS-0.2.12.ebuild (PortageXS-0.2.12.ebuild,1.44 KB, text/plain)
2013-07-27 12:25 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-25 12:41:10 UTC
Created attachment 354164 [details]
dev-perl/PortageXS/PortageXS-0.2.12.ebuild

Proxy-Maintainer advising availability of PortageXS 0.2.12, which aims to solve 2 present tree bugs ( one partially, but is still an improvement on the current scenario ).

Requires bug #477772 Before it can be added.
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-25 12:41:45 UTC
Created attachment 354166 [details, diff]
dev-perl/PortageXS/files/0.2.12/prefix.patch
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-25 12:42:30 UTC
Created attachment 354168 [details, diff]
dev-perl/PortageXS/metadata.xml patch
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2013-07-25 13:01:39 UTC
which bug was fixed completely? (i mean number on b.g.o, if exist).
Comment 4 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-26 07:32:07 UTC
#264680 should be "mostly" fixed, at least, for average end users at least. 

#395337 should be fixed also, though, this is mostly conjecture because I don't know what scenario caused it to happen exactly, just my tests show what is seen there shouldn't still be happening.

#437414 is now patched in the source, with additional edge cases I found from personal experience, namely, the patch there added a new different bug for me, because the code mixes "old" and "new" portage metafile locations, which aren't always there on systems. 

So instead of just picking one path and bailing if its not there, it instead checks for expected paths in a priority list, and returns the item found, for instance:

the /etc/make.conf  -> /etc/portage/make.conf  transition is not complete on many targets, and both locations are still supported by portage, however, the existing code only tolerated one of those 2 paths.
Comment 5 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-27 12:24:03 UTC
Created attachment 354304 [details, diff]
dev-perl/PortageXS/files/0.2.12/prefix.patch # attempt 2

Confound it, more testing reveals I somehow managed to miss a bunch of paths for EPREFIX patch, and a bunch of the paths aren't right yet for make.conf and friends -_-. 

I *swear* I had code in this release to switch between the 2 possible locations of make.profile, but nope, seems that somehow got lost and won't be in till a future release.

No panic, 2 more releases already cut, slowly improving
Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2013-07-27 12:25:27 UTC
Created attachment 354306 [details]
dev-perl/PortageXS/PortageXS-0.2.12.ebuild

Reuploading the ebuild, because it needed additonal eprefix parameters to patch a test.
Comment 7 Manuel Rüger (RETIRED) gentoo-dev 2014-05-26 01:27:55 UTC
Any update here? Can we add it to the tree?
Comment 8 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-06-22 12:34:50 UTC
In CVS.
Comment 9 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2014-06-22 22:25:53 UTC
Re-openining, because the files and changes indicated here to be applied simply didn't get applied.

a. Many lines changed upstream
b. many lines needed to be changed in the patch
c. many lines needed to be changed in the ebuild
d. b and c didn't happen.

bug #514490 was thus inevitable.
Comment 10 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-06-27 09:05:49 UTC
Indeed. I was wrong. I'll mask this version for proper testing by me. Re-assign bug to me as reminder.
Comment 11 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-06-27 09:45:13 UTC
- New patch applyed
- New dependency on virtual/perl-Module-Build Added
Comment 12 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-07-01 20:50:11 UTC
- Metadata done
Comment 13 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-07-01 20:51:30 UTC
I Will keep this bug open until unmasking.
Comment 14 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2014-07-23 23:47:37 UTC
Sigh. Now I'm looking into this again, it seems the continued failure to work is due to more failing to use the ebuild I provided:

Your ebuild:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-perl/PortageXS/PortageXS-0.02.12.ebuild?view=markup

  lib/PortageXS/Core.pm \
  lib/PortageXS.pm \
  usr/bin/portagexs_client \
  usr/sbin/portagexsd

Mine:


  lib/PortageXS/Core.pm \
  lib/PortageXS.pm \
  usr/bin/portagexs_client \
  usr/sbin/portagexsd \
  t/01_Core.t

So of course the tests are going to fail.

But In further digging I discovered the patch adds one I didn't add to the eprefixify list, so the eprefixify list should be:

  lib/PortageXS/examples/getParamFromFile.pl \
  lib/PortageXS/Core.pm \
  lib/PortageXS.pm \
  usr/bin/portagexs_client \
  usr/sbin/portagexsd \
  t/01_Core.t

Having made that change, it again passes its own tests.

Other changes I wanted but weren't made:

1. Properly normalising the version 
2. Deleting the now outdated HOMEPAGE value ( homepage is now CPAN )
3. A whole bunch of EAPI5 migration :/
Comment 15 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2014-07-26 21:22:19 UTC
eprefixify options fixed.
Comment 16 Patrice Clement gentoo-dev 2014-10-24 23:23:27 UTC
HOMEPAGE fixed. Changes to make this ebuild EAPI5-compliant seem to have been already performed as well as version normalisation. I believe we can close this bug now.