Whenever an eclass is referenced without an explicit link text, an <a>-Tag without link text is generated. E.g. the code See <uri link="::eclass-reference/flag-o-matic.eclass/"/> for a full reference. produces the following HTML snippet: See <a href="../../../../eclass-reference/flag-o-matic.eclass/index.html"></a> for a full reference. This is because the eclass-part isn't part of the devmanual sources (if I understand the other bugs correctly they are now generated from the man pages). The make process actually warns about it: warning: failed to load external entity "eclass-reference/bash-completion.eclass/text.xml" If a link text is specified as the text content of the <uri> tag, a proper <a> tag is generated. Reproducible: Always
Just send a pull request for this issue (links to the eclass-reference have explicit link titles inside the <uri /> tag now).
Is this the same as bug #442194?
(In reply to Michael Palimaka (kensington) from comment #2) > Is this the same as bug #442194? Yes, guess I overlooked it.
If this fixes the problem then we can merge the pull request and close the other bug.
Can I see the resulting html with this patch applied?
(In reply to Markos Chandras from comment #4) > If this fixes the problem then we can merge the pull request and close the > other bug. I think the approach in #442194 is the better one (fixing it in the generation script). However, as a quick fix I would prefer merging the pull request (to get the links back) and revert it once the xslt or whatever is fixed if it is possible.
(In reply to Johann Schmitz from comment #6) > (In reply to Markos Chandras from comment #4) > > If this fixes the problem then we can merge the pull request and close the > > other bug. > > I think the approach in #442194 is the better one (fixing it in the > generation script). > However, as a quick fix I would prefer merging the pull request (to get the > links back) and revert it once the xslt or whatever is fixed if it is > possible. Pushed. Lets wait for devmanual to be regenerated again and see if the links are ok now
(In reply to Markos Chandras from comment #7) > Pushed. Lets wait for devmanual to be regenerated again and see if the links > are ok now Seems to be ok now.
The patch seems like it did the trick and fixed the broken references. thanks!
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=67b22764d134fdf6812efaa495c563ae1e639b9c commit 67b22764d134fdf6812efaa495c563ae1e639b9c Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2020-01-15 20:08:13 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2020-01-16 18:49:08 +0000 Revert "Fixed eclass-reference links" This is now fixed in devbook.xsl, so the changes in the text (which were meant as a stop-gap measure) can be reverted again. This reverts commit 481c88ea7ca8d93b17ac6668186216baf50daab9. Bug: https://bugs.gentoo.org/475332 Signed-off-by: Ulrich Müller <ulm@gentoo.org> appendices/contributors/text.xml | 2 +- ebuild-writing/functions/src_compile/build-environment/text.xml | 2 +- ebuild-writing/functions/src_compile/building/text.xml | 5 +++-- ebuild-writing/functions/src_unpack/svn-sources/text.xml | 4 ++-- ebuild-writing/using-eclasses/text.xml | 8 ++++---- tasks-reference/completion/text.xml | 3 +-- 6 files changed, 12 insertions(+), 12 deletions(-)
*** This bug has been marked as a duplicate of bug 442194 ***
