Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 472928 - gnome2.eclass doesn't support PATCHES variable
Summary: gnome2.eclass doesn't support PATCHES variable
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome2.eclass
  Show dependency tree
 
Reported: 2013-06-11 00:49 UTC by Yixun Lan
Modified: 2015-12-16 12:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yixun Lan archtester gentoo-dev 2013-06-11 00:49:56 UTC
writing as following does not take effect in gnome2.eclass, 
PATCHES=(
    "${FILESDIR}"/${PN}-3.0.3-zlib-1.2.5.2.patch
    )

It would be great to add this support, thanks


Reproducible: Always
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-12-23 10:02:55 UTC
It is sad that the logic to handle this is spread in so many eclasses yet each have their own little differences.

I think for gnome2.eclass, the best alternative is to check if we can use autotools-utils src_prepare as it has a nice logic for checking if autoreconf is needed and also handles epatch_user.

The rest of the phases are more questionable as it would introduce out-of-source builds and a few other features that we might want to avoid for now.
Comment 2 Pacho Ramos gentoo-dev 2015-12-16 12:04:58 UTC
We will simply rely on builtin functionality with eapi6 as soon as eclasses are updated for that eapi