syslog-summary can use libmagic to recognize gzip'd log files. It does a check for support at runtime and gives a hint to install "python-magic" for support if it is not present. This would be a fine suggestion in Debian, however, in Gentoo, python-magic is NOT the right package. It is instead sys-apps/file[python]! I propose adding a simple "magic" use flag to syslog-summary that makes it more apparent before installing that this option is available to users. It also avoids the confusion surrounding the package naming between distros. Reproducible: Always
Created attachment 350644 [details] metadata addition of magic use flag
Created attachment 350646 [details] syslog-summary revision including magic use flag
Comment on attachment 350644 [details] metadata addition of magic use flag --- metadata.xml 2011-09-27 18:06:15.000000000 +0200 +++ - 2013-06-10 20:08:36.459096025 +0200 @@ -5,4 +5,7 @@ <email>phajdan.jr@gentoo.org</email> <name>Pawel Hajdan jr</name> </maintainer> + <use> + <flag name='magic'>Enable magic support using <pkg>sys-apps/file</pkg></flag> + </use> </pkgmetadata>
Comment on attachment 350646 [details] syslog-summary revision including magic use flag --- syslog-summary-1.14.ebuild 2011-12-19 22:35:41.000000000 +0100 +++ - 2013-06-10 20:09:06.590919966 +0200 @@ -14,10 +14,10 @@ LICENSE="GPL-3" SLOT="0" KEYWORDS="amd64 ~sparc x86" -IUSE="" +IUSE="magic" DEPEND="" -RDEPEND="" +RDEPEND="magic? ( sys-apps/file[python] )" pkg_setup() { python_set_active_version 2 We do not set USE flags just to pull in run-time dependencies. Especially if the program in question can use it but gracefully degrades as needed.
(In reply to Jeroen Roovers from comment #4) > We do not set USE flags just to pull in run-time dependencies. Especially if > the program in question can use it but gracefully degrades as needed. I was not aware of this but after reading your comment I looked it up in the dev manual. If I understand correctly, this situation is best resolved not with a use flag but with a message presented at the end of the installation. Correct?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4c8bf8521c8d4330d6300452f6dd7e536cd47761 commit 4c8bf8521c8d4330d6300452f6dd7e536cd47761 Author: Paul Healy <lmiphay@gmail.com> AuthorDate: 2018-10-04 18:46:00 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-10-13 20:00:54 +0000 app-admin/syslog-summary: suggest sys-apps/file Also: EAPI 6 Dropped stable keywords Closes: https://bugs.gentoo.org/472884 Signed-off-by: Paul Healy <lmiphay@gmail.com> Signed-off-by: Michał Górny <mgorny@gentoo.org> .../syslog-summary/syslog-summary-1.14-r2.ebuild | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+)
