Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469598 - games-misc/katawa-shoujo-1.1_beta version bump
Summary: games-misc/katawa-shoujo-1.1_beta version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2013-05-12 16:33 UTC by Maks Verver
Modified: 2013-08-30 21:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild (katawa-shoujo-1.1_beta.ebuild,2.26 KB, text/plain)
2013-05-12 16:33 UTC, Maks Verver
Details
diff from previous katawa-shouja-1.0.ebuild (katawa-shoujo.diff,2.40 KB, patch)
2013-05-12 16:34 UTC, Maks Verver
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maks Verver 2013-05-12 16:33:16 UTC
Created attachment 348092 [details]
Updated ebuild

Here's an ebuild for the 1.1 beta release, which is compatible with Renpy 6.15 (which also the version in portage, which is why I enabled the "system-renpy" USE-flag by default).

Apart from better hardware support and features like full-screen mode, this version bundles binaries for both x86 and amd64.

Since saved games created with release 1.0 and Renpy <6.15 are not compatible with this version, I recommend leaving 1.0 in the tree too, so users that have old saves have the option to install the old version.

(I tested this on ~amd64 with both the system Renpy and the bundled libraries. Either version seems to work fine.)
Comment 1 Maks Verver 2013-05-12 16:34:13 UTC
Created attachment 348096 [details, diff]
diff from previous katawa-shouja-1.0.ebuild
Comment 2 Julian Ospald 2013-05-13 15:24:52 UTC
does bug 1721308 still occur with system renpy?
Comment 3 Julian Ospald 2013-05-13 15:25:55 UTC
I meant bug 459742
Comment 4 Maks Verver 2013-05-13 19:38:39 UTC
The reason bug 459742 appeared was that the bundled version of Ren'py was different from the "system" version in portage (and that version was so old that it wasn't feasible to get it to compile on Gentoo).

The 1.1 release breaks backwards compatibility with 1.0 even with the bundled libraries, because the bundled libraries are from Ren'py 6.15, which is also the version currently in portage.

I don't know what will happen if the system version of Ren'py is upgraded again some time in the future -- maybe this breaks version 1.1 saves again, but then this ebuild could still depend on =games-engines/renpy-6.15* rather than switch to bundled libraries.

My reasoning behind enabling system-renpy by default was that system libraries are preferable to bundled libraries because (1) they can be shared between packages and (2) they can customized/patched.  If you feel that's not the right trade-off to make, I wouldn't object to turning the system-renpy USE-flag back off by default.
Comment 5 Julian Ospald 2013-05-13 19:42:17 UTC
that's not what I asked

is the bug still present?
Comment 6 Maks Verver 2013-05-13 21:42:49 UTC
The bug as described is not reproducible because version 1.1 is not compatible with version 1.0 saved games.
Comment 7 Alex Xu (Hello71) 2013-06-30 14:34:35 UTC
http://ks.renai.us/viewtopic.php?f=13&t=8635&start=15#p164664

Upstream isn't even releasing 1.1 for Linux; no point in us trying.
Comment 8 Julian Ospald 2013-06-30 19:57:45 UTC
it was a bad idea to add it in the first place, because the game logic is closed source, I can't fix it even if I wanted
Comment 9 Alex Xu (Hello71) 2013-06-30 20:12:19 UTC
(In reply to Julian Ospald (hasufell) from comment #8)
> it was a bad idea to add it in the first place, because the game logic is
> closed source, I can't fix it even if I wanted

Only symbolically. Many Ren'Py decompilers are available; some just pull the decoded source from the Ren'Py software though.

CC BY-NC-ND doesn't allow it though, so it's a bit of a moot point.
Comment 10 Julian Ospald 2013-06-30 20:13:16 UTC
right, I love to work on decompiled code...
Comment 11 Alex Xu (Hello71) 2013-06-30 20:17:27 UTC
The decompiled code is the same (byte for byte) as the original code.

Doesn't really matter though; upstream doesn't want to bother.
Comment 12 Alex Xu (Hello71) 2013-08-30 15:21:56 UTC
1.1 is officially out, can we get a bump for that?

It's mostly just asset updates, so a SRC_URI bump is fine.

--- /usr/portage/games-misc/katawa-shoujo/katawa-shoujo-1.0-r1.ebuild   2013-05-23 10:31:16.000000000 -0400
+++ katawa-shoujo-1.1.ebuild    2013-08-30 09:10:28.455937880 -0400
@@ -8,7 +8,7 @@
 
 DESCRIPTION="Bishoujo-style visual novel set in the fictional Yamaku High School for disabled children"
 HOMEPAGE="http://katawa-shoujo.com/"
-SRC_URI="http://dl.katawa-shoujo.com/gold/%5b4ls%5d_katawa_shoujo_%5blinux-x86%5d%5bEA1DFB30%5d.tar.bz2 -> ${P}.tar.bz2
+SRC_URI="http://dl.katawa-shoujo.com/gold_1.1/%5B4ls%5D_katawa_shoujo_1.1-%5Blinux-x86%5D%5BB5C707D5%5D.tar.bz2 -> ${P}.tar.bz2
        http://dev.gentoo.org/~hasufell/distfiles/katawa-shoujo-48.png
        http://dev.gentoo.org/~hasufell/distfiles/katawa-shoujo-256.png"
 
@@ -60,6 +60,10 @@
 pkg_postinst() {
        elog "Savegames from system-renpy and the bundled version are incompatible"
 
+       if use system-renpy; then
+               ewarn "${PN}[system-renpy] is unstable and not supported upstream."
+       fi
+
        games_pkg_postinst
        gnome2_icon_cache_update
 }
Comment 13 Julian Ospald 2013-08-30 21:59:30 UTC
+*katawa-shoujo-1.1 (30 Aug 2013)
+
+ 30 Aug 2013; Julian Ospald <hasufell@gentoo.org> +katawa-shoujo-1.1.ebuild:
+ version bump wrt #469598