Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464364 - x11-misc/habak-0.2.5 - X Error of failed request: BadValue when restarting fvwm-crystal (last rites)
Summary: x11-misc/habak-0.2.5 - X Error of failed request: BadValue when restarting f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL: http://www.fvwmforums.org/phpBB3/view...
Whiteboard:
Keywords: PMASKED
Depends on: 468680
Blocks:
  Show dependency tree
 
Reported: 2013-04-03 14:21 UTC by Dominique Michel
Modified: 2022-02-01 21:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Michel 2013-04-03 14:21:52 UTC
I start fvwm-crystal with startx in a *kit free environment and redirect its standard error output into a file.

At each restart from fvwm-crystal menu, I get something like

X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  113 (X_KillClient)
  Value in failed request:  0x800001
  Serial number of failed request:  29
  Current serial number in output stream:  35

I narrowed down the issue to the Wallpaper-Set function (in the components/functions/Wallpaper Fvwm-Crystal file). When habak is installed, crystal use it at first choice. This doesn't append with x11-misc/hsetroot or media-gfx/xloadimage.

As Fvwm-Crystal and habak maintener, I dropped habak support in favour of xloadimage into the Wallpaper-Set function.

Also, I know almost nothing in C/C++. In consequence, If someone do provide a patch for habak that fix this issue, I will be happy to apply it and make a new release. Otherwise, I will keep it sleeping.


Reproducible: Always

Steps to Reproduce:
1. emerge habak fvwm-crystal
2. startx fvwm-crystal 2>.fvwm-crystal.errors
3. restart fvwm-crystal from its menu
The error will be shown is .fvwm-crystal.errors
Actual Results:  
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  113 (X_KillClient)
  Value in failed request:  0x800001
  Serial number of failed request:  29
  Current serial number in output stream:  35


Expected Results:  
no error
Comment 1 Dominique Michel 2013-04-03 17:51:48 UTC
I made one more change into the Fvwm-Crystal svn repo. Xloadimage doesn't support well the layers. This cause the terminals to not redraw their backgrounds when the wallpaper is changed, and corruption into the black borders of mplayer here (ati-drivers). In consequence, xloadimage is the last choice in Wallpaper-Set, and hsetroot is the first one.
Comment 2 Dominique Michel 2013-04-03 19:14:19 UTC
Sorry for the noise, the last sentence should have been:
In consequence, I replaced xloadimage by feh, which is the last choice in Wallpaper-Set, and hsetroot is the first one.
Comment 3 Dominique Michel 2013-06-22 09:34:11 UTC
This issue is solved in fvwm-crystal-3.1.7 by dropping habak support in favour of feh.

If someone want to make a patch for habak, I will apply it and make a new release. Otherwise, I will let it sleep.
Comment 4 Jonas Stein gentoo-dev 2021-12-19 23:51:10 UTC
Looks to me as follows:

* we have x11-themes/fvwm-crystal-3.6.5 and newer in the tree
* x11-themes/fvwm-crystal does no longer depend on x11-misc/habak
* x11-misc/habak is broken
* x11-misc/habak has no reverse dependencies
* we should last rite x11-misc/habak
Comment 5 Larry the Git Cow gentoo-dev 2021-12-20 00:11:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5292fc9d1076f147cb355d36101659804b6ada1c

commit 5292fc9d1076f147cb355d36101659804b6ada1c
Author:     Jonas Stein <jstein@gentoo.org>
AuthorDate: 2021-12-20 00:10:03 +0000
Commit:     Jonas Stein <jstein@gentoo.org>
CommitDate: 2021-12-20 00:10:42 +0000

    package.mask: Last rite x11-misc/habak
    
    Bug: https://bugs.gentoo.org/464364
    Signed-off-by: Jonas Stein <jstein@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2022-02-01 21:28:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=87701882b43c2c6d9487f98a4d440f949085a087

commit 87701882b43c2c6d9487f98a4d440f949085a087
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2022-02-01 21:20:05 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2022-02-01 21:25:20 +0000

    x11-misc/habak: treeclean
    
    Closes: https://bugs.gentoo.org/464364
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 profiles/package.mask                             |   5 -
 x11-misc/habak/Manifest                           |   1 -
 x11-misc/habak/files/README.en                    | 165 ----------------------
 x11-misc/habak/files/habak-0.2.5-fno-common.patch |  33 -----
 x11-misc/habak/files/habak-0.2.5-gentoo.patch     |  30 ----
 x11-misc/habak/habak-0.2.5-r3.ebuild              |  38 -----
 x11-misc/habak/metadata.xml                       |   8 --
 7 files changed, 280 deletions(-)