Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464330 - New package: ?/pnputils - Utilities dealing with PnP devices.
Summary: New package: ?/pnputils - Utilities dealing with PnP devices.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks: 669722
  Show dependency tree
 
Reported: 2013-04-03 11:07 UTC by Ville Syrjala
Modified: 2019-12-07 15:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pnputils ebuild (pnputils-9999.ebuild,529 bytes, text/plain)
2013-04-03 11:07 UTC, Ville Syrjala
Details
pnputils-9999.ebuild (file_464330.txt,415 bytes, text/plain)
2013-04-03 13:14 UTC, Tom Wijsman (TomWij) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ville Syrjala 2013-04-03 11:07:06 UTC
Would be nice to have an ebuild for pnputils.

These days the de facto upstream for pnputils is here:
http://anonscm.debian.org/gitweb/?p=collab-maint/pnputils.git;a=summary

I'll attach an ebuild I've been using locally.

Reproducible: Always
Comment 1 Ville Syrjala 2013-04-03 11:07:34 UTC
Created attachment 344192 [details]
pnputils ebuild
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-03 13:14:18 UTC
Created attachment 344214 [details]
pnputils-9999.ebuild

Here are some small changes, I'm merely mentioning them so you can get an idea of how the EAPI and eclasses help in simplifying ebuild writing by introducing defaults.

1) Changed header to match /usr/portage/header.txt.
2) Changed to EAPI 5 (http://devmanual.gentoo.org/ebuild-writing/eapi/#eapi=5).
3) Filled in HOMEPAGE using debian URL, though I wonder whether we should mention this is a fork from the effort mentioned at https://lkml.org/lkml/2006/7/6/346.
4) Removed empty variables.
5) The git eclass defines defaults phase functions (http://devmanual.gentoo.org/eclass-reference/git-2.eclass), therefore src_unpack can be removed as the default phase function alraedy covers this.
6) Similarly, the EAPI also defines default phase functions (see EAPI link above) therefore src_compile and src_install can be removed as well.

Extensively tested, works quite well.
Comment 3 Ville Syrjala 2013-04-03 15:17:13 UTC
(In reply to comment #2)
> Created attachment 344214 [details]
> pnputils-9999.ebuild
> 
> Here are some small changes, I'm merely mentioning them so you can get an
> idea of how the EAPI and eclasses help in simplifying ebuild writing by
> introducing defaults.

OK. Simpler is better.

> 3) Filled in HOMEPAGE using debian URL, though I wonder whether we should
> mention this is a fork from the effort mentioned at
> https://lkml.org/lkml/2006/7/6/346.

Fork isn't quite the right word since the original tarballs were lost when kernel.org was rebuilt. I actually exchanged some emails with Bjorn about the fate of pnputils about a year ago. I had some patches I wanted to get in, but the tarballs were gone, Bjorn hadn't touched pnputils in a long time, and he was rather busy with other things. So I suggested that I try to get my changes to the debian.org repo instead, and he was happy with that solution.
Comment 4 Larry the Git Cow gentoo-dev 2019-12-07 15:47:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd1156da73572b61d56cd91c5c17fc08b59ab8e5

commit dd1156da73572b61d56cd91c5c17fc08b59ab8e5
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2019-12-07 15:23:44 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2019-12-07 15:46:29 +0000

    sys-apps/pnputils: New package
    
    This package contains two tools for interacting with Plug and Play BIOSes.
    
    Closes: https://bugs.gentoo.org/464330
    Package-Manager: Portage-2.3.80, Repoman-2.3.19
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 sys-apps/pnputils/Manifest                         |  1 +
 .../pnputils/files/pnputils-0.1-makefile.patch     | 24 +++++++++++++++++++++
 sys-apps/pnputils/metadata.xml                     | 13 +++++++++++
 sys-apps/pnputils/pnputils-0.1.ebuild              | 25 ++++++++++++++++++++++
 4 files changed, 63 insertions(+)