Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 459678 - cmake-utils.eclass: please consider dropping 'base' inherit and EAPI<2 support
Summary: cmake-utils.eclass: please consider dropping 'base' inherit and EAPI<2 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on: 460572
Blocks:
  Show dependency tree
 
Reported: 2013-02-28 09:08 UTC by Michał Górny
Modified: 2013-07-02 13:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-28 09:08:58 UTC 
base.eclass is broken by design and exports src_unpack() in every EAPI, making it hard to work with VCS eclasses and is generally a very bad practice.

Please consider dropping the inherit and inlining the necessary logic in cmake-utils_src_prepare(). Dropping EAPI<2 support (it is used just by a few ebuilds) would probably be doable at the same time.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2013-02-28 14:11:06 UTC 
Yes please!
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2013-03-06 07:40:27 UTC 
+1
Comment 3 Chris Reffett (RETIRED) gentoo-dev Security 2013-04-16 15:34:57 UTC 
A testing version of this is in the KDE overlay.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2013-06-27 18:22:05 UTC 
July is coming up, I guess the last thing to do is to check if any packages inheriting cmake-utils call base_* without explicitly inheriting.
Comment 5 Chris Reffett (RETIRED) gentoo-dev Security 2013-07-02 13:38:17 UTC 
Committed the change last night.