GammaRay is a tool to poke around in a Qt-application and also to manipulate the application to some extent Reproducible: Always
Created attachment 334562 [details, diff] Adding GammaRay ebuilds The attached patch adds the two latest versions plus a live ebuild.
Created attachment 337908 [details, diff] Adding GammaRay 1.3.0 ... and while we wait for somebody to look at this bug report, GammaRay 1.3.0 was released, so I'm adding the ebuild here.
Created attachment 338056 [details, diff] Adding GammaRay ebuilds Recreated all the patch because I just noticed I didn't add dependencies to the ebuilds
For anyone interested, this is now in my personal repo http://git.overlays.gentoo.org/gitweb/?p=user/dMaggot.git;a=summary
David, would you be interested in proxy-maintaining this package?
(In reply to Davide Pesavento from comment #5) > David, would you be interested in proxy-maintaining this package? Yes, very much.
The ebuild needs some work. Right now, no slots are specified, so whether qt4 or qt5 is used is "automagic".
Created attachment 396892 [details] Sample live ebuild Sorry for the delay. I have been working on this and this is what I have so far for the live ebuild. Let me know if it requires modifications or if I should proceed with the ebuild for 2.2.0 based on this.
Thanks. The ebuild is hard to review due to major indentation issues. Please fix those first, and remember that standard indentation is 1 tab in ebuilds. Also: * sort IUSE alphabetically * one REQUIRED_USE constraint per line * you're mixing :5 and >=5.4.0 deps for qt modules, be consistent and use the same dep atom everywhere unless there's a good reason to do otherwise * kjobtracker USE flag can maybe be renamed to 'kde' (?)
Created attachment 396986 [details] Revised sample live ebuild Addressed all issues from the review. Is there an indentation policy for multiline strings?
(In reply to David E. Narváez from comment #10) > Addressed all issues from the review. Is there an indentation policy for > multiline strings? Yes, they're normally indented. Same for bash arrays. E.g. DEPEND=" foo/bar >=foo/baz-2 " src_configure() { local foo=( bar baz ) default } Sort dependency atoms alphabetically too. I usually put all mandatory deps at the beginning, and optional deps at the end (sorted by USE flag name). This is somewhat personal though and less important than correct indentation. E.g. DEPEND=" a-cat/pkg e-cat/pkg opt-flag? ( f-cat/pkg ) use-flag? ( d-cat/pkg ) " And as you can see, if you have only one atom between ( and ), write everything in one line.
Created attachment 399582 [details] Fixing indentation and alphabetical sorting Sorry for the delay, here is a new version that I think addresses all the issues raised.
Thanks. I have a few more comments/requests before the ebuild can be committed: * port to EAPI=5 * a description of all non-global USE flags is needed, and possibly of global ones whose purpose differs from the global description * according to Install.txt, graphviz is optional * the qtwebkit dependency is also optional AFAICS * the minimum qt5 version seems to be 5.1.0 (correct me if I'm wrong), so change all instances of >=5.4.0 to :5 * add explicit qtcore dependencies * where is qtxml used? * mycmakeargs is a bash array
(In reply to Davide Pesavento from comment #13) Thanks, I fixed most of the issues except: > * the qtwebkit dependency is also optional AFAICS My problem with that is that the webinspector will be half-built even if I disable qtwebkit so between a half-built plugin and a fully working plugin I chose to make the dependency hard. I understand qtwebkit is a heavy burden so if you think it is better to leave it optional, I will agree with that. > * the minimum qt5 version seems to be 5.1.0 (correct me if I'm wrong), so > change all instances of >=5.4.0 to :5 I meant to add >=5.2.2, I must have made a mistake when doing that. This is because of a line in CMakeLists.txt that reads "Disabling timer profiler plug-in due to a bug in Qt5 <= 5.2.1." and I wanted to avoid that. Do you suggest I change everything to 5.2.2 or just keep it :5?
(In reply to David E. Narváez from comment #14) > (In reply to Davide Pesavento from comment #13) > > * the qtwebkit dependency is also optional AFAICS > > My problem with that is that the webinspector will be half-built even if I > disable qtwebkit so between a half-built plugin and a fully working plugin I > chose to make the dependency hard. I understand qtwebkit is a heavy burden > so if you think it is better to leave it optional, I will agree with that. > I strongly suggest to make it optional, not everybody needs the webinspector. What do you mean by "half-built"? Can you disable it entirely with USE=-webkit? > > * the minimum qt5 version seems to be 5.1.0 (correct me if I'm wrong), so > > change all instances of >=5.4.0 to :5 > > I meant to add >=5.2.2, I must have made a mistake when doing that. This is > because of a line in CMakeLists.txt that reads "Disabling timer profiler > plug-in due to a bug in Qt5 <= 5.2.1." and I wanted to avoid that. Do you > suggest I change everything to 5.2.2 or just keep it :5? Just ":5". The first version to hit the tree was 5.3.1, we don't have to care about anything older than that.
(In reply to Davide Pesavento from comment #15) > I strongly suggest to make it optional, not everybody needs the > webinspector. What do you mean by "half-built"? Can you disable it entirely > with USE=-webkit? Means if I disable finding QtWebkit, it will build the webinspector, just not fully featured. I think this is a weird build behavior, so I thought I would just make it required. > > I meant to add >=5.2.2, I must have made a mistake when doing that. This is > > because of a line in CMakeLists.txt that reads "Disabling timer profiler > > plug-in due to a bug in Qt5 <= 5.2.1." and I wanted to avoid that. Do you > > suggest I change everything to 5.2.2 or just keep it :5? > > Just ":5". The first version to hit the tree was 5.3.1, we don't have to > care about anything older than that. Ok, great, will do.
Created attachment 401644 [details] Ebuild with webinspector USE flag Added the webinspector USE flag to make the dependency to qtwebkit optional.
Created attachment 401646 [details] Description of USE flags Adding a metadata.xml file to describe the USE flags.
I was about to file a bug report about gammaray as a new package. I can't find it in portage though, is it removed? I wrote an ebuild that tries to handle the automagical deps of GammaRay : https://github.com/Petross404/testing/blob/master/dev-util/gammaray/gammaray-2.8.0.ebuild It's not perfect though. If some fellow gentoo user is willing to give it a try and improve it, I would be very happy.
David, are you still there? There has been a Pullrequest in the making for a long time, but it was held back for some build issue with latest versions of Qt, maybe upstream's latest release 2.11.1 would have that fixed.
