Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 435664 - app-mobilephone/smstools 3.1.14-r2 - creation of /var/run/smsd.{pid,working} is not possible
Summary: app-mobilephone/smstools 3.1.14-r2 - creation of /var/run/smsd.{pid,working} ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 15:17 UTC by Tomasz Chilinski
Modified: 2012-12-20 10:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
init.d script patch (smsd.initd2.patch,474 bytes, patch)
2012-09-20 17:42 UTC, Tomasz Chilinski
Details | Diff
smstools source patch (smstools-3.1.14-var-run-fix.patch,419 bytes, patch)
2012-09-20 17:43 UTC, Tomasz Chilinski
Details | Diff
ebuild patch (smstools-3.1.14-r2.ebuild.patch,550 bytes, patch)
2012-09-20 17:44 UTC, Tomasz Chilinski
Details | Diff
modify smsd.initd2 file (smsd.initd2-try2.patch,595 bytes, patch)
2012-09-20 18:44 UTC, Tomasz Chilinski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Chilinski 2012-09-20 15:17:21 UTC
As in summary.
We need to:
1) Append the following lines in src_install():
diropts -o smsd -g sms -m0770
keepdir /var/run/smsd
2) Change:
	start-stop-daemon -b -u smsd:sms --start --exec /usr/bin/smsd -- \
		-c /etc/smsd.conf
to:
	start-stop-daemon -b -u smsd:sms --start --exec /usr/bin/smsd -- \
		-c /etc/smsd.conf -p /var/run/smsd/smsd.pid -i /var/run/smsd/smsd.working
in ${FILESDIR}/smsd.initd2 file.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-09-20 15:48:46 UTC
keepdir /var/run should not be used at all (bug #332633).
Comment 2 Tomasz Chilinski 2012-09-20 17:42:24 UTC
Created attachment 324414 [details, diff]
init.d script patch

creation of /var/run/smsd directory during before deamon startup
Comment 3 Tomasz Chilinski 2012-09-20 17:43:39 UTC
Created attachment 324418 [details, diff]
smstools source patch

smstools: use of /var/run/smsd directory for pidfile and infofile
Comment 4 Tomasz Chilinski 2012-09-20 17:44:55 UTC
Created attachment 324420 [details, diff]
ebuild patch

ebuild patch for 3.1.14-r2
Comment 5 Tomasz Chilinski 2012-09-20 17:46:15 UTC
Ok, so I've prepared patches for smstools which take your advice in its mind.
Comment 6 Tomasz Chilinski 2012-09-20 18:44:37 UTC
Created attachment 324428 [details, diff]
modify smsd.initd2 file

I decided to not modify any other files than smsd.initd2.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2012-12-20 10:41:27 UTC
+*smstools-3.1.15 (20 Dec 2012)
+
+  20 Dec 2012; Tony Vroon <chainsaw@gentoo.org> +smstools-3.1.15.ebuild,
+  +files/smsd.initd3:
+  Cope with sudden new /run semantics, fix by Tomasz Chilinski in bug #435664.
+  Bump to version 3.1.15 as requested by Kilburn Abrahams in bug #439376.