Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 430606 - =x11-libs/qt-gui-4.8.2 - Calculator shortcut key on keyboards doesn't work
Summary: =x11-libs/qt-gui-4.8.2 - Calculator shortcut key on keyboards doesn't work
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-08-09 14:48 UTC by Matthew Schultz
Modified: 2012-08-23 06:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qt-gui-4.8.2-calculator-key.patch (qt-gui-4.8.2-calculator-key.patch,1.53 KB, patch)
2012-08-09 14:49 UTC, Matthew Schultz
Details | Diff
qt-gui-4.8.2-calculator-key.patch (qt-gui-4.8.2-calculator-key.patch,839 bytes, patch)
2012-08-09 15:58 UTC, Matthew Schultz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Schultz 2012-08-09 14:48:24 UTC
It appears that the calculator key shortcut issue isn't an issue with kde-base/kdelibs-4.7.*,4.8.*,4.9* as I originally thought in bug 406049.  An upstream developer for KDE mentioned that it's likely a problem with qt-gui.  So I created a patch to test the theory, recompiled qt-gui-4.8.2 with the patch, removed the calculator patch from kdelibs and recompiled that.  As a result, the bug is also fixed this way but in a better way since when you register the shortcut like in kmenuedit for example, the shortcut shows up as "Calculator" instead of Launch (1).  So I believe it would be better if you patch qt-gui instead of kdelibs since whatever depends on qt-gui that might use this code would also be affected.  I will attach my patch for qt-gui as well.

Reproducible: Always
Comment 1 Matthew Schultz 2012-08-09 14:49:00 UTC
Created attachment 320800 [details, diff]
qt-gui-4.8.2-calculator-key.patch
Comment 2 Matthew Schultz 2012-08-09 15:58:48 UTC
Created attachment 320806 [details, diff]
qt-gui-4.8.2-calculator-key.patch

My original patch didn't account for keyboards that register the calculator key as 0x1008FF54.  This patch would work for both types of keyboards that register the calculator key as 0x1008FF1D or 0x1008FF54.
Comment 3 Matthew Schultz 2012-08-09 17:46:49 UTC
I just created a ticket under the upstream qt tracker as well: https://bugreports.qt-project.org/browse/QTBUG-26812

So maybe the guys at KDE (https://bugs.kde.org/show_bug.cgi?id=257900) can push it to QT or the QT devs can handle it.
Comment 4 Davide Pesavento (RETIRED) gentoo-dev 2012-08-10 01:14:07 UTC
The only way to submit patches to Qt upstream is through gerrit (https://codereview.qt-project.org/)
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2012-08-17 09:14:03 UTC
(In reply to comment #4)
> The only way to submit patches to Qt upstream is through gerrit
> (https://codereview.qt-project.org/)

Once you've done that, please add a link to the gerrit merge request here, so that we can follow how it evolves.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2012-08-23 06:18:05 UTC
Closing UPSTREAM per my previous comments.