Bug 430010 – app-admin/webapp-config-1.50.19 fails test: WebappConfig.content.Contents

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Toralf Förster 2012-08-05 14:10:33 UTC]

======================================================================
FAIL: add (WebappConfig.content.Contents)
Doctest: WebappConfig.content.Contents.add
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/doctest.py", line 2201, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for WebappConfig.content.Contents.add
  File "/var/tmp/portage/app-admin/webapp-config-1.50.19/work/webapp-config-1.50.19/WebappConfig/content.py", line 324, in add

----------------------------------------------------------------------


Reproducible: Always

[Comment 1 Toralf Förster 2012-08-05 14:10:56 UTC]

Created attachment 320456 [details]
build log

[Comment 2 Anthony Basile 2013-12-08 13:18:45 UTC]

(In reply to Toralf Förster from comment #0)
> ======================================================================
> FAIL: add (WebappConfig.content.Contents)
> Doctest: WebappConfig.content.Contents.add
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/doctest.py", line 2201, in runTest
>     raise self.failureException(self.format_failure(new.getvalue()))
> AssertionError: Failed doctest test for WebappConfig.content.Contents.add
>   File
> "/var/tmp/portage/app-admin/webapp-config-1.50.19/work/webapp-config-1.50.19/
> WebappConfig/content.py", line 324, in add
> 
> ----------------------------------------------------------------------
> 
> 
> Reproducible: Always

Devan, is this a test that we can safely ignore pending stabilization or do we need to fix something before proceeding?

[Comment 3 Devan Franchini (RETIRED) 2013-12-08 19:47:04 UTC]

(In reply to Anthony Basile from comment #2)
> (In reply to Toralf Förster from comment #0)
> > ======================================================================
> > FAIL: add (WebappConfig.content.Contents)
> > Doctest: WebappConfig.content.Contents.add
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/doctest.py", line 2201, in runTest
> >     raise self.failureException(self.format_failure(new.getvalue()))
> > AssertionError: Failed doctest test for WebappConfig.content.Contents.add
> >   File
> > "/var/tmp/portage/app-admin/webapp-config-1.50.19/work/webapp-config-1.50.19/
> > WebappConfig/content.py", line 324, in add
> > 
> > ----------------------------------------------------------------------
> > 
> > 
> > Reproducible: Always
> 
> Devan, is this a test that we can safely ignore pending stabilization or do
> we need to fix something before proceeding?

For stabilization, yeah. Python's doctest simply checks to see if the documented code in the comments still works as they are documented. 

See here: http://docs.python.org/2/library/doctest.html

I could always go through the code and find out where things aren't working the way they are documented but it is to be expected since we've changed quite a bit of the code base.

[Comment 4 Anthony Basile 2013-12-08 21:33:59 UTC]

(In reply to Devan Franchini from comment #3)
> (In reply to Anthony Basile from comment #2)
> > (In reply to Toralf Förster from comment #0)
> > > ======================================================================
> > > FAIL: add (WebappConfig.content.Contents)
> > > Doctest: WebappConfig.content.Contents.add
> > > ----------------------------------------------------------------------
> > > Traceback (most recent call last):
> > >   File "/usr/lib/python2.7/doctest.py", line 2201, in runTest
> > >     raise self.failureException(self.format_failure(new.getvalue()))
> > > AssertionError: Failed doctest test for WebappConfig.content.Contents.add
> > >   File
> > > "/var/tmp/portage/app-admin/webapp-config-1.50.19/work/webapp-config-1.50.19/
> > > WebappConfig/content.py", line 324, in add
> > > 
> > > ----------------------------------------------------------------------
> > > 
> > > 
> > > Reproducible: Always
> > 
> > Devan, is this a test that we can safely ignore pending stabilization or do
> > we need to fix something before proceeding?
> 
> For stabilization, yeah. Python's doctest simply checks to see if the
> documented code in the comments still works as they are documented. 
> 
> See here: http://docs.python.org/2/library/doctest.html
> 
> I could always go through the code and find out where things aren't working
> the way they are documented but it is to be expected since we've changed
> quite a bit of the code base.

I think we should see which doctest is failing since some documented interactive session is not working as it should.  This may be important.  My guess is its a python 2.7 vs 3.2 issue.

[Comment 5 Devan Franchini (RETIRED) 2013-12-08 23:38:04 UTC]

(In reply to Anthony Basile from comment #4)
> I think we should see which doctest is failing since some documented
> interactive session is not working as it should.  This may be important.  My
> guess is its a python 2.7 vs 3.2 issue.

It's possible, but I don't think so. Seeing as this bug was submitted prior to python3.2 being on the portage tree. But as I said, it could be possible. We'll need to see where the doctest is failing.

[Comment 6 Anthony Basile 2014-01-05 13:45:46 UTC]

This test has been disabled because it leads to a false positive.  Please test webapp-config-1.52-r1 and reopen if this is still an issue.