Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 424193 - games-strategy/vcmi-0.89.ebuild - a free HOMM 3 clone
Summary: games-strategy/vcmi-0.89.ebuild - a free HOMM 3 clone
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement with 1 vote (vote)
Assignee: Default Assignee for New Packages
URL: http://forum.vcmi.eu/portal.php
Whiteboard:
Keywords: EBUILD, PATCH
Depends on: 424191
Blocks:
  Show dependency tree
 
Reported: 2012-06-30 03:47 UTC by Weihua Zhou
Modified: 2021-03-05 12:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The ebuild for vcmi 0.89 version (vcmi-0.89.ebuild,992 bytes, text/plain)
2012-06-30 03:47 UTC, Weihua Zhou
Details
The patch file for compiling under gcc 4.5 (vcmi-0.89-compile-fix.patch,4.29 KB, patch)
2012-07-02 02:38 UTC, Weihua Zhou
Details | Diff
The svn version of vcmi (vcmi-9999.ebuild,921 bytes, text/plain)
2012-07-02 02:39 UTC, Weihua Zhou
Details
Add eautoreconf in src_prepare to avoid QA Notice (vcmi-0.89.ebuild,1017 bytes, text/plain)
2012-07-19 00:09 UTC, Weihua Zhou
Details
The svn version of vcmi (vcmi-9999.ebuild,946 bytes, text/plain)
2012-07-19 00:13 UTC, Weihua Zhou
Details
The ebuild for vcmi 0.89 version (vcmi-0.89.ebuild,936 bytes, text/plain)
2012-07-19 00:17 UTC, Weihua Zhou
Details
Ebuild for 0.96 and live git versions (vcmi-0.96.ebuild,1.87 KB, text/plain)
2014-07-07 17:57 UTC, nE0sIghT
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Weihua Zhou 2012-06-30 03:47:00 UTC
Created attachment 316727 [details]
The ebuild for vcmi 0.89 version

Hi,

I have composed a set of ebuilds which include vcmi and vcmi-data for the project VCMI, which is a very good project for cloning the classic turn-based strategy game Heroes of Might & Magic III (HOMMIII). I think it's important to share it with other people who like this project.

This is the game engine of VCMI, it depends on the following packages:
sys-libs/zlib media-video/ffmpeg media-libs/libsdl media-libs/sdl-ttf media-libs/sdl-image media-libs/sdl-mixer.

And also it depends on the vcmi-data package which I have submitted in Bug 424191.

This ebuild needs to do some patching to the source tarball. So you need to put the attached vcmi-0.89-compile-fix.patch in the files directory.

Because I have not test it on x86 version gentoo. I hope someone can test this package on x86.

I have also composed a subversion version of vcmi.

Weihua
Comment 1 Weihua Zhou 2012-06-30 04:08:21 UTC
I've been trying to post the patch file here but with no luck yet. Maybe you will need to wait for a while for my network to work.
Comment 2 Weihua Zhou 2012-07-02 02:38:28 UTC
Created attachment 316937 [details, diff]
The patch file for compiling under gcc 4.5

Just put this patch file under files directory and the ebuild should work.
Comment 3 Weihua Zhou 2012-07-02 02:39:34 UTC
Created attachment 316939 [details]
The svn version of vcmi
Comment 4 Weihua Zhou 2012-07-19 00:09:59 UTC
Created attachment 318592 [details]
Add eautoreconf in src_prepare to avoid QA Notice
Comment 5 Weihua Zhou 2012-07-19 00:13:01 UTC
Created attachment 318594 [details]
The svn version of vcmi

Add eautoreconf in src_prepare to avoid QA Notice
Comment 6 Weihua Zhou 2012-07-19 00:17:00 UTC
Created attachment 318596 [details]
The ebuild for vcmi 0.89 version

I just found I uploaded a wrong one, this one should be correct.
Comment 7 Julian Ospald 2012-07-19 15:55:32 UTC
- patch fails here.
- dropbox url is not reliable imo. Use something like googlecode or github download section
- visual style can be improved, too many newlines, do something like this:

EAPI=4
inherit eutils games autotools

DESCRIPTION=""
HOMEPAGE=""
SRC_URI=""

LICENSE=""
SLOT=""
KEYWORDS=""
IUSE=""
RESTRICT=""

RDEPEND=""
DEPEND=""


- is there a minimum boost version? (often the case, look at configure.ac)
- no useflag deps for ffmpeg, libsdl, sdl-image and sdl-mixer?
- no period at end of description
- RDEPEND="${DEPEND}" <- that is a silly line imo, although it's standard for the vim-skeleton and such. Even if it's correct in a particular case this often leads to people adding things like "pkgconfig" to runtime-dependencies.
The cleanest way is to have 3 types of dependencies... runtime-only (RDEPEND), buildtime-only (DEPEND) and build/run-time deps (COMMON_DEPEND)
that would lead to something like this
COMMON_DEPEND="..."
RDEPEND="${COMMON_DEPEND} ..."
DEPEND="${COMMON_DEPEND}..."

since you often don't have runtime-only deps you can simply do

RDEPEND="..."
DEPEND="${RDEPEND} ..."

...means: you start with runtime deps.


- virtual/pkgconfig missing from DEPEND
- inherit games eclass always last (this will please the games herd)
- FILESDIR variable must be quoted.
- do not sed on Makefile.in
- desktopdir does not need any fix afais
- if you fix icondir, do it right and change the destination to an appropriate subdir like:
icondir = $(datadir)/icons/hicolor/64x64/apps
Then you have to update the icon cache via gnome2-utils like:

pkg_preinst() {
	games_pkg_preinst
	gnome2_icon_savelist
}

pkg_postinst() {
	games_pkg_postinst
	gnome2_icon_cache_update
}

pkg_postrm() {
	gnome2_icon_cache_update
}


- "prepgamesdirs" is completely missing.
Comment 8 Julian Ospald 2012-08-05 14:17:40 UTC
package disrespects CFLAGS/CXXFLAGS
Comment 9 nE0sIghT 2014-07-07 17:57:04 UTC
Created attachment 380392 [details]
Ebuild for 0.96 and live git versions

Here is new ebuild.

VCMI optionally depends on qt:5 packages (available in qt overlay) when editor or launcher flags used.