423687 – media-tv/linuxtv-dvb-apps - Please enable building of alevt

Bug 423687 - media-tv/linuxtv-dvb-apps - Please enable building of alevt

Summary: media-tv/linuxtv-dvb-apps - Please enable building of alevt

Status:	RESOLVED TEST-REQUEST

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal with 1 vote (vote)
Assignee:	Television related Applications in Gentoo's Portage

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2012-06-26 18:04 UTC by Tobias Leupold
Modified:	2013-06-02 18:40 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch for util/alevt/exp-gfx.c to make compilation work (exp-gfx.c.patch,285 bytes, patch) 2012-06-26 18:04 UTC, Tobias Leupold	Details \| Diff
patch for alevt's exp-gfx.c (alevt_exp-gfx.patch,307 bytes, patch) 2012-06-27 13:51 UTC, Tobias Leupold	Details \| Diff
patch for alevt's Makefile (alevt_makefile.patch,489 bytes, patch) 2012-06-27 13:52 UTC, Tobias Leupold	Details \| Diff
ebuild with USE flag "alevt" added (linuxtv-dvb-apps-1.1.1.20100223.ebuild,2.61 KB, text/plain) 2012-06-27 13:53 UTC, Tobias Leupold	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tobias Leupold 2012-06-26 18:04:53 UTC

Created attachment 316351 [details, diff]
Patch for util/alevt/exp-gfx.c to make compilation work

The latest linuxtv-dvb-apps ebuild (1.1.1.20100223) does not build alevt, although an DVB capable version is included in the sources. I suppose to add a USE-Flag (e. g. "alevt" or "videotext" or so) that enables building it.

The code resides in util/alevt. I had to install media-libs/zvbi with USE="v4l" and patch exp-gfx.c (see attached patch), but after that, it built just fine (by simply starting make) and works!

Would be really cool if this was included in the official ebuild as there's no really good program to view videotext from DVB(-T) other than alevt, and media-video/alevt-1.6.2 does not include Support for DVB.

Comment 1 Tobias Leupold 2012-06-27 13:51:56 UTC

Created attachment 316443 [details, diff]
patch for alevt's exp-gfx.c

Comment 2 Tobias Leupold 2012-06-27 13:52:17 UTC

Created attachment 316445 [details, diff]
patch for alevt's Makefile

Comment 3 Tobias Leupold 2012-06-27 13:53:57 UTC

Created attachment 316447 [details]
ebuild with USE flag "alevt" added

Here's a modified ebuild that does have an "alevt" USE flag. When set, it builds and installs alevt. I'm really not sure if this is a clean or good way to do it. Please review the ebuild! At least, it works ;-)

Comment 4 Tobias Leupold 2012-06-27 14:05:27 UTC

Ps: Of course, if this ebuild makes it's way in the tree, it should block media-video/alevt when installes with USE="alevt". I Forgot to add this.

Comment 5 Michael Weber (RETIRED) gentoo-dev

2013-06-02 17:54:32 UTC

no conditional patching, pls. but looks fine.

Comment 6 Michael Weber (RETIRED) gentoo-dev

2013-06-02 18:40:14 UTC

+*linuxtv-dvb-apps-1.1.1.20100223-r1 (02 Jun 2013)
+
+  02 Jun 2013; Michael Weber <xmw@gentoo.org>
+  +files/linuxtv-dvb-apps-1.1.1.20100223-alevt.patch,
+  +files/linuxtv-dvb-apps-1.1.1.20100223-ldflags.patch,
+  +linuxtv-dvb-apps-1.1.1.20100223-r1.ebuild, metadata.xml:
+  Add alevt videotext decoder support (bug 423687, thanks Tobias Leupold), add
+  perl DEPEND (bug 433155, thanks bay), rename scan to scan-dvb (bug 348371,
+  thanks  Bill Prendergast), support LDFLAGS (bug 331095, thanks Olivier Huber
+  and thomasg).
+