Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 416773 - chromium.eclass: drop icons related elog messages in favor of RDEPEND on virtual/freedesktop-icon-theme
Summary: chromium.eclass: drop icons related elog messages in favor of RDEPEND on virt...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-20 18:17 UTC by Pacho Ramos
Modified: 2012-05-23 19:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screen shot (chrome-downloads.png,84.51 KB, image/png)
2012-05-22 13:04 UTC, Mike Gilbert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-05-20 18:17:44 UTC
I think that elog messages can now be dropped because virtual/freedesktop-icon-theme was added some time ago to resolve issues like this. It allows easy switch between icon set preferred by people and also allows to clean them when chromium is removed.

Thanks

Reproducible: Always
Comment 1 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-05-21 06:36:47 UTC
This is not so simple. Depending on DE Chromium loads different icons.

See bug #361859 and bug #352263. Unless a reasonable fix is suggested, this bug is a dupe.
Comment 2 Pacho Ramos gentoo-dev 2012-05-21 07:56:04 UTC
Well, when I read bug 352263 I (wrongly) thought that kde users were complaining because of extra dependencies needed by gnome-icon-theme, but looking to bug 361859 looks like chromium won't use gnome icons if it's running under KDE, in that case:
- Why not RDEPEND on oxygen icons with USE "kde" and on virtual when it's unset?
- Looks like it fallbacks to hicolor icon theme but that set misses needed image, in that case, do you know about any upstream report telling them the issue? Maybe they should contact to hicolor maintainers to include that icon (probably that icon could be used by other browsers as well), or chromium itself could provide that icon, or they could fallback to other icon themes before hicolor when running on kde.
Comment 3 Mike Gilbert gentoo-dev 2012-05-21 14:31:35 UTC
KDE users are guaranteed to have oxygen-icons; every KDE package depends on it.

I don't like the elog messages either. However, I don't think there is a set of dependencies that will satisfy everyone and still ensure complete coverage for the download list (bug 292201).

I do think elogging for every upgrade is overly redundant. Maybe we could do a check on REPLACING_VERSIONS and only elog about icons and fonts when the user installs the package for the first time.
Comment 4 Pacho Ramos gentoo-dev 2012-05-21 18:44:00 UTC
Are you sure dependencies included in virtual wouldn't work? They are:

RDEPEND="|| ( x11-themes/gnome-icon-theme
        x11-themes/faenza-icon-theme
        lxde-base/lxde-icon-theme
        x11-themes/tango-icon-theme
        kde-base/oxygen-icons )"
Comment 5 Mike Gilbert gentoo-dev 2012-05-21 21:11:09 UTC
These 3 only work if the user actually has their GTK icon theme set to one of them.

x11-themes/faenza-icon-theme
lxde-base/lxde-icon-theme
x11-themes/tango-icon-theme


gnome-icon-theme works for all non-KDE users, but I suspect there are users who will complain about it.
Comment 6 Mike Gilbert gentoo-dev 2012-05-21 21:17:13 UTC
To put it another way, a dependency on x11-themes/gnome-icon-theme is the only way to guarantee coverage, but some users don't want it.

Better to just leave it up to the user.
Comment 7 Pacho Ramos gentoo-dev 2012-05-22 08:32:18 UTC
What is the "offending" icon? Have you think in simply providing it with chromium and installing it under /usr/share/hicolor? (like other packages like opera does)
Comment 8 Mike Gilbert gentoo-dev 2012-05-22 13:04:18 UTC
Created attachment 312685 [details]
Screen shot

The original report for this was bug 292201.

Basically, we need icons for each mime type, or we get broken images in the downloads page. See screen shot.
Comment 9 Pacho Ramos gentoo-dev 2012-05-22 18:14:31 UTC
Then, if I have understood correctly, chromium only uses oxygen on kde and gnome-icon-them for all other DEs, no? And then, if people want to use any other theme, they need to specify it in gtkrc. Is there any upstream report suggesting them to fallback between various themes or provide themselves proper icons?

Until then, why not show the elog message only if neither oxygen and gnome-icon-theme are installed?
Comment 10 Mike Gilbert gentoo-dev 2012-05-22 18:25:03 UTC
(In reply to comment #9)
> Then, if I have understood correctly, chromium only uses oxygen on kde and
> gnome-icon-them for all other DEs, no? And then, if people want to use any
> other theme, they need to specify it in gtkrc. Is there any upstream report
> suggesting them to fallback between various themes or provide themselves
> proper icons?

I don't see that particular proposal specifically, but this report comes close.

http://code.google.com/p/chromium/issues/detail?id=102211

To be honest, the issue is so trivial that I just haven't cared enough to comment upstream.

> Until then, why not show the elog message only if neither oxygen and
> gnome-icon-theme are installed?

That sounds like a good idea to me.
Comment 11 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2012-05-22 19:41:25 UTC
(In reply to comment #10)
> > Until then, why not show the elog message only if neither oxygen and
> > gnome-icon-theme are installed?
> 
> That sounds like a good idea to me.

Same here. Feel free to modify chromium.eclass to do that.
Comment 12 Mike Gilbert gentoo-dev 2012-05-23 18:17:14 UTC
  23 May 2012; Mike Gilbert <floppym@gentoo.org> chromium.eclass:
  Don't elog about icons if the user has installed them. Bug 416773 by pacho.
Comment 13 Pacho Ramos gentoo-dev 2012-05-23 19:29:10 UTC
Thanks a lot :D

As a side note, why not add a "kde" USE flag to pull in oxygen-icons? That would allow gnome only users (like me) that have gnome-icon-theme but not oxygen-icons (because they don't need it at all) to not see the elog message. 

(I can do it of you want)