A lot of X.org related packages are passing -Werror= like -Werror=implicit-function-declaration A generic way to solve this would be to add 'append-flags -Wno-error' somewhere in xorg-2.eclass Bug 415949 Bug 415953
Created attachment 311897 [details, diff] xorg-2.eclass.patch
-Wno-error does not seem to de-activate specific -Werror=... checks.
It looks like Xorg packages support the following configure flag, which would be a better fix. --disable-selective-werror Turn off selective compiler errors. (default: enabled)
--disable-selective-werror comes from xorg-macros. Please use it.
Do we not have an X11 team anymore?
I guess we could handle this as currently done for disable-depencency-tracking in xorg-2.eclass no? (grep in configure looking for this option and appending it when available)
(In reply to Pacho Ramos from comment #6) > I guess we could handle this as currently done for > disable-depencency-tracking in xorg-2.eclass no? (grep in configure looking > for this option and appending it when available) Any problem with me doing that changes?
(In reply to Pacho Ramos from comment #6) > I guess we could handle this as currently done for > disable-depencency-tracking in xorg-2.eclass no? (grep in configure looking > for this option and appending it when available) Sounds good to me. Would be nice to hear from a maintainer though.
The issue is not that xorg packages indiscriminately use -Werror, as this bug blocking bug 260867 might suggest. The build system selectively turns certain compiler warnings into errors (-Werror=array-bounds among others) which are known to have been indications of real problems in the past. I am not comfortable with this change, but other x11 members might want chime in too.
It doesn't matter if it's selective warnings or not, -Werror is not allowed in the tree. Half the bugs I had filed for GCC 4.8 were caused by this. It's a powderkeg for anyone running anything but the current GCC release (eg. older GCC releases are really bad for -Warray-bounds false positives).
(In reply to Pacho Ramos from comment #6) > I guess we could handle this as currently done for > disable-depencency-tracking in xorg-2.eclass no? (grep in configure looking > for this option and appending it when available) I've sent a patch that does this for review to gentoo-dev@.
Committed as commit 6aaaf15f8882dd112d22454600294e37969fa822 Author: Matt Turner <mattst88@gentoo.org> Date: Sun Jan 29 11:30:39 2017 -0800 xorg-2.eclass: Use --disable-selective-werror.
