Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415279 - net-misc/miniupnpd: replace iptables with firewall in init-script depends
Summary: net-misc/miniupnpd: replace iptables with firewall in init-script depends
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: PATCH
Depends on: 555120
Blocks:
  Show dependency tree
 
Reported: 2012-05-09 18:03 UTC by Vladislav Poluhin
Modified: 2019-06-30 07:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Poluhin 2012-05-09 18:03:45 UTC
I use shorewall instead iptables. I do not want to run iptables. See patch:


--- miniupnpd   2012-05-10 02:00:21.000000000 +0800
+++ miniupnpd.new       2012-05-10 02:01:01.000000000 +0800
@@ -4,7 +4,7 @@
 # $Header: /var/cvsroot/gentoo-x86/net-misc/miniupnpd/files/miniupnpd-init.d,v 1.3 2011/10/17 12:03:01 gurligebis Exp $
 
 depend() {
-       need net iptables
+       need net firewall
        use minissdpd
 }
Comment 1 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2012-06-03 14:19:17 UTC
Well, miniupnpd needs iptables to work, so what is the point in trying to use it without iptables?
Comment 2 Vladislav Poluhin 2012-06-03 14:39:21 UTC
(In reply to comment #1)
> Well, miniupnpd needs iptables to work, so what is the point in trying to
> use it without iptables?

Shorewall is iptables wrapper. And miniupnpd works fine with that patch:

$ /etc/init.d/iptables status
 * status: stopped
Comment 3 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2012-06-03 15:02:04 UTC
Ahh, okay :)

I'll update miniupnpd to version 1.7 and add this patch later today.
Comment 4 Bjarke Istrup Pedersen (RETIRED) gentoo-dev 2012-06-03 16:21:25 UTC
Took a look at it - it seems the iptables init script does not have "provide firewall", so this is not an option ATM.

Please create a new bug about that, and mark it as a blocker for this bug.
Once that has been fixed, I'll update the init script for miniupnpd.
Comment 5 Conrad Kostecki gentoo-dev 2015-07-16 21:40:02 UTC
I've created a blocker ticket.
The current snapshot also supports now nftables, not only iptables.
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2015-07-17 13:44:52 UTC
The issue isn't really that "provide firewall" gives all the necessary bits. There's IPv6 which is in ip6tables and ebtables. There would need to be agreed upon provides for all of those.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-06-30 07:08:44 UTC
I guess I'll just put a long list of options in 'use'.  This won't be perfect but at least should work for most people, and cover different preferences.
Comment 8 Larry the Git Cow gentoo-dev 2019-06-30 07:39:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d25f119a7c8896aa16d183ff385adca8a1ccd7b9

commit d25f119a7c8896aa16d183ff385adca8a1ccd7b9
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-06-30 07:09:18 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-06-30 07:39:15 +0000

    net-misc/miniupnpd: Lower iptables dep to 'use' in init.d
    
    Closes: https://bugs.gentoo.org/415279
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-misc/miniupnpd/files/miniupnpd-init.d-r2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)