Created attachment 310673 [details, diff] patch EAPI-4 and Gentoo/Prefix support after running ecopy i needed to add ${EPREFIX} to the configure --prefix=/usr line. I've migrated the ebuild to EAPI-4, as sideeffect.
Created attachment 310675 [details, diff] patch EAPI-4 and Gentoo/Prefix support Portage 2.2.01.20430-prefix (prefix/linux/amd64, gcc-4.5.3, unavailable, 3.2.2-1-ARCH x86_64) ================================================================= System uname: Linux-3.2.2-1-ARCH-x86_64-AMD_FX-tm-4100_Quad-Core_Processor-with-glibc2.2.5 Timestamp of tree: Thu, 03 May 2012 08:20:06 +0000 app-shells/bash: 4.2_p20::gentoo_prefix dev-lang/python: 2.7.2-r3::gentoo_prefix dev-util/pkgconfig: 0.26::gentoo_prefix sys-devel/autoconf: 2.68::gentoo_prefix sys-devel/automake: 1.11.5::gentoo_prefix sys-devel/binutils: 2.22-r1::gentoo_prefix sys-devel/gcc: 4.2.4-r01.4::gentoo_prefix, 4.5.3-r1::gentoo_prefix sys-devel/gcc-config: 1.5-r2::gentoo_prefix sys-devel/libtool: 2.4.2::gentoo_prefix sys-devel/make: 3.82::gentoo_prefix sys-kernel/linux-headers: 3.3::gentoo_prefix (virtual/os-headers) Repositories: gentoo_prefix local xmw Installed sets: ACCEPT_KEYWORDS="~amd64-linux" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/portage /etc/terminfo" CXXFLAGS="-O2 -pipe" DISTDIR="/home/michael/gentoo-prefix/usr/portage/distfiles" FEATURES="assume-digests binpkg-logs collision-protect distlocks ebuild-locks fixlafiles force-prefix news parallel-fetch preserve-libs protect-owned sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch" FFLAGS="" GENTOO_MIRRORS="http://lore.xmw.de/gentoo/" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1" MAKEOPTS="-j4" PKGDIR="/home/michael/gentoo-prefix/usr/portage/packages" PORTAGE_CONFIGROOT="/home/michael/gentoo-prefix/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/home/michael/gentoo-prefix/var/tmp" PORTDIR="/home/michael/gentoo-prefix/usr/portage" PORTDIR_OVERLAY="/home/michael/gentoo-prefix/usr/local/portage /home/michael/gentoo-prefix/var/lib/layman/xmw" SYNC="rsync://rsync.prefix.freens.org/gentoo-portage-prefix" USE="amd64 berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm git iconv ipv6 mmx modules mudflap ncurses nls nptl nptlonly openmp pcre pppd prefix readline session sse sse2 ssl sysfs tcpd unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Feel free to commit.
+*ddrescue-1.15-r1 (03 May 2012) + + 03 May 2012; Michael Weber <xmw@gentoo.org> +ddrescue-1.15-r1.ebuild: + Revbump to improve Prefix support (bug 414457) +
1) Pointless revbump and 2) improper use of econf.
(In reply to comment #4) > 1) Pointless revbump and 2) improper use of econf. wrt 1) what happend to "don't touch stable ebuilds"? wrt 2) i'm fine with changing it back to ./configure ...
Well, you want to create revbumps when "files on disk change" otherwise you are wasting magnitudes of people's time. For the econf point, you should only use econf when the configure script is from autoconf, otherwise there *may* be unpredictable results (notice the comment in the ebuild that says why "./configure" is being used)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=713fc6bdfa10717ad7d6c7a0c709c1325d723fb0 commit 713fc6bdfa10717ad7d6c7a0c709c1325d723fb0 Author: Sam James <sam@gentoo.org> AuthorDate: 2025-03-23 05:36:09 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-03-23 05:36:44 +0000 sys-fs/ddrescue: add 1.29.1 While here, fix invalid use of `econf` given it's not a GNU Autoconf configure, just as the comment says! I also compared the arguments passed to another package maintained by the same upstream (app-arch/lzip) as a quick sanity check. Bug: https://bugs.gentoo.org/414457 Fixes: 301a06db81e6c720d3551291cc462970701a4de3 Signed-off-by: Sam James <sam@gentoo.org> sys-fs/ddrescue/Manifest | 1 + sys-fs/ddrescue/ddrescue-1.29.1.ebuild | 38 ++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+)
