Bug 407189 – media-sound/sndfile-tools-1.03 - uses -Werror during build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Piotr Szymaniak 2012-03-06 22:46:44 UTC]

Created attachment 304473 [details]
Build.log

i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I./src   -pthread -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15       -Werror -Os -march=pentium4 -pipe -fomit-frame-pointer -std=gnu99 -Wall -Wextra -Wstrict-prototypes -Wmissing-prototypes -Waggregate-return -Wcast-align -Wcast-qual -Wnested-externs -Wshadow -Wpointer-arith -MT src/kaiser_window_test.o -MD -MP -MF $depbase.Tpo -c -o src/kaiser_window_test.o src/kaiser_window_test.c &&\
mv -f $depbase.Tpo $depbase.Po
src/sndfile-jackplay.c: In function ‘main’:
src/sndfile-jackplay.c:173:2: error: ‘jack_client_new’ is deprecated (declared at /usr/include/jack/jack.h:97) [-Werror=deprecated-declarations]
cc1: all warnings being treated as errors


Portage 2.2.0_alpha89 (default/linux/x86/10.0, gcc-4.6.2, glibc-2.14.1-r2, 3.2.7 i686)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.2.7-i686-Intel-R-_Pentium-R-_4_CPU_2.60GHz-with-gentoo-2.1
Timestamp of tree: Fri, 02 Mar 2012 23:15:01 +0000
distcc 3.1 i686-pc-linux-gnu [disabled]
ccache version 3.1.7 [disabled]
app-shells/bash:          4.2_p20
dev-lang/python:          2.7.2-r3, 3.2.2
dev-util/ccache:          3.1.7
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1
sys-apps/openrc:          0.9.9.2
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.11.3
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.6.2
sys-devel/gcc-config:     1.5.1
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.2-r1 (virtual/os-headers)
sys-libs/glibc:           2.14.1-r2
Repositories: gentoo roslin neurogeek
Installed sets: 
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-Os -march=pentium4 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -march=pentium4 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://distfiles.ift.uni.wroc.pl/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/root/roslin /root/neurogeek"
SYNC="rsync://rsync1.pl.gentoo.org/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 modules mudflap nls nptl nptlonly openmp pam pcre pppd readline session ssl sysfs tcpd unicode x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga neomagic nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Steve Arnold 2013-09-15 02:36:15 UTC]

Created attachment 358676 [details, diff]
jack_client_new deprecated patch

Here's a patch if you want to give it a spin...

[Comment 2 Steve Arnold 2013-09-15 03:34:37 UTC]

Created attachment 358678 [details, diff]
updated  jack_client_new deprecated patch

Sorry, I meant this one...

[Comment 3 Steve Arnold 2013-11-17 05:02:35 UTC]

Anybody object if I just fix this one?

[Comment 4 Julian Ospald 2013-11-17 09:32:17 UTC]

that's not how you fix -Werror things

It has to be removed from the build system.

[Comment 5 Samuli Suominen (RETIRED) 2013-11-17 20:21:49 UTC]

(In reply to Julian Ospald (hasufell) from comment #4)
> that's not how you fix -Werror things
> 
> It has to be removed from the build system.

yep, the patch attached here should just be submitted upstream
and in tree, -Werror removed
however if the patch is *from* or *at* upstream, then both can be done, the patch applied AND -Werror removed

so it should be clear the patch alone is not enough, -Werror must be removed

[Comment 6 David Seifert 2016-02-13 18:39:37 UTC]

Can I close this?

commit 5d936317e6b3e6056b05666c2843b5499a020477
Author: David Seifert <[e-mail]>
Date:   Sat Feb 13 17:58:08 2016 +0100

    media-sound/sndfile-tools: Prevent configure adding -Werror to CFLAGS
    
    Gentoo-Bug: 542120
    * EAPI=6

[Comment 7 Larry the Git Cow 2018-01-21 10:20:03 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ee877b220dc152d1ce62859af765e614f66a9ed

commit 4ee877b220dc152d1ce62859af765e614f66a9ed
Author:     David Seifert <[e-mail]>
AuthorDate: 2018-01-21 10:19:29 +0000
Commit:     David Seifert <[e-mail]>
CommitDate: 2018-01-21 10:19:29 +0000

    media-sound/sndfile-tools: Version bump to 1.04
    
    Bug: https://bugs.gentoo.org/407189
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 media-sound/sndfile-tools/Manifest                 |  1 +
 .../sndfile-tools/sndfile-tools-1.04.ebuild        | 38 ++++++++++++++++++++++
 2 files changed, 39 insertions(+)}

[Comment 8 Larry the Git Cow 2018-02-08 00:10:37 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af72ecf66c716a2a0df0f7446de7c5f5b6b24c9d

commit af72ecf66c716a2a0df0f7446de7c5f5b6b24c9d
Author:     Michael Mair-Keimberger <[e-mail]>
AuthorDate: 2018-02-04 11:37:08 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2018-02-08 00:03:24 +0000

    media-sound/sndfile-tools: remove old
    
    Closes: https://bugs.gentoo.org/407189
    Closes: https://github.com/gentoo/gentoo/pull/7056

 .../sndfile-tools/sndfile-tools-1.03.ebuild        | 29 ----------------------
 1 file changed, 29 deletions(-)