Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 403123 - app-shells/gentoo-bashcomp - Add ebuild(1) --skip-manifest completion support
Summary: app-shells/gentoo-bashcomp - Add ebuild(1) --skip-manifest completion support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-11 05:32 UTC by Sergei Shilovsky
Modified: 2024-05-22 05:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed implementation of bash completion for ebuild command (gentoo.bash-completion.patch,1.63 KB, patch)
2013-11-08 04:43 UTC, Alexey Sarychev
Details | Diff
Refixed implementation (gentoo.bash-completion.patch,1.63 KB, patch)
2013-11-08 04:46 UTC, Alexey Sarychev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Shilovsky 2012-02-11 05:32:58 UTC
after 'ebuild --skip-manifest' completion does not work properly

Reproducible: Always

Steps to Reproduce:
1. # emerge gentoo-bashcomp
2. # ebuild --skip-m<Tab>anifest <Tab><Tab>

Actual Results:  
clean      config     digest     help       manifest   package    postrm     prepare    qmerge     setup      unmerge    
compile    configure  fetch      install    merge      postinst   preinst    prerm      rpm        test       unpack

Expected Results:  
list of ebuild files in current directory

--skip-manifest is completed only right after 'ebuild'
Comment 1 Sergei Shilovsky 2012-02-13 17:23:49 UTC
To be more precise, it DOES complete --skip-manifest and other options as well as ebuild file names.
But as soon as one option or ebuild file name is typed it allows only command completion (e.g. digest, clean etc.) which prohibits completion of statements like 'ebuild --skip-manifest my.ebuild digest' or 'ebuild my.ebuild --skip-manifest digest' or 'ebuild my.ebuild digest --skip-manifest'
Comment 2 Alexey Sarychev 2013-11-08 04:43:39 UTC
Created attachment 362770 [details, diff]
Fixed implementation of bash completion for ebuild command

That bug bugged me for quite some time - finally I got around to looking into it.
Current implementation for ebuild bashcomp is broken, patch with a working one is attached.
Comment 3 Alexey Sarychev 2013-11-08 04:46:42 UTC
Created attachment 362772 [details, diff]
Refixed implementation

Small clean-up of the previous patch - one line was redundant, sorry.
Comment 4 Larry the Git Cow gentoo-dev 2024-05-22 05:08:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gentoo-bashcomp.git/commit/?id=3c6e22334e041e6816e0e069e94f8d77da078631

commit 3c6e22334e041e6816e0e069e94f8d77da078631
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2024-05-22 05:07:58 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-05-22 05:07:58 +0000

    ebuild: fix, refactor and update completion
    
    Closes: https://bugs.gentoo.org/403123
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 completions/ebuild | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)