Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 386457 - net-analyzer/zabbix-1.8.7 fails with use oracle
Summary: net-analyzer/zabbix-1.8.7 fails with use oracle
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Matthew Marlowe (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 386175
  Show dependency tree
 
Reported: 2011-10-08 20:43 UTC by Ian Delaney (RETIRED)
Modified: 2011-10-09 08:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2011-10-08 20:43:50 UTC
Zabbix requires one database package.  Curiously, the oracle choice is just absent in the depend section of the ebuild, namely the COMMON_DEPEND section where the others are listed.


Reproducible: Always

Steps to Reproduce:
1. Select USE=oracle, de-select other database types.
2. emerge package
3.
Actual Results:  
The build log is not worth submitting, it is in full here, only a dozen or so lines.

 * Package:    net-analyzer/zabbix-1.8.7
 * Repository: gentoo
 * Maintainer: patrick@gentoo.org mattm@gentoo.org
 * USE:        agent amd64 curl elibc_glibc ipv6 kernel_linux ldap multilib oracle proxy server test userland_GNU
 * FEATURES:   sandbox test userpriv
 * 
 * The environment variable ORACLE_HOME must be set
 * and point to the correct location.
 * It looks like you don't have Oracle installed.
 * 
 * ERROR: net-analyzer/zabbix-1.8.7 failed (setup phase):
 *   Environment variable ORACLE_HOME is not set
 * 
 * Call stack:
 *             ebuild.sh, line  56:  Called pkg_setup
 *   zabbix-1.8.7.ebuild, line  77:  Called die
 * The specific snippet of code:
 *   				die "Environment variable ORACLE_HOME is not set"
 * 
 * If you need support, post the output of 'emerge --info =net-analyzer/zabbix-1.8.7',
 * the complete build log and the output of 'emerge -pqv =net-analyzer/zabbix-1.8.7'.
 * The complete build log is located at '/mnt/gen2/tmpdir/portage/net-analyzer/zabbix-1.8.7/temp/build.log'.
 * The ebuild environment file is located at '/mnt/gen2/tmpdir/portage/net-analyzer/zabbix-1.8.7/temp/die.env'.
 * S: '/mnt/gen2/tmpdir/portage/net-analyzer/zabbix-1.8.7/work/zabbix-1.8.7'



Expected Results:  
above flaws to be absent
Comment 1 Matthew Marlowe (RETIRED) gentoo-dev 2011-10-09 04:01:09 UTC
Hi Ian,

I'll have to look at this .... I've recently taken over maintainership of zabbix ebuilds and zabbix indeed does support oracle databases, but I'm unclear on how well gentoo itself supports oracle or what packages should be depended on for oracle...will review.  

The entire code for how the zabbix ebuild handle databases probably needs review.

MattM
Comment 2 Matthew Marlowe (RETIRED) gentoo-dev 2011-10-09 04:17:33 UTC
(In reply to comment #0)
> Zabbix requires one database package.  Curiously, the oracle choice is just
> absent in the depend section of the ebuild, namely the COMMON_DEPEND section
> where the others are listed.

OK...upon further review, I see why the current ebuild is the way it is -- there are two ways to support oracle in gentoo -

a) just install the proprietary oracle packages for a local server (no gentoo ebuilds? can't see any in main gentoo tree).  If someone installs oracle outside of portage, they'll have to manually set the ORACLE_HOME environment variable.

b) connect to a remote oracle server and install the oracle instantclient ebuilds from the portage tree.  Note that these ebuilds may set the ORACLE_HOME variable for the general oracle libraries/etc..

I'm not sure what the standard gentoo way for handling the above so both situations work.... or even if we have zabbix gentoo users actually using oracle.  

It sounds like the previous ebuild maintainer just left the situation for the user to handle, perhaps assuming situation #a would be the most common.
Comment 3 Matthew Marlowe (RETIRED) gentoo-dev 2011-10-09 04:22:05 UTC
For the moment, since #b is solvable within existing portage ebuilds, I'll handle it just be adding dependency on oracle instantlclient --- will commit an r1 for 1.8.7 shortly.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2011-10-09 04:26:17 UTC
good work mattm
Comment 5 Matthew Marlowe (RETIRED) gentoo-dev 2011-10-09 05:12:27 UTC
Fixed in tree - assuming that oracle-instantclient-basic is doing the right thing, but if it isn't that would be a different bug.

<CIA-88> mattm * gentoo-x86/net-analyzer/zabbix/ (ChangeLog zabbix-1.8.7-r1.ebuild zabbix-1.8.8-r1.ebuild): 
<CIA-88> Fix oracle use flag dependencies for Zabbix 1.8.7 and 1.8.8 per Bug #386457
<CIA-88> (Portage version: 2.1.10.22/cvs/Linux x86_64)
<willikins> CIA-88: https://bugs.gentoo.org/386457 "net-analyzer/zabbix-1.8.7 fails with use oracle"; Gentoo Linux, Applications; CONF; johneed:mattm
Comment 6 Ian Delaney (RETIRED) gentoo-dev 2011-10-09 08:10:01 UTC
by jove I think you've got it.

archtester xen-tools # USE="oracle -sqlite3" emerge zabbix

>>> Emerging (1 of 1) net-analyzer/zabbix-1.8.7
>>> Installing (1 of 1) net-analyzer/zabbix-1.8.7
Closing