I think would be interesting to add a QA check to warn us when a package is being built with Werror and, then, we can fix it before committing. Thanks Reproducible: Always
How are we supposed to know it's being built with -Werror, by searching the build log? We can do that along with the other _check_build_log stuff like this: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1ef4238727ec3cd69bda9bcae9ce899fd3e66f43
Not sure how Diego is checking for it... he already told be wasn't sure about to implement it into portage, but maybe it helps anyway :-/
(In reply to comment #1) > How are we supposed to know it's being built with -Werror, by searching the > build log? We can do that along with the other _check_build_log stuff like > this: > > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1ef4238727ec3cd69bda9bcae9ce899fd3e66f43 The problem of checking build.log is for packages using V=0 make option as, if I don't misremember, it won't show used flags (well, I would even suggest to use V=1 by default always as it gives more useful build.logs and people wanting quiet output should run emerge --quiet instead, but maybe this was already discussed)
yup, in particular the cmake-loving people hate any "non pretty" output written to stdout, which kills any opportunity to see what's going on.
(In reply to comment #4) > yup, in particular the cmake-loving people hate any "non pretty" output written > to stdout, which kills any opportunity to see what's going on. If it was already discussed, could you please point me to mailing list thread? I cannot find it (and don't have much time for searching more). Thanks a lot :) Of course, if you neither have time, don't worry, will re-search later
here you are: bug #306207 I can't find the discussion on -dev or -project ML
for autotools, we already have Bug 379497 to address this
(In reply to comment #6) > here you are: bug #306207 > > I can't find the discussion on -dev or -project ML Thanks, looks like, per comment https://bugs.gentoo.org/show_bug.cgi?id=306207#c11 we would have enough for checking build.log for used flags :D (In reply to comment #7) > for autotools, we already have Bug 379497 to address this Nice, well, maybe it will be delayed some time as looks like it would require and eapi bump :S, but happy to see it will be handled Once build.logs provide needed output, this could also be extended to detect -D[A-Z_]*DISABLE_DEPRECATED also I think
Maybe these checks could be added without waiting for eapi bump but, instead, asking people to set AM_DEFAULT_VERBOSITY themselves until then :-/
*** Bug 409955 has been marked as a duplicate of this bug. ***
verbose build log is policy now, so we should rely on it if a package does not show verbose log, then it's a bug.
As I can see in gentoo-dev ML, this would also be interesting for gcc-4.8 adoption. Could be done? :) Thanks a lot!
There are packages like app-shells/mksh that have a build system that echoes command lines during configure, and -Werror is required for many configure tests. So if we do come up with a check for -Werror we'd also need a way for ebuilds to turn it off.
any progress here?
No progress so far.
