Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 380161 - media-sound/mumble - add IUSE=jack
Summary: media-sound/mumble - add IUSE=jack
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: http://sourceforge.net/tracker/?func=...
Whiteboard: tracking upstream
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2011-08-21 23:27 UTC by ci3nte
Modified: 2018-08-21 19:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mumble-1.2.3 with jack-useflag (mumble-1.2.3-r2.ebuild,3.57 KB, text/plain)
2011-08-21 23:28 UTC, ci3nte
Details
patch for mumble-1.2.3 (mumble-jack-support-r2.patch,15.82 KB, patch)
2011-08-21 23:28 UTC, ci3nte
Details | Diff
original patch for mumble-1.2.2 (mumble-jack-support.patch,15.82 KB, text/plain)
2011-08-21 23:32 UTC, ci3nte
Details
mumble-1.2.2 with jack-useflag (mumble-1.2.2-r1.ebuild,3.36 KB, text/plain)
2011-08-21 23:33 UTC, ci3nte
Details
mumble-1.2.10-r2.ebuild (mumble-1.2.10-r2.ebuild,3.20 KB, text/plain)
2015-11-26 01:35 UTC, gerion
Details
mumble-jack-support.patch (mumble-jack-support.patch,15.88 KB, patch)
2015-11-26 01:37 UTC, gerion
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ci3nte 2011-08-21 23:27:03 UTC
mumble-1.2.2 and mumble-1.2.3 with direct jack-support

Reproducible: Always




FalkTX announced a patch for mumble-1.2.2 to have direct support to jack.
I modify the 1.2.2 and 1.2.3-ebuild and the patch a little bit that it works for both versions, but I'm not very experienced, so feel free to make it better.
Comment 1 ci3nte 2011-08-21 23:28:15 UTC
Created attachment 284181 [details]
mumble-1.2.3 with jack-useflag
Comment 2 ci3nte 2011-08-21 23:28:44 UTC
Created attachment 284183 [details, diff]
patch for mumble-1.2.3
Comment 3 ci3nte 2011-08-21 23:32:44 UTC
Created attachment 284185 [details]
original patch for mumble-1.2.2

Download from http://sourceforge.net/tracker/?func=detail&aid=3166072&group_id=147372&atid=768007
Comment 4 ci3nte 2011-08-21 23:33:21 UTC
Created attachment 284187 [details]
mumble-1.2.2 with jack-useflag
Comment 5 Spencer 2014-04-25 05:38:14 UTC
Does this patch still apply to the current version(1.2.5)? When I add jack as a use flag and build mumble doesn't run.I tried manually updating the ebuild in a local overlay to add the attached patch and the emerge now fails compiling with output:

In file included from JackAudio.cpp:32:0:
JackAudio.h: At global scope:
JackAudio.h:60:17: error: 'QWaitCondition' does not name a type
compilation terminated due to -Wfatal-errors.
make[1]: *** [JackAudio.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-sound/mumble-1.2.5/work/mumble-1.2.5/src/mumble'
make: *** [sub-src-mumble-make_default-ordered] Error 2

I don't really know what I'm doing, so if there is a simple way to do this, or you can add the use flag option back in, I need jack support for mumble to be useful for my purposes. Thanks.
Comment 6 gerion 2015-11-26 00:52:16 UTC
Related: https://aur.archlinux.org/packages/mumble-jack/

This seems to be the actual version of mumble (yet based on the patch of FalkTX).

Also there is another mumble bug for this: http://sourceforge.net/p/mumble/feature-requests/749/
Comment 7 gerion 2015-11-26 01:35:22 UTC
Created attachment 417898 [details]
mumble-1.2.10-r2.ebuild

Mumble ebuild with Jack Patch.
Comment 8 gerion 2015-11-26 01:37:20 UTC
Created attachment 417900 [details, diff]
mumble-jack-support.patch

Slightly modified original patch. I added the line:
+#include <QWaitCondition>

(Don't know why the arch pkgbuild don't have to do this.)
Comment 9 Larry the Git Cow gentoo-dev 2018-08-21 19:26:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93953d4dab249dd0eb227deccb69016c27a46dd6

commit 93953d4dab249dd0eb227deccb69016c27a46dd6
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-08-21 19:26:16 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-08-21 19:26:16 +0000

    media-sound/mumble: Add USE jack
    
    Closes: https://bugs.gentoo.org/380161
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 media-sound/mumble/mumble-9999.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)