Bug 379849 – sys-process/numactl-2.0.7 : add USE=static-libs support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2011-08-19 10:14:11 UTC]

This package installs also static libs ".a" please provide to add relative
USE. TIA
From qlist -e $package:

/usr/lib64/libnuma.a
/usr/lib64/libnuma.so.1
/usr/lib64/libnuma.so

[Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) 2012-03-12 20:30:27 UTC]

Created attachment 305029 [details, diff]
Build static libs without -fPIC and only if BUILD_STATIC=yes

[Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) 2012-03-12 20:31:13 UTC]

Created attachment 305031 [details, diff]
diff against original ebuild

also fixes bug 406157

[Comment 3 SpanKY 2012-03-22 19:13:15 UTC]

Comment on attachment 305031 [details, diff]
diff against original ebuild

do not use pkg_setup to setup variables that actually belong in src_configure.  any ebuild doing that is wrong, and you shouldn't be copying it.

i've committed the getlibdir/EAPI updates.

[Comment 4 SpanKY 2012-03-22 19:14:18 UTC]

Comment on attachment 305029 [details, diff]
Build static libs without -fPIC and only if BUILD_STATIC=yes

".o_PIC" is an unusual suffix.  ".pic.o" is probably a bit more common.

static lib building should default to on, not off.

then this should be OK to send upstream.

[Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) 2012-03-22 19:56:32 UTC]

Created attachment 306357 [details, diff]
Build static libs without -fPIC and only if BUILD_STATIC=yes

(In reply to comment #4)
> Comment on attachment 305029 [details, diff] [details, diff]
> Build static libs without -fPIC and only if BUILD_STATIC=yes
> 
> ".o_PIC" is an unusual suffix.  ".pic.o" is probably a bit more common.
Done, it seems I was wrong wrt implicit rule. %.pic.o works fine
> static lib building should default to on, not off.
BUILD_STATIC ?= yes  should do the trick

[Comment 6 Kacper Kowalik (Xarthisius) (RETIRED) 2012-03-22 19:58:33 UTC]

Created attachment 306359 [details, diff]
diff against original ebuild

(In reply to comment #3)
> do not use pkg_setup to setup variables that actually belong in
> src_configure.  any ebuild doing that is wrong, and you shouldn't be copying
> it.
Passing BUILD_STATIC directly to make now.

[Comment 7 SpanKY 2012-03-22 20:47:42 UTC]

looks good ... feel free to commit

[Comment 8 Kacper Kowalik (Xarthisius) (RETIRED) 2012-03-22 21:50:42 UTC]

+*numactl-2.0.7-r2 (22 Mar 2012)
+
+  22 Mar 2012; Kacper Kowalik <[e-mail]>
+  +files/numactl-2.0.7-static_libs.patch, +numactl-2.0.7-r2.ebuild,
+  -numactl-2.0.7-r1.ebuild:
+  Build static library without -fPIC and make it optional wrt #379849 by
+  Agostino Sarubbo <[e-mail]>