Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 378829 - stabilize sys-fs/ntfs3g-2011.4.12
Summary: stabilize sys-fs/ntfs3g-2011.4.12
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: 384865
  Show dependency tree
 
Reported: 2011-08-11 20:24 UTC by Patrick McLean
Modified: 2011-12-29 20:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McLean gentoo-dev 2011-08-11 20:24:36 UTC
Has been in the tree for months, no reported problems.
Comment 1 Agostino Sarubbo gentoo-dev 2011-08-11 22:15:36 UTC
Please remove -ggdb3 from CFLAGS:
/bin/sh ../libtool --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc  -I../include/ntfs-3g -march=native -O2 -g0 -Wall -ggdb3 -DDEBUG  -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o ntfs-3g.probe ntfs_3g_probe-ntfs-3g.probe.o ../libntfs-3g/libntfs-3g.la

And please provide to a static-libs USE; from qlist $package

/usr/lib64/libntfs-3g.a
/usr/lib64/libntfs-3g.so
/usr/lib64/libntfs-3g.la

Please remove also .la file.
Comment 2 Patrick McLean gentoo-dev 2011-08-11 23:00:24 UTC
I removed the .la files and added a static-libs USE flag.

The -ggdb3 is only in the CFLAGS with USE=debug, it's enabled by the upstream configure script with --enable-debug. I would rather follow upstream on this then maintaining a local patch to remove this logic.
Comment 3 Agostino Sarubbo gentoo-dev 2011-08-11 23:04:59 UTC
(In reply to comment #2)
> I removed the .la files and added a static-libs USE flag.
> 
Good job ;)

> The -ggdb3 is only in the CFLAGS with USE=debug, it's enabled by the upstream
> configure script with --enable-debug. I would rather follow upstream on this
> then maintaining a local patch to remove this logic.

Anyway any useflags mustn't modify cflags environment.
Comment 4 Jeff (JD) Horelick (RETIRED) gentoo-dev 2011-08-12 00:33:32 UTC
@Agostino - With my limited ebuild knowledge, looking through it, the debug USE flag doesn't modify the CFLAGS, it seems the configure script modifies the CFLAGS which is perfectly normal. I'm not an official AT nor do i have any clue what i'm doing, but i'm going to consider this to not be an issue, personally at least.
Comment 5 Agostino Sarubbo gentoo-dev 2011-08-12 00:39:27 UTC
@JD

I meant that any USE, like also debug must not append -g/-ggdb via obvioulsy $(use_enable $USE) that modify configure script at configure time.
Comment 6 Jeff (JD) Horelick (RETIRED) gentoo-dev 2011-08-12 00:45:38 UTC
(In reply to comment #5)
> @JD
> 
> I meant that any USE, like also debug must not append -g/-ggdb via obvioulsy
> $(use_enable $USE) that modify configure script at configure time.

ah, gotcha. I'm still learning. sorry :)
Comment 7 Jeff (JD) Horelick (RETIRED) gentoo-dev 2011-08-12 00:57:55 UTC
Archtested on x86: Everything fine
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2011-08-14 14:55:51 UTC
amd64 done. Thank you all
Comment 9 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-08-21 03:37:21 UTC
x86 stable, thanks JD
Comment 10 nixnut (RETIRED) gentoo-dev 2011-08-21 13:37:06 UTC
ppc stable
Comment 11 Mark Loeser (RETIRED) gentoo-dev 2011-12-29 20:36:57 UTC
ppc64 done