Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352016 - x11-misc/driconf-0.9.1-r1: make the ebuild support multiple python versions
Summary: x11-misc/driconf-0.9.1-r1: make the ebuild support multiple python versions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 12:51 UTC by Rafał Mużyło
Modified: 2017-02-06 22:51 UTC (History)
0 users

See Also:
Package list:
=x11-misc/driconf-0.9.1-r2
Runtime testing required: No


Attachments
patch for multiple abis (driconf-multipython.patch,1.40 KB, patch)
2011-01-18 13:03 UTC, Rafał Mużyło
Details | Diff
gtk api patch (driconf-0.9.1-drop-old-tooltips.patch,2.90 KB, patch)
2011-01-18 13:05 UTC, Rafał Mużyło
Details | Diff
correct ebuild patch (driconf-multipython.patch,1.39 KB, patch)
2011-01-18 13:23 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2011-01-18 12:51:17 UTC
The changes required are mostly trivial.

But at the same time a minor request: as already driconf-0.9.1-update-toolbar-methods.patch is just doing porting to more recent gtk API, could the patch I'll attach, that's doing just that too also be included in the update ?
Comment 1 Rafał Mużyło 2011-01-18 13:03:04 UTC
Created attachment 260151 [details, diff]
patch for multiple abis

It's a bit messy IMHO, as it puts all the files into site-packages,
instead of i.e. site-packages/driconf, but that would require a more intrusive patch.
Comment 2 Rafał Mużyło 2011-01-18 13:05:42 UTC
Created attachment 260156 [details, diff]
gtk api patch

As I said, that's only api update (and gtk_widget_set_tooltip_text is not that recent by now), but as there's already one such patch, I hope this one will get accepted too.
Comment 3 Rafał Mużyło 2011-01-18 13:23:11 UTC
Created attachment 260159 [details, diff]
correct ebuild patch

Sorry, I've attached wrong version first - this is the working version.
Comment 4 Pacho Ramos gentoo-dev 2016-10-18 18:29:07 UTC
We would need to get this updated for new python eclasses :/
Comment 5 Harri Nieminen (Moiman) 2017-02-05 12:33:34 UTC
(In reply to Pacho Ramos from comment #4)
> We would need to get this updated for new python eclasses :/

I made new pull request to fix this: https://github.com/gentoo/gentoo/pull/3826
Comment 6 David Seifert gentoo-dev 2017-02-05 19:10:34 UTC
Arches, please stabilise

commit f162e6dab285aefc570d27f9b0f075065bc2309b
Author: Harri Nieminen <moikkis@gmail.com>
Date:   Sun Feb 5 13:41:59 2017 +0200

    x11-misc/driconf: Bump eapi, use newer python eclass, fix issues
    
    Fixes: https://bugs.gentoo.org/352016
    drop-old-tooltips patch is made by Rafał Mużyło, see bug #352016
    
    Also fixes following QA issuses:
    *  /usr/share/applications/driconf.desktop: error: value "GNOME;Application;Settings;AdvancedSettings;" for key "Categories" in group "Desktop Entry" contains an unregistered value "AdvancedSettings"; values extending the format should start with "X-"
    *  /usr/share/applications/driconf.desktop: warning: value "GNOME;Application;Settings;AdvancedSettings;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
Comment 7 Agostino Sarubbo gentoo-dev 2017-02-06 14:56:02 UTC
amd64 stable
Comment 8 Chí-Thanh Christopher Nguyễn gentoo-dev 2017-02-06 14:56:50 UTC
dropping arches per discussion on IRC
Comment 9 David Seifert gentoo-dev 2017-02-06 22:51:56 UTC
The code base of x11-misc/driconf-0.9.1 comes from the pre-py3 days and contains stuff like:

  print "Warning: could not find %s." % name

I don't see how you want this to work on a py3 impl? Harri Nieminen has helped modernise the ebuild to use the modern -r1 suite of python eclasses, but this won't help you getting it to work with py3.