Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 347638 - app-arch/gzip: add rsyncable patch
Summary: app-arch/gzip: add rsyncable patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High enhancement with 4 votes (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420813 439822
  Show dependency tree
 
Reported: 2010-12-03 10:11 UTC by Michael Wyraz
Modified: 2016-07-03 10:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Wyraz 2010-12-03 10:11:50 UTC
Please add the patch to gzip which can be found here: https://aur.archlinux.org/packages.php?ID=41802
It adds the "--rsyncable" option to gzip which greatly improve the possibility to create deltas of gzipped version of the same file which has small changes (usefull for rsync and for delta backups). It reduces the amount of data that needs to be transfered for things like gzipped sql dumps or log files.

I suggest to add a use flag "rsync-patch" or always-enable this patch (since it does not affect the packaging unless specified on command line).

After the patch is added, the maintainer of dpkg should be notified because afaik dpkg by default uses "--rsyncable" to improve handling of the packages via rsync.

Reproducible: Always
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2010-12-03 11:16:28 UTC
Why don't you contact upstream for that? It is not that sane to add such patch without letting upstream knows about them

and dpkg? really?
Comment 2 Michael Wyraz 2010-12-03 11:26:16 UTC
Sorry, i don't know about upstream and thought i can add feature requests here like I use to add bugs here.
The dkpg stuff had noting to do with my original intend but while searching for aboud this patch, I found the changelog: http://packages.gentoo.org/package/app-arch/dpkg
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2010-12-03 11:39:22 UTC
(In reply to comment #2)
> Sorry, i don't know about upstream and thought i can add feature requests here
> like I use to add bugs here.
> The dkpg stuff had noting to do with my original intend but while searching for
> aboud this patch, I found the changelog:
> http://packages.gentoo.org/package/app-arch/dpkg
> 

Yeah but it is not sane to apply patches and features without letting upstream know about them. Anyway. Better discuss this with the maintainer even though I am pretty sure they will point you to upstream too
Comment 4 Vincent de Phily 2012-06-12 10:40:25 UTC
I ran into this issue trying to use dpkg too. Until upstream adds the --rsyncable option, I suggest patching dpkg to not use the option instead of patching gzip to implement the option. See bug #420813 .
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2013-07-24 11:58:31 UTC
There are recent upstream thoughts on the subject:
http://lists.gnu.org/archive/html/bug-gzip/2013-06/msg00022.html

Basic suggestion is to use pigz.
Comment 6 Amadeusz Żołnowski (RETIRED) gentoo-dev 2014-11-01 21:20:45 UTC
What about patching conditionally depending on the USE flag?
Comment 7 SpanKY gentoo-dev 2016-02-29 20:51:26 UTC
the next release (1.7) will have support merged upstream, so we'll just wait for that