Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 420813 - app-arch/dpkg should not call gzip with the --rsyncable option
Summary: app-arch/dpkg should not call gzip with the --rsyncable option
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Debian-related package maintainers [DISBANDED]
URL:
Whiteboard:
Keywords: PATCH
Depends on: 347638
Blocks:
  Show dependency tree
 
Reported: 2012-06-12 10:34 UTC by Vincent de Phily
Modified: 2012-10-27 16:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
remove use of --rsyncable option (no_rsyncable.patch,431 bytes, patch)
2012-06-12 10:35 UTC, Vincent de Phily
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent de Phily 2012-06-12 10:34:00 UTC
Debian applies a patch that adds an "--rsyncable" option to gzip. This patch isn't upstream (as of gzip-1.4) and it is unclear when/if it'll be.

This option is just an optimisation, and as such it is not really needed (see http://beeznest.wordpress.com/2005/02/03/rsyncable-gzip/ or http://smackerelofopinion.blogspot.ie/2009/07/rsyncable-gzip.html).

So I suggest to patch the option out of dpkg (as opposed to patching the option into gzip, as asked by bug #347638). A one-liner patch to a rarely-used debian program is propably better than a complicated patch to a core gentoo package.

Reproducible: Always

Steps to Reproduce:
1. try to build a debian package using "dpkg-buildpackage -us -uc -d"

Actual Results:  
dpkg-source: info: building foobar in foobar_1.0-1.tar.gz
gzip: unrecognized option '--rsyncable'
Try `gzip --help' for more information.
dpkg-source: error: tar -cf - died from signal 13
dpkg-buildpackage: error: dpkg-source -b foobar-1.0 gave error exit status 29
make: *** [package_debian] Error 29

Expected Results:  
dpkg-source: info: building foobar in foobar_1.0-1.tar.gz
dpkg-source: info: building foobar in foobar_1.0-1.dsc
(...)
Comment 1 Vincent de Phily 2012-06-12 10:35:52 UTC
Created attachment 315087 [details, diff]
remove use of --rsyncable option
Comment 2 Michael Weber (RETIRED) gentoo-dev 2012-06-12 12:56:01 UTC
Which version of app-arch/dpkg does this affect?

@base-system: What are your plans on bug 347638?
Comment 3 SpanKY gentoo-dev 2012-06-12 13:19:16 UTC
i have no plans on re-adding the patch currently.  almost no one has requested it, and it's been over 5 years since Gentoo supported it ...
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-06-12 15:37:57 UTC
Fixed in 1.16.4.2-r1.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2012-06-12 15:45:18 UTC
It's been present for a good while, so applying the patch now to 1.16.2 isn't going to achieve much.

commit eadd7d2376ef54b30cce26b336092c85ca406b3b
Author: Raphaël Hertzog <hertzog@debian.org>
Date:   Sun Jul 25 17:12:50 2010 +0200

    Dpkg::Compression: add --no-name and --rsyncable options to the gzip call
    
    Pass --no-name option to gzip to avoid encoding the timestamp in the file
    so that the result is more predictable. Also pass --rsyncable to make
    source packages more rsync friendly.