Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 338027 - games-fps/prboom+ - PrBoom+ is a Doom source port developed from the original PrBoom project by Andrey Budko
Summary: games-fps/prboom+ - PrBoom+ is a Doom source port developed from the original...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Default Assignee for New Packages
URL: http://prboom-plus.sourceforge.net/
Whiteboard:
Keywords: PullRequest
: 650402 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-19 11:08 UTC by Alexander Korshun
Modified: 2019-06-24 20:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
My ebuild. It has problems. (prboom-plus-2.5.0.7.ebuild,2.20 KB, text/plain)
2010-09-19 11:10 UTC, Alexander Korshun
Details
prboom-plus-2.5.1.3.ebuild (prboom-plus-2.5.1.3.ebuild,2.33 KB, text/plain)
2012-07-07 20:50 UTC, Patrick McMunn
Details
metadata.xml to supply use flag descriptions (metadata.xml,1016 bytes, text/plain)
2012-07-07 20:56 UTC, Patrick McMunn
Details
prboom-plus-2.5.1.4.ebuild (prboom-plus-2.5.1.4.ebuild,2.32 KB, text/plain)
2018-03-17 17:04 UTC, Andrey Aleksandrovich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Korshun 2010-09-19 11:08:41 UTC
PrBoom+ is an improved version of PrBoom doom port. I want to use it instead of PrBoom so I wrote a ebuild based on PrBoom ebuild and used it locally. 

Notes: 
1. It blocks games-fps/prboom for the same reason PrBoom blocks games-fps/lsdldoom. It blocks lsdldoom too.
2. Original ebuild had no RDEPEND="${DEPEND}" and said about Final Doom where it should have been Ultimate Doom. Fixed in my ebuild.

Problems with my ebuild:
1. DESCRIPTION is copied from PrBoom ebuild. I don't know what to put there.
2. It uses prboom.png for desktop icon.
3. Maybe 2.5.0.7 is too new and unstable and you'll want to add 2.5.0.6 instead.
4. KEYWORDS="~amd64"

Feel free to do anything with my ebuild and/or write your own. Just please add PrBoom+ ebuild somewhere because PrBoom+ is really better than PrBoom.

Reproducible: Always
Comment 1 Alexander Korshun 2010-09-19 11:10:51 UTC
Created attachment 247985 [details]
My ebuild. It has problems.

Do not add it as-is. It has problems I described already.
Comment 2 Patrick McMunn 2012-07-07 20:50:43 UTC
Created attachment 317534 [details]
prboom-plus-2.5.1.3.ebuild

1. I updated the ebuild to the latest version, 2.5.1.3.
2. I added several use flags in order to make the compilation much more configurable.
3. I changed the description to match the one from the PrBoom+ home page on Sourceforge.
4. I added ~x86 keyword as I have tested it on my 32-bit system.
5. I removed all blockers. I referenced https://bugs.gentoo.org/show_bug.cgi?id=159087 to find out why a blocker was in place in the first place. In short, the issue no longer exists. I have lsdldoom, prboom, and prboom-plus installed simultaneously; I had no file collision issues.
6. Ebuild still uses the original prboom icon because prboom-plus does not supply one of it's own. However, I rename the icon before installation in order to avoid a file collision with prboom.
7. I removed the nvidia bug detection. I have no way of knowing if the bug even exists in the prboom-plus code, and even if it did the patch would not apply to the prboom-plus source code.
8. I also removed the libpng patch. Tested with libpng-1.5.11, the source builds fine with no patches.
9. I removed a couple of sed functions which alter the Makefile and changed the src_install procedure so they're now unnecessary.

Please note that I have not tested all possible use flag combinations, so I suppose it's possible that some use flag combinations may not work.
Comment 3 Patrick McMunn 2012-07-07 20:56:24 UTC
Created attachment 317536 [details]
metadata.xml to supply use flag descriptions

By the way, I am adding the ebuild to paddymac overlay until such time as it makes it into portage.
Comment 4 Julian Ospald 2013-03-09 22:44:19 UTC
(In reply to comment #3)
> Created attachment 317536 [details]
> metadata.xml to supply use flag descriptions
> 
> By the way, I am adding the ebuild to paddymac overlay until such time as it
> makes it into portage.

contribute to sunrise instead, there is an experimental github overlay that is synced with sunrise beta
https://github.com/hasufell/sunrise

you can send pull requests there
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2018-03-17 12:36:26 UTC
*** Bug 650402 has been marked as a duplicate of this bug. ***
Comment 6 Andrey Aleksandrovich 2018-03-17 17:04:18 UTC
Created attachment 524198 [details]
prboom-plus-2.5.1.4.ebuild
Comment 7 Andreas Sturmlechner gentoo-dev 2019-06-10 12:12:15 UTC
(In reply to Andrey Aleksandrovich from comment #6)
> Created attachment 524198 [details]
> prboom-plus-2.5.1.4.ebuild

Thanks for your work, to have hopes for ebuild repo it would need to be ported away from games.eclass and be at EAPI-7.
Comment 8 Larry the Git Cow gentoo-dev 2019-06-24 20:06:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54d69b5150e342464abbf45d4699877b32a2efc2

commit 54d69b5150e342464abbf45d4699877b32a2efc2
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2019-06-20 07:30:38 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-06-24 19:57:41 +0000

    games-fps/prboom-plus: Introduce version 2.5.1.4
    
    Closes: https://bugs.gentoo.org/338027
    Package-Manager: Portage-2.3.67, Repoman-2.3.15
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/12297
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-fps/prboom-plus/Manifest                     |  1 +
 ....1.4-Remove-nonstandard-gamesdir-variable.patch | 33 +++++++++++
 games-fps/prboom-plus/metadata.xml                 | 33 +++++++++++
 games-fps/prboom-plus/prboom-plus-2.5.1.4.ebuild   | 68 ++++++++++++++++++++++
 4 files changed, 135 insertions(+)