Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333161 - [PATCH] Make media-libs/plib build shared libs
Summary: [PATCH] Make media-libs/plib build shared libs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL: http://sourceforge.net/support/tracke...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 14:29 UTC by Maciej Mrozowski
Modified: 2021-01-25 21:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to build shared libs (plib-1.8.5-shared-libs.patch,9.30 KB, patch)
2010-08-17 14:30 UTC, Maciej Mrozowski
Details | Diff
plib-1.8.5 ebuild patch (plib.diff,1.37 KB, patch)
2010-08-17 14:32 UTC, Maciej Mrozowski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Mrozowski gentoo-dev 2010-08-17 14:29:13 UTC
Currently media-libs/plib builds only static libs which makes it impossible to track ABI changes.
Comment 1 Maciej Mrozowski gentoo-dev 2010-08-17 14:30:17 UTC
Created attachment 243333 [details, diff]
patch to build shared libs
Comment 2 Maciej Mrozowski gentoo-dev 2010-08-17 14:32:07 UTC
Created attachment 243335 [details, diff]
plib-1.8.5 ebuild patch

Some suggested ebuild improvements.
Comment 3 SpanKY gentoo-dev 2010-08-17 14:37:09 UTC
we shouldnt start generating shared libs until upstream starts doing it too

if anything, moving from static to shared makes ABI management a lot harder.  static libs match the exact API installed with the static libs.
Comment 4 Maciej Mrozowski gentoo-dev 2010-08-17 15:09:49 UTC
Just FYI, patch was created by simple script http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=blob;f=Documentation/maintainers/autotools_force_shared_libs;hb=HEAD with some a manual effort to add missing link deps (based on equivalent Debian patch).

If not for shared libs, please add pkg_postinst message warning that all packages depending on plib may need rebuilding (which applies to pretty much everything providing only static libs).
Comment 5 Larry the Git Cow gentoo-dev 2021-01-25 21:33:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f87f7789bc98b1f0b1c035a274083d88cb2739de

commit f87f7789bc98b1f0b1c035a274083d88cb2739de
Author:     Maciej Mrozowski <reavertm@gentoo.org>
AuthorDate: 2021-01-25 21:32:02 +0000
Commit:     Maciej Mrozowski <reavertm@gentoo.org>
CommitDate: 2021-01-25 21:32:21 +0000

    media-libs/plib: provide shared libs
    
    Closes: https://bugs.gentoo.org/333161
    Bug: https://bugs.gentoo.org/745486
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Maciej Mrozowski <reavertm@gentoo.org>

 media-libs/plib/files/plib-1.8.5-shared-libs.patch | 256 +++++++++++++++++++++
 media-libs/plib/plib-1.8.5-r3.ebuild               |  43 ++++
 2 files changed, 299 insertions(+)