(incidentally, looks like this is an odd \n placed in the error message) * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * python-wrapper.c:59: warning: implicit declaration of function 'strtok_r' * * QA Notice: Package has poor programming practices which may compile * but will almost certainly crash on 64bit architectures. * * Function `strtok_r' implicitly converted to pointer at python-wrapper.c:59 * * Please file a bug about this at http://bugs.gentoo.org/ * with the maintaining herd of the package. * * ERROR: app-admin/eselect-python-20090824-r00.1 failed: * install aborted due to poor programming practices shown above * * Call stack: * misc-functions.sh, line 1435: Called install_qa_check * misc-functions.sh, line 91: Called install_qa_check_misc * misc-functions.sh, line 523: Called die * The specific snippet of code: * die "install aborted due to" \
Created attachment 214788 [details] build.log
14:16 <@darkside_> Arfrever: yo, can you look at a bug for me? 14:16 <@Arfrever> Which bug? 14:17 <@darkside_> bug 299152 14:17 <+Willikins> darkside_: https://bugs.gentoo.org/299152 "app-admin/eselect-python-20090824-r00.1 fails to build on hpux ia64"; Gentoo/Alt, Prefix Support; NEW; darkside@g.o:prefix@g.o 14:17 <@Arfrever> darkside_: eselect-python-20091230 was released. 14:18 <@darkside_> ok, does it fix that error noted in the build.log? Function `strtok_r' implicitly converted to pointer at python-wrapper.c:59 14:27 <@Arfrever> darkside_: No. strtok_r is documented in http://www.opengroup.org/onlinepubs/9699919799/functions/strtok.html 14:30 * Blackb|rd recommends reading the "CONFORMING TO" section of the stpcpy manpage 14:32 <@darkside_> indeed. 14:42 <@darkside_> Arfrever: so, can you fix it? 14:43 <@Arfrever> darkside_: If somebody creates a patch, then I could review it. 14:44 <@darkside_> great, another blocker due to eselect-python. cool. 14:45 <@darkside_> please don't write code that is needed at the system level that doesn't work on all archs 14:46 <@Arfrever> darkside_: It's rather a bug in hpux's libc. I'm not qualified to help any further.
Created attachment 214791 [details] info.txt
Created attachment 214796 [details, diff] Patch to use strtok when strtok_r is unavalilable
(In reply to comment #4) > Created an attachment (id=214796) [details] > Patch to use strtok when strtok_r is unavalilable > Thanks for the patch, I have a feeling it will work but it doesn't apply to 200908* and to bump it requires significant work that I don't have time for *right* now.
Is there any reason to use strtok_r() at all? There is nothing multi-threadingish going on in this wrapper (I hope), right?
I've fixed this in 20091230-r00.1 with the plain-c patch.
I'm planning to apply a patch based on patch from comment #4. Nothing has been changed yet in eselect-python trunk, so this bug shouldn't be closed.
Rediculous. But fine, do as you think is useful, it'll undoubtedly break again in some other way.
Fixed in r315.
Fixed in app-admin/eselect-python-20100321.
