Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299117 - app-cdr/brasero-2.28.xx not require sys-apps/hal
Summary: app-cdr/brasero-2.28.xx not require sys-apps/hal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 13:56 UTC by INODE64 Sistemas
Modified: 2010-01-04 00:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix deps (brasero-2.28.3.ebuild.patch,527 bytes, patch)
2010-01-03 23:40 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description INODE64 Sistemas 2009-12-31 13:56:08 UTC
I search in sources libhal.h it not exist and remove hal and revdep-rebuild not found break files

Reproducible: Always
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-12-31 14:00:17 UTC
That's why it's a runtime depend, not a build-time depend, it's used to detect the drive, same as in k3b...
Comment 2 INODE64 Sistemas 2009-12-31 14:10:26 UTC
udev detect changes too
I remove sys/hal from my gentoo and brasero run OK
Comment 3 Peter Sääf 2009-12-31 14:18:51 UTC
Actually, it seems devicekit-disks/gio is used for this since some time. [1]
Reporter is correct.

[1]
http://git.gnome.org/browse/brasero/commit/?id=02d31a74b6d92d1fa8548775e8792a4f23efd9e2
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-01-03 23:18:31 UTC
Indeed. The sync of dependency fixes from gnome overlay fixed this problem. Thanks for reporting.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2010-01-03 23:20:10 UTC
(In reply to comment #4)
> Indeed. The sync of dependency fixes from gnome overlay fixed this problem.
> Thanks for reporting.
> 

The sync introduced the gvfs depend back, looks bogus
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-01-03 23:37:51 UTC
The commit also introduced gtk-doc under doc? ( ) and is missing it from IUSE... Reopening before of that, and the bogus gvfs depend.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-01-03 23:40:31 UTC
Created attachment 215102 [details, diff]
Fix deps

No need to rebuild already built documentation.
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-01-03 23:46:22 UTC
> The commit also introduced gtk-doc under doc? ( ) and is missing it from
> IUSE... Reopening before of that, and the bogus gvfs depend.

thanks for spotting this.

About gvfs, it is needed for mounting/unmounting & co. It's just a runtime dep.
Comment 9 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-01-03 23:47:15 UTC
(In reply to comment #7)
> No need to rebuild already built documentation.
> 

we do this for consistence, real fix will come with bug #262491.
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2010-01-03 23:49:00 UTC
(In reply to comment #8)
> > The commit also introduced gtk-doc under doc? ( ) and is missing it from
> > IUSE... Reopening before of that, and the bogus gvfs depend.
> 
> thanks for spotting this.

There's no --enable/--disable $(use_enable ) to control the USE doc, so it's still wrong.

> 
> About gvfs, it is needed for mounting/unmounting & co. It's just a runtime dep.
> 

I'm pretty sure I checked the sources and couldn't find anything related to gvfs there... Except commented out code.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2010-01-03 23:50:46 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > > The commit also introduced gtk-doc under doc? ( ) and is missing it from
> > > IUSE... Reopening before of that, and the bogus gvfs depend.
> > 
> > thanks for spotting this.
> 
> There's no --enable/--disable $(use_enable ) to control the USE doc, so it's
> still wrong.

Oops, I forgot that gnome2.eclass does that. Still, the ebuild should have it's own, eclass is no place for it.