Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 28746 - xmms-1.2.8-dtd.patch makes xmms-cdread-0.14a finding undefined symbol: playlist_generate_shuffle_list
Summary: xmms-1.2.8-dtd.patch makes xmms-cdread-0.14a finding undefined symbol: playli...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
: 30669 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-09-14 18:07 UTC by CBke -Left- bye
Modified: 2003-10-08 09:44 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description CBke -Left- bye 2003-09-14 18:07:31 UTC
emerging xmms 1.2.8 and then xmms-cdread-0.14 makes xmms report:

/usr/lib/xmms/Input/libcdread.so: undefined symbol: 
playlist_generate_shuffle_list

re-emerging doesn't fix it

Reproducible: Always
Steps to Reproduce:
1.emerge xmms
2.emerge xmms-cdread
3.start xmms and have a look at his output




$ emerge  info
Portage 2.0.49-r4 (mydefault-x86-1.4, gcc-3.3.1, glibc-2.3.2-r1, 2.6.0-test5)
=================================================================
System uname: 2.6.0-test5 i686 AMD Athlon(tm) processor
ccache version 2.2 [enabled]
ACCEPT_KEYWORDS="~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-tbird -O2 -mmmx -m3dnow -fomit-frame-pointer -
mfpmath=387 -funroll-loops"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config /usr/kde/2/share/conf
ig /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=athlon-tbird -O2 -mmmx -m3dnow -fomit-frame-pointer -
mfpmath=387 -funroll-loops"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs sandbox ccache prelink autocvs"
GENTOO_MIRRORS=" http://ftp.gentoo.skynet.be/pub/gentoo/ 
http://ftp.easynet.nl/mirror/gentoo/ http://ftp.
belnet.be/mirror/rsync.gentoo.org/gentoo/ 
http://ftp.snt.utwente.nl/pub/os/linux/gentoo http://linux.rz.r
uhr-uni-bochum.de/download/gentoo-mirror/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow dnow fbcon fbdev gtk2 php skey sse type1 xml xosd -apm --arts --
berkdb -foomaticdb --kde --gnome -gtk"
Comment 1 SpanKY gentoo-dev 2003-09-14 18:14:15 UTC
how do you know it's related to the dtd patch ?

have you tried emerging xmms-1.2.8-r1 w/out the dtd patch ?
Comment 2 Seemant Kulleen (RETIRED) gentoo-dev 2003-09-14 20:45:05 UTC
I know for sure that it's not the dtd patch. I haven't narrowed down exactly what it is yet, though.
Comment 3 J. Ellis (RETIRED) gentoo-dev 2003-09-20 02:15:22 UTC
From the xmms changelog:

        * xmms/playlist.c, xmms/controlsocket.c, xmms/main.c, xmms/util.c:
        Every function that modifies the playlist directly calls
        playlist_generate_shuffle_list().  Removed calls to this function
        from other files.

and note that in playlist.c:

static void playlist_generate_shuffle_list(void);

that's not going to get exported (it's static). In 1.2.7, this was a public symbol, and consequently could be used by cdread:

void playlist_generate_shuffle_list(void)
                playlist_generate_shuffle_list();
./xmms/playlist.c
void playlist_generate_shuffle_list(void);
./xmms/playlist.h

I'll take a look and see if there is another function that cdread can call instad. Otherwise it's probably safe to say that cdread won't work with xmms 1.2.8 until a new version is released.
Comment 4 J. Ellis (RETIRED) gentoo-dev 2003-09-20 02:56:18 UTC
It's a bit of a hack but calling playlist_set_shuffle() instead causes the 
playlist to get re-shuffled. It's a really simple patch. I'll give it somemore 
testing and then put back an r1 of xmms-cdread.
Comment 5 J. Ellis (RETIRED) gentoo-dev 2003-09-20 03:10:18 UTC
Commited as -r1, ~x86 masked. Let me know if there are any issues.

Thanks.
Comment 6 Bartosch Pixa (RETIRED) gentoo-dev 2003-09-20 17:53:29 UTC
i've just got one question, what's the point in using cdread with xmms 1.2.8 ?
as the rewrote cdda plugin in xmms now supports digital extraction too and also supports multiple devices.
imo the xmms-cdread ebuild should just be changed to block on xmms >=1.2.8
i know that sounds a bit harsh, it's just the way i see it
Comment 7 J. Ellis (RETIRED) gentoo-dev 2003-09-20 18:18:04 UTC
Good point. I just fixed it because it was fixable and seemant asked me to look at it. It's probably not broken for 1.2.7.

Still, if 1.2.8 has the same functionality then perhaps we should do as you suggest. I certainly don't want to end up maintaining the patch. As seemant is more involved w/xmms these days i'll leave the decision up to him.
Comment 8 SpanKY gentoo-dev 2003-10-08 09:43:46 UTC
*** Bug 30669 has been marked as a duplicate of this bug. ***
Comment 9 SpanKY gentoo-dev 2003-10-08 09:44:02 UTC
*** Bug 30670 has been marked as a duplicate of this bug. ***