265476 – app-vim/gentoo-syntax-20090220 drops highlight in global scope comments

Bug 265476 - app-vim/gentoo-syntax-20090220 drops highlight in global scope comments

Summary: app-vim/gentoo-syntax-20090220 drops highlight in global scope comments

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Jeremy Olexa (darkside) (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-04-08 18:57 UTC by Mounir Lamouri (volkmar) (RETIRED)
Modified:	2009-07-20 02:47 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
fixing patch (ebuild.vim-bug265476.patch,948 bytes, patch) 2009-07-07 11:30 UTC, Mounir Lamouri (volkmar) (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-04-08 18:57:06 UTC

After updating gentoo-syntax-20070506 to gentoo-syntax-20090220, all my highlights in global scope comments went out like the useful TODO: or bug <id>.

I tried to look at the diff between the two tarballs but I didn't see anything relevant.

Comment 1 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-04-08 19:03:06 UTC

gentoo-syntax-20081006 has this bug too

Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester

2009-04-09 15:16:30 UTC

I confirm this issue, but maybe bug 265560 is related and the root cause of this bug?

Comment 3 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-04-09 21:26:28 UTC

(In reply to comment #2)
> I confirm this issue, but maybe bug 265560 is related and the root cause of
> this bug?
> 
I don't think so. I'm using vim-7.2 (not 7.2.108) and I've tested the three versions of gentoo-syntax with the same vim version.

Comment 4 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-05-22 21:22:25 UTC

Interesting thing: I realized highlighting was working if i add a tab before the #.
Like
<tab># TODO: foo

Hope it could help...

Comment 5 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-07-07 11:28:53 UTC

Got it !

It comes from:
" Eclass documentation
syn match EclassDocumentation /@\(BLURB\|CODE\|DESCRIPTION\|ECLASS-VARIABLE\|ECLASS\|EXAMPLE\|FUNCTION\|MAINTAINER\|RETURN\|USAGE\|VARIABLE\):/ contained
syn match EclassComment /^#.*$/ contains=EclassDocumentation"
in ebuild.vim

As eclass comments are ot top of eclasses, when I add # TODO: at top of ebuild, syntax interprets it as eclass comments.

But TODO highlights come with shComment so I've changed the syntax file to highlight EclassDocumentation in shComment instead of create EclassComment.

Comment 6 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev

2009-07-07 11:30:13 UTC

Created attachment 197039 [details, diff]
fixing patch

hope it's going to be ok, that's the first time i had to look at a syntax file

Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester

2009-07-20 02:32:49 UTC

%% svn ci -m "Fix commenting scope issues, bug 265476. patch by Mounir Lamouri"
Sending        syntax/ebuild.vim
Transmitting file data .
Committed revision 63.

Comment 8 Jeremy Olexa (darkside) (RETIRED) archtester

2009-07-20 02:47:56 UTC

released in gentoo-syntax-20090720.ebuild, thx for the patch - sorry for the wait.