Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 247500 - dev-util/quilt Emacs support
Summary: dev-util/quilt Emacs support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 247666
Blocks:
  Show dependency tree
 
Reported: 2008-11-18 20:58 UTC by Ulrich Müller
Modified: 2024-12-06 04:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed change for quilt-0.47.ebuild (quilt-0.47.ebuild.diff,524 bytes, patch)
2008-11-20 07:11 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2008-11-18 20:58:43 UTC
It's a strange coincidence: Today I have finally moved app-emacs/quilt-el from the Emacs overlay (where it was sitting for one year) to the main tree. And a few hours later I notice that dev-util/quilt was bumped to 0.47 which now also installs the Emacs mode (0.46 didn't include it).

Any suggestions what to do? There are two options:
1. Keep app-emacs/quilt-el, and remove Emacs support from dev-util/quilt.
2. Add an Emacs USE flag to dev-util/quilt, byte-compile the Emacs mode, and
   install a site-init file for Emacs. And delete app-emacs/quilt-el again.
Comment 1 Ulrich Müller gentoo-dev 2008-11-18 21:51:00 UTC
Addendum: The Emacs mode has its own upstream, and the version of quilt.el bundled with dev-util/quilt-0.47 is (slightly) out-of-date.
Comment 2 Ulrich Müller gentoo-dev 2008-11-20 07:11:40 UTC
Created attachment 172440 [details, diff]
Proposed change for quilt-0.47.ebuild

From our IRC discussion I conclude that we should keep app-emacs/quilt-el. Then dev-util/quilt shouldn't install the Emacs mode, see attached patch.

<mpagano_> ulm: i'm leaning towards local emacs use flag for quilt and then rdepend on quilt-el
<mpagano_> ulm: thoughts?

Good idea. Probably PDEPEND, because quilt-el itself RDEPENDs on quilt. And app-emacs/quilt-el will need some keywords; I'll open a bug for keywording.
Comment 3 Ulrich Müller gentoo-dev 2009-01-10 16:16:57 UTC
quilt-el has all necessary keywords, so I've added IUSE=emacs and PDEPEND=quilt-el to quilt-0.47-r1.
Comment 4 Larry the Git Cow gentoo-dev 2024-09-17 13:33:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a2984645dbb71ab7057c5c0930fab972e2cfccf5

commit a2984645dbb71ab7057c5c0930fab972e2cfccf5
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-09-17 11:55:16 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-09-17 13:33:00 +0000

    dev-util/quilt: Install the Emacs mode
    
    A separate package for app-emacs/quilt-el made sense in the past when
    it had its own upstream. This is no longer the case; nowadays the Gentoo
    packages are built from the same tarball.
    
    Bug: https://bugs.gentoo.org/247500
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 dev-util/quilt/files/50quilt-gentoo.el             |  7 ++
 .../files/quilt-el-0.45.4-header-window.patch      | 13 ++++
 dev-util/quilt/quilt-0.68-r1.ebuild                | 76 ++++++++++++++++++++++
 3 files changed, 96 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2024-10-15 05:27:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=507be1611c3b951faad528a0679ec680b5e7c55a

commit 507be1611c3b951faad528a0679ec680b5e7c55a
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-10-15 05:19:55 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-10-15 05:26:52 +0000

    profiles: Mask app-emacs/quilt-el for removal
    
    Bug: https://bugs.gentoo.org/247500
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2024-12-06 04:40:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=842e86174499193fead59ceff5bdccde9e0841dc

commit 842e86174499193fead59ceff5bdccde9e0841dc
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-12-06 04:34:41 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-12-06 04:36:43 +0000

    app-emacs/quilt-el: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/247500
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-emacs/quilt-el/Manifest                        |  1 -
 app-emacs/quilt-el/files/50quilt-el-gentoo.el      |  7 -------
 .../files/quilt-el-0.45.4-header-window.patch      | 10 ----------
 app-emacs/quilt-el/metadata.xml                    | 20 -------------------
 app-emacs/quilt-el/quilt-el-0.66.ebuild            | 23 ----------------------
 profiles/package.mask                              |  6 ------
 6 files changed, 67 deletions(-)