Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 234629 - media-video/mplayer-1.0_rc2_p27458 dropped arch keywords need use.masks added
Summary: media-video/mplayer-1.0_rc2_p27458 dropped arch keywords need use.masks added
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-13 14:23 UTC by Steve Dibb (RETIRED)
Modified: 2023-02-26 23:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Dibb (RETIRED) gentoo-dev 2008-08-13 14:23:15 UTC
Arches,

Each profile needs entries added to package.use.mask for media-video/mplayer plus the specific use flags, since the arch checks have been properly removed from the ebuild.

All: win32codecs, real, custom-cpuopts

alpha, x86-fbsd, hppa, ia64, ppc64, sparc: cpudetection, dxr2, dxr3
Comment 1 Raúl Porcel (RETIRED) gentoo-dev 2008-08-14 10:42:51 UTC
Hrm? I don't see the arch checks of real and win32codecs removed.
Anyway, realplayer is a binary for x86 only, and win32codecs is for alpha/amd64/ppc/x86 only, am i wrong?

As for custom-cpuopts and cpudetection, i'd say thats okay for all the arches. About dxr2 and dxr3, those are for special graphics card, right? Doubt those are available for other than amd64/ppc/x86 as well. At least the alpha/ia64/sparc teams don't have the hardware to test.
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2008-08-14 13:28:54 UTC
(In reply to comment #1)
> Hrm? I don't see the arch checks of real and win32codecs removed.
> Anyway, realplayer is a binary for x86 only, and win32codecs is for
> alpha/amd64/ppc/x86 only, am i wrong?

They weren't in the use flags check, they were below in if statements.  Just run a diff to previous version and you'll see the changes.  win32codecs and 32bit binary support is for x86/amd64 only

> As for custom-cpuopts and cpudetection, i'd say thats okay for all the arches.

custom-cpuopts only works for x86/amd64 CPU flag checks

You can test cpudetection and mask it if it doesn't work.
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2008-08-14 15:25:11 UTC
Error: Runtime CPU detection only works for x86, x86-64 and PPC!

So, as we have talked, win32codecs, real, custom-cpuopts and cpudetection should be masked in the base profiles(base and embedded) and unmasked in those arches that can run it.
Comment 4 Alexis Ballier gentoo-dev 2008-08-16 19:11:44 UTC
For bsd:

cpudetection is fine
dxr3 already masked

dxr2: what's this ??? it needs dxr2ioctl.h which I've found there: http://dxr2.sourceforge.net/projects/dxr2-driver/source/dxr2-driver-1.0.4.tar.gz
We used to have it, but see bug #153365
It fails on linux too. Please nuke that useflag.

custom-cpuopts: seems fine

win32codecs: was already unmasked here
but I see this in the ebuild:
    if ! use bindist && ! use real; then
        myconf="${myconf} $(use_enable win32codecs win32dll)"
    fi
wouldn't that disable win32codecs support at all (and thus real) for x86 users if use=win32codecs real is specified ?

real: there is that in the ebuild:
    # Real codec support, only available on x86, amd64
    if use real && use x86; then
        myconf="${myconf} --realcodecsdir=/opt/RealPlayer/codecs"
    elif use real && use amd64; then
        myconf="${myconf} --realcodecsdir=/usr/$(get_libdir)/codecs"
    else
        myconf="${myconf} --disable-real"
    fi

which afaik wouldn't change anything if the real useflag is on or off unless we are on x86 or amd64


for the real + win32codecs stuff also there is:
        x86? (
            win32codecs? ( media-libs/win32codecs )
            real? ( media-libs/win32codecs
                media-video/realplayer )
            )
        amd64? ( real? ( media-libs/amd64codecs ) )

in the deps, which doesn't really make sense if you want the useflag use.masked instead of having arch dependant code.
Comment 5 Alexis Ballier gentoo-dev 2008-08-17 17:34:17 UTC
As per bug #234775 we can add dirac and schroedinger useflags to the list for some of you:
media-video/dirac
media-libs/schroedinger


Samples:
http://samples.mplayerhq.hu/V-codecs/Dirac/

This version does not seem to have dirac in ts support, so the samples from
http://dirac.kw.bbc.co.uk/download/video/notfinal/ would not work.


You can force the decoder:
mplayer -vc fflibdirac foo.avi
mplayer -vc fflibschroedinger foo.avi

Or you can encode some videos:
mencoder foo.avi -o bar.avi -oac mp3lame -ovc lavc -lavcopts vcodec=vorbis:vcodec=libschroedinger

replace libschroedinger by libdirac for dirac.

libschroedinger is much faster but I tend to prefer the quality when encoded with libdirac.
Comment 6 Alexis Ballier gentoo-dev 2008-08-17 17:40:07 UTC
(In reply to comment #5)
> Or you can encode some videos:
> mencoder foo.avi -o bar.avi -oac mp3lame -ovc lavc -lavcopts
> vcodec=vorbis:vcodec=libschroedinger

hmm copy/paste error, this should be read as:
mencoder foo.avi -o bar.avi -oac mp3lame -ovc lavc -lavcopts vcodec=libschroedinger
Comment 7 Markus Rothe (RETIRED) gentoo-dev 2008-08-24 15:20:07 UTC
masked dxr2, dxr3, cpudetection, custom-cpuopts in ppc64 profiles and added ~ppc64 back to latest ebuild.
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2008-09-16 14:09:26 UTC
Marked ~hppa again. I don't agree with the mass masking that was needed, but apparently even good ideas travel only so far.
Comment 9 Steve Dibb (RETIRED) gentoo-dev 2008-09-30 00:57:48 UTC
(In reply to comment #3)
> Error: Runtime CPU detection only works for x86, x86-64 and PPC!
> 
> So, as we have talked, win32codecs, real, custom-cpuopts and cpudetection
> should be masked in the base profiles(base and embedded) and unmasked in those
> arches that can run it.
> 

Done.

And simpler, sorry for the confusion guys.
Comment 10 Larry the Git Cow gentoo-dev 2023-02-26 19:24:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=935f64c522978b3f18349c06dac9aac54cb0ba7b

commit 935f64c522978b3f18349c06dac9aac54cb0ba7b
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-26 19:23:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-26 19:24:13 +0000

    profiles/arch/powerpc/ppc64: shift cpudetection mask into p.use.mask
    
    Otherwise, this affects gmp[cpudetection]. This seems to be because
    the mask predated package.use.mask support...?
    
    Bug: https://bugs.gentoo.org/234629
    Bug: https://bugs.gentoo.org/894134
    Thanks-to: Ian Jordan <immoloism@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/powerpc/ppc64/package.use.mask | 3 +++
 profiles/arch/powerpc/ppc64/use.mask         | 5 +----
 2 files changed, 4 insertions(+), 4 deletions(-)