Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226367 - let net-www/mplayerplug-in-3.50 be compiled against xulrunner-1.9
Summary: let net-www/mplayerplug-in-3.50 be compiled against xulrunner-1.9
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Joe Jezak (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-13 14:24 UTC by Andrzej Rybczak
Modified: 2008-09-21 20:59 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix compilation against xulrunner-1.9* (mplayerplug-in-against-xulrunner-1.9.patch,2.95 KB, patch)
2008-06-13 14:25 UTC, Andrzej Rybczak
Details | Diff
mplayerplug-in-3.50.ebuild diff (ebuild.diff,987 bytes, patch)
2008-06-13 14:26 UTC, Andrzej Rybczak
Details | Diff
ebuild to build against firefox 3 (mplayerplug-in-3.50.ebuild,4.03 KB, text/plain)
2008-06-18 21:05 UTC, Billy DeVincentis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Rybczak 2008-06-13 14:24:12 UTC
net-www/mplayerplug-in-3.50 can be compiled against xulrunner-1.9 with my patch.

Reproducible: Always

Steps to Reproduce:
1. apply ebuild.diff to mplayerplug-in-3.50.ebuild
2. put my patch into files directory
3. emerge mplayerplug-in
Comment 1 Andrzej Rybczak 2008-06-13 14:25:29 UTC
Created attachment 156633 [details, diff]
fix compilation against xulrunner-1.9*
Comment 2 Andrzej Rybczak 2008-06-13 14:26:14 UTC
Created attachment 156635 [details, diff]
mplayerplug-in-3.50.ebuild diff
Comment 3 Billy DeVincentis 2008-06-18 21:04:53 UTC
I adjusted the ebuild to have it build against firefox 3 and it emerged successfully, not only that but it also worked properly in firefox 3.
Comment 4 Billy DeVincentis 2008-06-18 21:05:49 UTC
Created attachment 157501 [details]
ebuild to build against firefox 3
Comment 5 Andrzej Rybczak 2008-06-19 07:34:52 UTC
(In reply to comment #3)
> I adjusted the ebuild to have it build against firefox 3 and it emerged
> successfully, not only that but it also worked properly in firefox 3.
> 

your ebuild doesn't work for me. did you compile fx3 with USE="xulrunner"? Or maybe you have got xulrunner-1.8 or anything xulrunner-1.8 based installed by any chance? That's pretty strange it compiled for you as xulrunner-1.9 is incompatible with mplayerplug-in now. Can you post your build.log from mplayerplug-in's compilation?
Comment 6 Andrew Gaffney (RETIRED) gentoo-dev 2008-06-19 19:41:51 UTC
WFM here
Comment 7 Andrew Gaffney (RETIRED) gentoo-dev 2008-06-20 12:14:32 UTC
With the first 2 patches, that is :)
Comment 8 Russell Yanofsky 2008-06-25 02:00:21 UTC
The patches from comment 1 and comment 2 work for me in Firefox 3. Just had to enable the xulrunner USE flag, and save the first file as "files/mplayerplug-in-against-xulrunner-1.9.patch"
Comment 9 Billy DeVincentis 2008-06-28 00:26:27 UTC
It emerges on both my x86 and amd64 systems with firefox use flag enabled and xulrunner use flag disabled. All use flags enabled except xulrunner and mplayer-bin. Furthermore, it works with one small exception in that on some trailers it leaves a grey area and doesn't make use of all area it should for the movie.
Comment 10 thomas 2008-06-28 06:49:07 UTC
AFAIK the recommended way to install Firefox 3 is with xulrunner USE flag enabled. With this, the ebuild from comment 4 does not work, but the files from comment 1 and comment 2 do.
Comment 11 Alex Busenius 2008-07-03 23:31:10 UTC
Works fine for me with xulrunner-1.9-r2 (no 1.8 version installed) and mozilla-firefox-3.0-r1
USE="divx gmedia gtk nls quicktime realmedia wmp xulrunner -firefox -mplayer-bin -multilib -seamonkey"

Thanks unK
Comment 12 Pawel Madej aka Nysander 2008-08-05 23:06:15 UTC
any chance to pull that patch into the tree?
Comment 13 ferret 2008-08-18 21:49:00 UTC
This change would make it impossible to use mplayerplug-in with firefox 2.

This could probably be fixed by adding ugly but necessary #ifdefs to your patch so that it can build against all versions of xulrunner and mozilla-firefox.

Thanks.
Comment 14 Andrzej Rybczak 2008-08-19 09:47:58 UTC
Notice that it will apply my patch only if it finds =xulrunner-1.9* version installed in your system, otherwise it applies only old patches and there shouldn't be any problem.
Comment 15 Joe Jezak (RETIRED) gentoo-dev 2008-09-19 06:09:27 UTC
With 3.55 (inCVS) it compiles for me.  Please re-open if you're having any further issues.
Comment 16 Andrea Rizzolo 2008-09-19 13:55:04 UTC
(In reply to comment #15)
> With 3.55 (inCVS) it compiles for me.  Please re-open if you're having any
> further issues.
> 

I cannot build 3.55.
about ff and xulrunner:
[ebuild   R   ] net-libs/xulrunner-1.9.1_alpha2-r1  USE="custom-optimization dbus startup-notification -gnome -ipv6 -java" 38,757 kB [?=>1]
[ebuild   R   ] www-client/mozilla-firefox-3.1_alpha2  USE="dbus startup-notification xulrunner -bindist -custom-optimization* -gnome -iceweasel -ipv6 -java -mozdevelop -restrict-javascript" 0 kB [?=>1]

mplayerplug-in: 
[ebuild     U ] net-www/mplayerplug-in-3.55 [3.50] USE="divx firefox gtk nls quicktime realmedia wmp -gmedia (-multilib) -seamonkey -xulrunner* (-mplayer-bin%)" LINGUAS="-cs -da -de -en_US -es -fr -hu -it -ja -ko -nb -nl -pl -pt_BR -ru -se -sk -tr -wa -zh_CN" 0 kB 

with or without xulrunner USE flag mplayerplug-in fails with this error
configure: error: Unable to find mozilla or firefox development files

Comment 17 Joe Jezak (RETIRED) gentoo-dev 2008-09-21 20:59:06 UTC
Neither of those versions of xulrunner or mozilla-firefox are in portage.  When they are, I'll fix it.