Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 220110 - [PATCH] two small dev-libs/liboil-0.3.14 icc compatibility fixes
Summary: [PATCH] two small dev-libs/liboil-0.3.14 icc compatibility fixes
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Freedesktop bugs
URL: http://bugs.freedesktop.org/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-03 13:12 UTC by Rafal Rzepecki
Modified: 2010-01-26 22:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
liboil-0.3.14-icc.patch (liboil-0.3.14-icc.patch,754 bytes, patch)
2008-05-03 13:13 UTC, Rafal Rzepecki 		Details | Diff
liboil-0.3.14-icc.patch (liboil-0.3.14-icc.patch,754 bytes, text/plain)
2008-05-03 13:17 UTC, Rafal Rzepecki 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafal Rzepecki 2008-05-03 13:12:40 UTC 
I've found two little incompatibilities in liboil preventing compilation with icc. I have verified that fixing those does not prevent gcc from building the lib successfully.
Comment 1 Rafal Rzepecki 2008-05-03 13:13:38 UTC 
Created attachment 151692 [details, diff]
liboil-0.3.14-icc.patch

Perhaps those should be pushed upstream?
Comment 2 Rafal Rzepecki 2008-05-03 13:17:25 UTC 
Created attachment 151693 [details]
liboil-0.3.14-icc.patch

Hmmm... sent again as text/plain, last time bugzilla swallowed some lines for some reason.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2008-05-04 08:25:08 UTC 
(In reply to comment #1)
> Created an attachment (id=151692) [edit]
> liboil-0.3.14-icc.patch
> 
> Perhaps those should be pushed upstream?
> 

You should definately open a bug to upstream since they are best to review it. They have bugtracker at bugs.freedesktop.org, please link us there when done.
Comment 4 Łukasz Damentko (RETIRED) gentoo-dev 2008-10-30 16:15:16 UTC 
Reassigning to maintainer-needed since zaheerm has left Gentoo, bug #68473.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2008-12-12 13:33:27 UTC 
Reopen when you have accepted these by upstream.
Comment 6 Rafal Rzepecki 2009-09-10 14:52:12 UTC 
Reported upstream at
http://bugs.freedesktop.org/show_bug.cgi?id=23840

(Better late than never, I guess.)
Comment 7 Víctor Ostorga (RETIRED) gentoo-dev 2009-09-10 15:08:14 UTC 
Reopening to keep track of the bug and upstream response
Comment 8 Rémi Cardona (RETIRED) gentoo-dev 2010-01-26 22:33:42 UTC 
Upstream first, then us. Please attach the patches there directly, it'll make it easier for upstream to review and ACK/NAK the patches. Once they're acked, we'll get them in.

Thanks