Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19128 - taylor-uucp violates FHS and doesn't supply a single example config
Summary: taylor-uucp violates FHS and doesn't supply a single example config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Ryan Phillips (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-11 05:10 UTC by Stefan Förster
Modified: 2023-10-05 19:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild modifications. (taylor-uucp-1.06.2.ebuild,1.05 KB, application/octet-stream)
2003-04-11 23:50 UTC, Chuck Short (RETIRED)
Details
Makefile patch (gentoo-uucp.diff,1.10 KB, patch)
2003-04-11 23:50 UTC, Chuck Short (RETIRED)
Details | Diff
policy.h patch (policy-gentoo.diff,5.19 KB, patch)
2003-04-12 07:47 UTC, Chuck Short (RETIRED)
Details | Diff
updated ebuild (taylor-uucp-1.06.2.ebuild,1.32 KB, application/octet-stream)
2003-04-13 19:23 UTC, Chuck Short (RETIRED)
Details
Logging to /var/log/uucp is better than /var/spool/uucp/Log et al. Fixed ebuild. (uucp.ebuild,1.22 KB, text/plain)
2003-04-14 02:24 UTC, Stefan Förster
Details
Fixed policy.h patch. (uucp.patch,5.16 KB, patch)
2003-04-14 02:25 UTC, Stefan Förster
Details | Diff
Fixed policy.h patch. (uucp.patch,5.16 KB, patch)
2003-04-14 02:25 UTC, Stefan Förster
Details | Diff
Changes uucp shell to /bin/bash (taylor-uucp-1.06.2.ebuild,1.10 KB, application/octet-stream)
2003-04-20 22:35 UTC, Chuck Short (RETIRED)
Details
Typo in ebuild (taylor-uucp-1.06.2.ebuild,1.10 KB, text/plain)
2003-04-21 09:47 UTC, Chuck Short (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Förster 2003-04-11 05:10:32 UTC
After installing taylor-uucp, it tries to write it's log and spool files to /usr/$SUBDIR. THis might be acceptable for platforms like AIX, on linux, spooled data should go to /var/spool/[uucp|uucppublic] and log data should end somwhere under /var/log or even better /var/log/uucp. Please modify policy.h accordingly.

Please do at least provide some _sample_ configuration files under /etc/uucp, there is _no_ need for anything "working", but some examples would really help beginners, I assume.

Please create the directories, where spool and log data end (according to policy.h) during the emerge.

Reproducible: Always
Steps to Reproduce:

1. emerge taylor-uucp
2. qpkg -l taylor-uucp does neither show example config files nor any spool/log directories und /var
3. Calling "/usr/sbin/uucico -S foo" tries to write log data to /usr/...

Actual Results:  
Data is stored in non-FHS-compliant places.

Expected Results:  
Store data according to "man hier" and the FHS.

Why, exactly, is the shell of user "uucp" set to "/bin/true"?

Portage 2.0.47-r10 (default-x86-1.4, gcc-3.2.2, glibc-2.3.1-r4)
=================================================================
System uname: 2.4.20-xfs i686 AMD Athlon(TM) XP2200+
GENTOO_MIRRORS="http://www.fhh.opensource-mirror.de/gentoo.org/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://gentoo.oregonstate.edu/ http://www.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY=""
USE="slang -3dfx 3dnow -aalib acl acpi -afs alsa -apache2 apm arts -atlas avi berkdb -bonobo -canna cdr -cjk crypt cups -directfb -dga -doc -dvb dvd encode -esd ethereal -evo fbcon flash -freewnn -gb gd gdbm -ggi gif -gnome gphoto2 gpm -gps -gtk -guile -icc imap imlib innodb -ipv6 java jikes jpeg -junit kde -kerberos lcms -ldap -leim -libg++ -libgda libwww lirc -matrix -maildir mbox mikmod mmx motif mozilla mpeg -mule mysql -nas ncurses nls nocardbus -oav -oci8 odbc oggvorbis opengl oss pam -pcmcia pda pdflib perl pic plotutils png -pnp -postgres python qt quicktime readline -ruby samba sasl scanner sdl -slp snmp -socks5 spell sse ssl -static -svga tcltk tcpd tetex tiff truetype -trusted usb -voodoo3 -wavelan wmf X xface xml xml2 xmms xv zlib x86 xft"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer"
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer"
ACCEPT_KEYWORDS="x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage/"
FEATURES="sandbox ccache"
Comment 1 Chuck Short (RETIRED) gentoo-dev 2003-04-11 23:50:05 UTC
Created attachment 10535 [details]
Proposed ebuild modifications.
Comment 2 Chuck Short (RETIRED) gentoo-dev 2003-04-11 23:50:36 UTC
Created attachment 10536 [details, diff]
Makefile patch
Comment 3 Chuck Short (RETIRED) gentoo-dev 2003-04-11 23:53:23 UTC
Hi,

This is my propoaded changes to the taylor-uucp ebuild. I hade added a patch which  modifies the Makefile. I have also changed the src_compile to do a simeple configure and make. I have hardly touch the src_install but i did add the line to copy the sample directory to /etc/uucp. The sample directory contains sample configuration files.

Regards
Chuck
aka Zul
Comment 4 Stefan Förster 2003-04-12 05:43:05 UTC
This looks quite good and works for me so far, but I still miss the changes to policy.h which make the package spool to /var/spool/uucp and /var/spool/uucppublic, not /usr/spool/[...] by default. Shouldn't we rather modify policy.h to get default locations of logs and spool data changed than modifying the Makefile/eBuild?

If we do not modify policy.h, I think we should change the manpage of "man hier" and remove the UUCP section from there.
Comment 5 Chuck Short (RETIRED) gentoo-dev 2003-04-12 07:47:52 UTC
Created attachment 10547 [details, diff]
policy.h patch

This patch fixes the policy.h file.
Comment 6 Stefan Förster 2003-04-13 17:57:05 UTC
This looks very good to me and works completely flawless. Well, almost - it seems that baselayout (or whatever package is responsible for that) does not create the necessary directories /var/spool/uucp, /var/spool/uucppublic and and /var/log/uucp.
But I don't know exactly if this is something related to baselayout, or if it should be done by the ebuild of taylor-uucp. Thank you for your efforts, Chuck.
Comment 7 Chuck Short (RETIRED) gentoo-dev 2003-04-13 19:23:23 UTC
Created attachment 10607 [details]
updated ebuild

Creates the /var/spool directories et al.
Comment 8 Stefan Förster 2003-04-14 02:24:49 UTC
Created attachment 10619 [details]
Logging to /var/log/uucp is better than /var/spool/uucp/Log et al. Fixed ebuild.
Comment 9 Stefan Förster 2003-04-14 02:25:26 UTC
Created attachment 10620 [details, diff]
Fixed policy.h patch.

Logging to /var/log/uucp/
Comment 10 Stefan Förster 2003-04-14 02:25:36 UTC
Created attachment 10621 [details, diff]
Fixed policy.h patch.

Logging to /var/log/uucp/.
Comment 11 Stefan Förster 2003-04-14 02:46:16 UTC
Sorry for that double post. I missed that your patch to policy.h and the ebuild logged to /var/spool/[...] instead of /var/log/uucp, I fexied that.
So, one last thing remains: Shouldn't we include a chsh command to change uucp's shell from /bin/false or /bin/true to /bin/bash, just for the sake of consistency? If a uucp package is installed, you should be able to use the correspondig user.
I hope weg got the permissions straight, I didn' want to delete all the folders on my system, but /var/spool/uucp* and /var/log/uucp should be 775 for uucp:root, shouldn't they? (or perhaps 755).
Comment 12 Chuck Short (RETIRED) gentoo-dev 2003-04-20 22:35:39 UTC
Created attachment 10933 [details]
Changes uucp shell to /bin/bash

This is the updated ebuild which modifies the uucp user shell to /bin/bash.

- chuck
Comment 13 Chuck Short (RETIRED) gentoo-dev 2003-04-21 09:47:35 UTC
Created attachment 10945 [details]
Typo in ebuild

Typo in ebuild.
Comment 14 Seemant Kulleen (RETIRED) gentoo-dev 2003-06-13 02:26:46 UTC
ryan's back from hiatus so giving this to him

thanks for the hard work, chuck
Comment 15 Aron Griffis (RETIRED) gentoo-dev 2003-07-27 16:14:27 UTC
Ryan, are you going to be able to make progress on this soon?
Comment 16 Ryan Phillips (RETIRED) gentoo-dev 2003-07-31 12:19:59 UTC
Thank you Chuck on your great work... Committed. 
Comment 17 Larry the Git Cow gentoo-dev 2023-10-05 19:57:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8a96f916dc3adb981ccc09bc3a59fe3e5112698

commit c8a96f916dc3adb981ccc09bc3a59fe3e5112698
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-10-05 19:55:25 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-10-05 19:56:34 +0000

    net-misc/taylor-uucp: drop usermod calls
    
    If a specific shell is required for the uucp user, it must be handled in
    acct-user/uucp and/or sys-apps/baselayout.
    
    Bug: https://bugs.gentoo.org/19128
    Closes: https://bugs.gentoo.org/915215
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../{taylor-uucp-1.07-r5.ebuild => taylor-uucp-1.07-r6.ebuild} | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)