Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 160671 - xfce-base/xfprint-4.4.0 needs either lprng or cups
Summary: xfce-base/xfprint-4.4.0 needs either lprng or cups
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
: 165747 (view as bug list)
Depends on:
Blocks: xfce44
  Show dependency tree
 
Reported: 2007-01-07 13:15 UTC by Samuli Suominen (RETIRED)
Modified: 2007-02-18 13:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xfprint-4.3.99.2.ebuild.patch (xfprint-4.3.99.2.ebuild.patch,1.03 KB, patch)
2007-01-07 13:17 UTC, Samuli Suominen (RETIRED)
Details | Diff
xfprint-4.3.99.2.ebuild.diff - cups as default (xfprint-4.3.99.2.ebuild.diff,803 bytes, patch)
2007-01-07 13:25 UTC, Jakub Moc (RETIRED)
Details | Diff
xfprint-4.3.99.2.ebuild.diff - a correct one (xfprint-4.3.99.2.ebuild.diff,806 bytes, patch)
2007-01-07 13:35 UTC, Jakub Moc (RETIRED)
Details | Diff
xfprint-4.4.0.ebuild.diff (xfprint-4.4.0.ebuild.diff,688 bytes, patch)
2007-02-07 12:48 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:15:28 UTC
-I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/atk-1.0
checking XFCE_MCS_MANAGER_LIBS... -lxfcegui4 -lxfce4mcs-manager -lxfce4mcs-client -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lxfce4util -lglib-2.0
checking where to install MCS plugins... ${exec_prefix}/lib/xfce4/mcs-plugins
configure: error: You need to have at least CUPS or BSDLPR in order to use Xfprint

!!! Please attach the following file when filing a report to bugs.gentoo.org:
!!! /var/tmp/portage/xfprint-4.3.99.2/work/xfprint-4.3.99.2/config.log

!!! ERROR: xfce-base/xfprint-4.3.99.2 failed.

Reproducible: Always

Steps to Reproduce:
1. USE="-lpr -cups" emerge -av xfprint
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:17:32 UTC
Created attachment 105799 [details, diff]
xfprint-4.3.99.2.ebuild.patch

And remove entry

xfce-base/xfprint:lpr - Build LPr/LPd support instead of CUPS support.

from use.local.desc

Reason I left USE="cups" as alternative because it's a common flag, and also in use.desc.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-01-07 13:19:47 UTC
I'd really prefer to have cups as default, not the other way round...
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:23:19 UTC
jakub, It can be done otherway around too. I don't mind.

And this is a good reason to remove xfprint from xfce4 meta ebuild. You can't assume everyone using xfce4, actually has an printer..

That's just insane. :-)
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-01-07 13:25:31 UTC
Created attachment 105803 [details, diff]
xfprint-4.3.99.2.ebuild.diff - cups as default

Does this work for you?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:29:14 UTC
(In reply to comment #4)
> Created an attachment (id=105803) [edit]
> xfprint-4.3.99.2.ebuild.diff - cups as default
> 
> Does this work for you?
> 

+IUSE="debug lpr"

+XFCE_CONFIG="$(use_enable cups) $(use_enable !cups bsdlpr)"

Looks incorrect.
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-01-07 13:35:08 UTC
Created attachment 105805 [details, diff]
xfprint-4.3.99.2.ebuild.diff - a correct one

Sigh...
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-01-07 13:41:16 UTC
(In reply to comment #3)
> And this is a good reason to remove xfprint from xfce4 meta ebuild. You can't
> assume everyone using xfce4, actually has an printer..
> 
> That's just insane. :-)

Something like this, maybe?
 
--- xfce4-4.3.99.2-r1.ebuild	2006-12-12 05:06:37.000000000 +0100
+++ xfce4-4.3.99.2-r1.ebuild	2007-01-07 14:38:30.000000000 +0100
> That's just insane. :-)

Something like this, maybe?
 
--- xfce4-4.3.99.2-r1.ebuild	2006-12-12 05:06:37.000000000 +0100
+++ xfce4-4.3.99.2-r1.ebuild	2007-01-07 14:38:30.000000000 +0100
@@ -7,7 +7,7 @@
 LICENSE="GPL-2 BSD LGPL-2"
 KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86"
 SLOT="0"
-IUSE=""
+IUSE="print"
 
 RDEPEND="~x11-themes/gtk-engines-xfce-2.3.99.2
 	~xfce-base/xfce-mcs-plugins-${PV}
@@ -16,7 +16,6 @@
 	~xfce-base/xfce-utils-${PV}
 	~xfce-base/xfdesktop-${PV}
 	~xfce-base/xfce4-session-${PV}
-	~xfce-base/xfprint-${PV}
 	~xfce-base/orage-${PV}
 	~xfce-base/thunar-0.5.0_rc2
 	~xfce-extra/xfwm4-themes-${PV}
@@ -24,7 +23,8 @@
 	~xfce-extra/xfce4-icon-theme-${PV}
 	~xfce-extra/terminal-0.2.5.8_rc2
 	~xfce-extra/xfce4-mixer-${PV}
-	~xfce-extra/mousepad-0.2.10"
+	~xfce-extra/mousepad-0.2.10
+	print? ( ~xfce-base/xfprint-${PV} )
 
 src_install() {
 	dodir /etc/X11/Sessions
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:42:29 UTC
(In reply to comment #6)
> Created an attachment (id=105805) [edit]
> xfprint-4.3.99.2.ebuild.diff - a correct one
> 
> Sigh...
> 

Works for me.
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2007-01-07 13:45:11 UTC
> Something like this, maybe?
> +       print? ( ~xfce-base/xfprint-${PV} )

Yes, something like that. I was thinking USE="cups lpr" also for meta ebuild which would pull xfprint as dep; just keep things consistent.

Anyways, your solution is fine with me too.
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2007-01-21 22:41:31 UTC

*** This bug has been marked as a duplicate of bug 156957 ***
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2007-02-07 12:45:35 UTC
*** Bug 165747 has been marked as a duplicate of this bug. ***
Comment 12 Jakub Moc (RETIRED) gentoo-dev 2007-02-07 12:48:02 UTC
Created attachment 109423 [details, diff]
xfprint-4.4.0.ebuild.diff
Comment 13 Jakub Moc (RETIRED) gentoo-dev 2007-02-07 12:51:39 UTC
The above patch requires either getting net-print/lprng keyworded on arm, ia64 and mips or use.masking lpr there.
Comment 14 Jakub Moc (RETIRED) gentoo-dev 2007-02-07 12:52:27 UTC
*** Bug 165747 has been marked as a duplicate of this bug. ***
Comment 15 Jakub Moc (RETIRED) gentoo-dev 2007-02-07 12:56:55 UTC
@arm, ia64 - please either keyword net-print/lprng-3.8.28 or use.mask lpr there if not possible or if you prefer so. Thanks.
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2007-02-07 16:01:57 UTC
If we really need this, it needs to be done this way:

RDEPEND="!cups? ( net-print/lprng )"
DEPEND="${RDEPEND}"

if use cups; then
XFCE_CONFIG="${XFCE_CONFIG} --enable-bsdlpr --enable-cups"
else
XFCE_CONFIG="${XFCE_CONFIG} --enable-bsdlpr"
fi

There won't be USE="lpr". Using USE="cups" because it's commonly used use.desc flag allready. I'm against adding more use.local.desc entries for Xfce4 if not really needed.

~arm and ~ia64, please keyword lprng so I can close this bug once and for all.
Comment 17 Samuli Suominen (RETIRED) gentoo-dev 2007-02-18 13:47:57 UTC
Fixed finally. Thanks to everyone involved here.