cyrus-sasl-2.1.22 forces jdk-1.4, while there is no need to. You should force >=jdk-1.4 for stable, so people may use jdk-1.5. But better migrate to the new java build system and allow >=jdk-1.4
Created attachment 96248 [details, diff] cyrus-sasl-2.1.22.ebuild.diff - generation-2 using generation 2 java eclass
(In reply to comment #0) > cyrus-sasl-2.1.22 forces jdk-1.4, while there is no need to. > You should force >=jdk-1.4 for stable, so people may use jdk-1.5. > > But better migrate to the new java build system and allow >=jdk-1.4 > I don't know if your modification would work for both java generation. CC java team for comment.
For generation-22 I supply the attachment#96248 [details, diff]. The problem is that the generation-2 is not stable. Since your package is stable, just add the right dependency >=jdk-1.4. It is working with generation-1 if the user have jdk-1.5 configured as generation one. And it does not hurt the current users.
Created attachment 96338 [details, diff] cyrus-sasl-2.1.22.ebuild.diff - generation-1 This is for generation-1 (stable)
Comment on attachment 96248 [details, diff] cyrus-sasl-2.1.22.ebuild.diff - generation-2 This is for generation-2 (unstable)
$ earch jdk-1.4.1: jdk-1.4.2: ppc amd64 ppc64 ia64 x86 jdk-1.5.0: ~amd64 ~x86 ~x86-fbsd ~ia64 ~ppc ~ppc64 ~s390 virtual/jdk-1.4 is not stable on any arch yet. how about I do a revision bump for generation-2 and leave the stable ebuild alone?
Patch from comment 4 would slightly improve the deps for stable ebuild so that user doesn't need a JDK for runtime where JRE is enough. Changing '=' to '>=' doesn't really mean anything for generation-1 ebuild. For the future we will of course want revision bump migrated to generation-2 but not the one from comment 5. Just looking at it I see "use java && java-pkg-opt-2_pkg_setup" - this is not how it should be done. I will see about a proper gen-2 ebuild tomorrow.
(In reply to comment #6) > virtual/jdk-1.4 is not stable on any arch yet. how about I do a revision bump > for generation-2 and leave the stable ebuild alone? That would be great!
(In reply to comment #7) > Patch from comment 4 would slightly improve the deps for stable ebuild so that > user doesn't need a JDK for runtime where JRE is enough. Changing '=' to '>=' > doesn't really mean anything for generation-1 ebuild. It does... Since we can modify jdk-1.5 to be generation-1 and then have only one jvm on your machine. If there is no explicit reason why support only 1.4, I don't see why explicit downgrade. > For the future we will of course want revision bump migrated to generation-2 > but not the one from comment 5. Just looking at it I see "use java && > java-pkg-opt-2_pkg_setup" - this is not how it should be done. I will see about > a proper gen-2 ebuild tomorrow. OK... Thanks... And then it needs to be documented why it is wrong... Since from http://www.gentoo.org/proj/en/java/java-devel.xml I cannot understand why.
(In reply to comment #9) > OK... Thanks... And then it needs to be documented why it is wrong... Since > from http://www.gentoo.org/proj/en/java/java-devel.xml I cannot understand why. > It is already documented how to use optional java support. There is even an example of it. http://www.gentoo.org/proj/en/java/java-devel.xml#java-pkg-opt-2.eclass example under 'Typical Examples'
As for why not to do use java && java-pkg-opt-2_pkg_setup, java-pkg-opt-2_pkg_setup already does the appropriate conditional for you. The docs actually should mention that the java-pkg-2's pkg_setup does need to be called if you override the default pkg_setup. Separate issue (ie new bug) for that though.
Created attachment 97033 [details, diff] cyrus-sasl-2.1.22.ebuild.diff - generation-2 This is modified generation-2, without use java && Please approve.
(In reply to comment #11) > The docs actually should mention that the java-pkg-2's pkg_setup does need to > be called if you override the default pkg_setup. Separate issue (ie new bug) > for that though. Will you fix documentation, open a bug to your-self, or wish someone else to open bug for this?
Created attachment 97579 [details, diff] patch for generation 2 revbumped ebuild Aside from the usual stuff it was needed to pass the right JAVACFLAGS to ensure 1.4 bytecode for the .jar produced. Because this buildsystem doesn't seem to have a way to pass flags for JAVAC separately, I was forced to stick them to the JAVAC variable, which is honored. Seems to work fine.
Reminder: java generation 2 is stable, can fix this.
Please... At least correct dependency for generation 1.
Yeah, you could revbump with patch from comment 14, please.
PPPPPlease.... please revbump.
Hello? Is there anyone here?
(In reply to comment #17) > Yeah, you could revbump with patch from comment 14, please. > Why does the path remove java from IUSE, yet it continues to use the flag in (R)DEPEND ?
(In reply to comment #20) > (In reply to comment #17) > > Yeah, you could revbump with patch from comment 14, please. > > > > Why does the path remove java from IUSE, yet it continues to use the flag in > (R)DEPEND ? > s/path/patch/, obviously, sorry about that.
Look at java-pkg-opt-2.eclass: JAVA_PKG_OPT_USE=${JAVA_PKG_OPT_USE:-java} IUSE="${JAVA_PKG_OPT_USE}"
This should not be difficult to close... Any reason why leave this open so much time?
OK. Finish waiting. Fixed QA issues and upgraded to new java build. CC me if anyone have problem with this modification.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c84fe40b538893712cbbf501b36d3442b52f8a commit 21c84fe40b538893712cbbf501b36d3442b52f8a Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-04-26 05:14:13 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-26 12:48:53 +0000 dev-libs/cyrus-sasl: remove fno-strict-aliasing hack It dated back to 2007 and has no comments describing why it existed at the time. The package builds file with -Werror=strict-aliasing. Bug: https://bugs.gentoo.org/146647 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/cyrus-sasl/cyrus-sasl-2.1.28-r4.ebuild | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
