Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 142329 - app-admin/cpu-1.4.3-r1 fails to compile due to strange array (?)
Summary: app-admin/cpu-1.4.3-r1 fails to compile due to strange array (?)
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
: 162109 (view as bug list)
Depends on: 173064
Blocks:
  Show dependency tree
 
Reported: 2006-07-31 13:30 UTC by Wulf Krueger (RETIRED)
Modified: 2007-06-25 23:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch using suggested fix (cpu-1.4.3-gentoo.diff,362 bytes, patch)
2006-09-12 05:54 UTC, David Tenty
Details | Diff
Ebuild that uses the patch (cpu-1.4.3-r2.ebuild,1.25 KB, application/octet-stream)
2006-09-12 05:55 UTC, David Tenty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wulf Krueger (RETIRED) gentoo-dev 2006-07-31 13:30:48 UTC
i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../../src/include -mtune=pentium3 -march=pentium3 -O2 -pipe -w -MT group.lo -MD -MP -MF .deps/group.Tpo -c group.c  -fPIC -DPIC -o .libs/group.lo
ld.c: In function `getlGid':
ld.c:806: error: subscripted value is neither array nor pointer
i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../../src/include -mtune=pentium3 -march=pentium3 -O2 -pipe -w -MT group.lo -MD -MP -MF .deps/group.Tpo -c group.c -o group.o >/dev/null 2>&1
make[4]: *** [ld.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
mv -f .libs/group.lo group.lo
make[4]: Leaving directory `/var/tmp/portage/cpu-1.4.3-r1/work/cpu-1.4.3/src/plugins/ldap'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/cpu-1.4.3-r1/work/cpu-1.4.3/src/plugins/ldap'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/cpu-1.4.3-r1/work/cpu-1.4.3/src/plugins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/cpu-1.4.3-r1/work/cpu-1.4.3/src'
make: *** [all-recursive] Error 1

!!! ERROR: app-admin/cpu-1.4.3-r1 failed.
Call stack:
  ebuild.sh, line 1539:   Called dyn_compile
  ebuild.sh, line 939:   Called src_compile
  cpu-1.4.3-r1.ebuild, line 35:   Called die


Line 806 in ld.c is this one:

gid = ldap_get_values (ld, pos, gid)[0];

That doesn't look very healthy, indeed, and it's the only call of ldap_get_values at all in the code like that.

Changing it to...

gid = ldap_get_values (ld, pos, gid);

... makes it compile and cpu itself seems to work fine. 


emerge --info

Portage 2.1-r1 (default-linux/x86/2006.0, gcc-3.4.6, glibc-2.3.6-r4, 2.6.16-usermode-r4-bs2 i686)
=================================================================
System uname: 2.6.16-usermode-r4-bs2 i686 UML
Gentoo Base System version 1.6.15
app-admin/eselect-compiler: [Not Present]
dev-lang/python:     2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  0.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r3
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-mtune=pentium3 -march=pentium3 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /mnt/etc /usr/share/X11/xkb /var/www/localhost /var/www/localhost/cgi-bin /var/www/localhost/htdig /var/www/localhost/htdocs/phpmyadmin"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-mtune=pentium3 -march=pentium3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer parallel-fetch sandbox sfperms strict"
GENTOO_MIRRORS="http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/overlays/portage /usr/local/overlays/ecatmur"
SYNC="private mirror"
USE="x86 X X509 Xaw3d async bash-completion bdf berkdb bitmap-fonts bzip2 c++ chroot cracklib crypt curl curlwrappers dga dio dlloader dmi dri emacs emacs-w3 extensions fam font-server gdbm gif glibc-omitfp iconv idn innodb ipv6 java javascript jce jpeg leim libwww mmap mmx mmxext mng multi-tty ncurses nls nptl nptlonly offensive pam pcntl pcre perl png posix python qt3 qt4 readline recode session sharedmem sockets sse ssl sysvipc tcpd threads tiff truetype truetype-fonts type1-fonts udev unicode xml xorg xpm xrandr xsl xv xvid zlib elibc_glibc input_devices_keyboard input_devices_mouse kernel_linux userland_GNU video_cards_apm video_cards_nv"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 David Tenty 2006-09-12 05:54:08 UTC
Created attachment 96786 [details, diff]
Patch using suggested fix
Comment 2 David Tenty 2006-09-12 05:55:39 UTC
Created attachment 96787 [details]
Ebuild that uses the patch
Comment 3 karaluch 2006-12-07 12:28:57 UTC
Hi, I have the same problem but your patch is not working, could you check my code...

ps. I called ypur patch cpu-1.4.3-r1-gcc.patch 

--- LOG ---
emerge cpu|grep cpu-1.4.3-r1-gcc.patch
 * Applying cpu-1.4.3-r1-gcc.patch ...
commandline.c: In function 'parseCommand':
commandline.c:86: error: invalid lvalue in assignment
make[4]: *** [commandline.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1

!!! ERROR: app-admin/cpu-1.4.3-r1 failed.
Call stack:
  ebuild.sh, line 1569:   Called dyn_compile
  ebuild.sh, line 938:   Called src_compile
  cpu-1.4.3-r1.ebuild, line 42:   Called die

!!! Make failure
!!! If you need support, post the topmost build error, and the call stack if relevant.
--- /LOG ---
Comment 4 Wulf Krueger (RETIRED) gentoo-dev 2006-12-07 22:09:04 UTC
That's a different problem and therefore the patch doesn't help. I'll have a look at it later today.
Comment 5 karaluch 2006-12-08 01:00:50 UTC
I'm so sorry for my mistake, your patch work perfect, BUT only with cpu-1.4.3-gcc4.patch I forgot about it and that was my problem ;-))

It's my cpu-1.4.3-r1.ebuild

inherit eutils
src_unpack() {
        unpack ${A}
        epatch ${FILESDIR}/cpu-1.4.3-gcc4.patch
        epatch ${FILESDIR}/cpu-1.4.3-r1-gcc.patch
}
Comment 6 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-01-14 21:29:40 UTC
*** Bug 162109 has been marked as a duplicate of this bug. ***
Comment 7 Fabian Groffen gentoo-dev 2007-01-14 22:13:32 UTC
That patch looks wrong.  The return is a char **, which with this patch only the pointer to the pointer is used as string, which will undoubtedly result in unexpected behaviour (or a crash).

The patch from bug #162109 is better in this regard.

Robin, if you don't use this package (any more), I don't mind to help out here.
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-01-15 00:15:58 UTC
grobian: if you want it, it's yours.
I put it into the tree years ago when we needs LDAP admin tools for work, and we were very dissatisfied with all of them, leading me to write (well do a major fork) our own tool (available as diradm, but about 6 versions behind because I've only done private releases due to heisenbugs).
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-06-25 23:00:43 UTC
Removed from the tree.