Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106677 - [GLSA-2] glsa-check is not working correctly with slotted packages.
Summary: [GLSA-2] glsa-check is not working correctly with slotted packages.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: GLSA Errors (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Security
URL:
Whiteboard:
Keywords:
: 143989 497322 (view as bug list)
Depends on:
Blocks: 228911
  Show dependency tree
 
Reported: 2005-09-20 07:02 UTC by Peter Volkov (RETIRED)
Modified: 2017-01-13 14:42 UTC (History)
16 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
GLSA-SLOT-support-in-vulnerable-unaffected-package.patch (0001-GLSA-SLOT-support-in-vulnerable-unaffected-package.patch,1.72 KB, patch)
2008-09-28 15:50 UTC, Robert Buchholz (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2005-09-20 07:02:25 UTC
Hello.

Some time ago I've upgraded to python-2.4.1. The old version was still installed
on my system, and glsa-check reported about vulnerability.

camobap glsa # glsa-check -p 200509-08
Checking GLSA 200509-08
The following updates will be performed for this GLSA:
     dev-lang/python-2.3.5-r2 (2.3.5)

But suggestion to update python was wrong. Look command:
emerge --ask --oneshot --verbose ">=dev-lang/python-2.3.5-r2"
reemerge python-2.4.1 for me and does not touch python-2.3.5.

Thus glsa shoud somehow check for problems in slotted apps and report more sane
suggestion like:
emerge --ask --oneshot =dev-lang/python-2.3.5-r2

Or may be some other way...

Any way. Thank you for your attention,
Peter.

Reproducible: Always
Steps to Reproduce:
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2005-09-20 07:05:39 UTC
Not a problem in glsa-check but the GLSA text.
Comment 2 Thierry Carrez (RETIRED) gentoo-dev 2005-10-25 07:17:27 UTC
Reassigning to GLSA errors
Comment 3 Joe Wells 2006-07-10 03:28:02 UTC
I would like to add to this one.

The output from "glsa-check --list" is confusing for slotted packages.
For example, GLSA 200607-02 identifies all versions of
media-libs/freetype before 2.1.10-r2 as being vulnerable.  However, I
can see that I have media-libs/freetype-2.1.10-r2 installed, so I get
confused because it seems my system is already up-to-date.

The explanation is that media-libs/freetype-1.3.1-r4 is also installed
on my system.  I suggest that it would be a nice improvement if
"glsa-check --list" would list the precise vulnerable versions.
Comment 4 Raphael Marichez (Falco) (RETIRED) gentoo-dev 2006-08-16 01:50:38 UTC
*** Bug 143989 has been marked as a duplicate of this bug. ***
Comment 5 Ian Stakenvicius 2006-08-18 06:35:34 UTC
So is anyone working on adding slot support?  If so i'd like to help out..  (put this whole social workspaces thing to use :) )
Comment 6 Matthias Geerdsen (RETIRED) gentoo-dev 2006-11-02 06:25:36 UTC
reviving this bug...

glsa-check is really missing support for ranges in affected/unaffected versions, which would really help a lot when doing GLSAs for slotted packages (esp. PHP etc.). The current situation of updating old PHP GLSAs when new versions come out is seriously annoying.

So are there any planned changes for glsa-check? I know this has been discussed before with koon for example, but what was/is the actual outcome?
Comment 7 Marius Mauch (RETIRED) gentoo-dev 2006-11-02 16:46:00 UTC
No. If such a feature gets implemented it's at the portage level, but I don't see that happening anytime soon (at least not by me). The revision-range hack is already bad enough.
*Maybe* if I find the time I'll add support for slot deps, but that's a big "if" currently.
However, any such extension is going to require a versioning system (e.g. a <glsa-version> tag) for glsas so glsa-check (and other tools) can check if they can process a given glsa. And to be effective this would have to be deployed quite some time before any extension could be used.
Comment 8 Wolfram Schlich (RETIRED) gentoo-dev 2007-05-14 05:26:16 UTC
This is now really annoying regarding 200702-07 (java stuff):
--8<--
vesta ~ # glsa-check -p affected
Checking GLSA 200702-07
The following updates will be performed for this GLSA:
     dev-java/sun-jre-bin-1.5.0.10 (1.4.2.14)
     dev-java/sun-jdk-1.5.0.11 (1.4.2.14)

vesta ~ # qlist -Iv dev-java/sun-
dev-java/sun-jdk-1.4.2.14
dev-java/sun-jdk-1.5.0.11-r1
dev-java/sun-jdk-1.6.0-r2
dev-java/sun-jre-bin-1.4.2.14
dev-java/sun-jre-bin-1.5.0.11
dev-java/sun-jre-bin-1.6.0-r1
vesta ~ # egrep '(package|range=)' /usr/portage/metadata/glsa/glsa-200702-07.xml
    <package name="dev-java/sun-jdk" auto="yes" arch="*">
      <unaffected range="ge">1.5.0.10</unaffected>
      <unaffected range="rge">1.4.2.13</unaffected>
      <vulnerable range="lt">1.5.0.10</vulnerable>
      <vulnerable range="lt">1.4.2.13</vulnerable>
    </package>
    <package name="dev-java/sun-jre-bin" auto="yes" arch="*">
      <unaffected range="ge">1.5.0.10</unaffected>
      <unaffected range="rge">1.4.2.13</unaffected>
      <vulnerable range="lt">1.5.0.10</vulnerable>
      <vulnerable range="lt">1.4.2.13</vulnerable>
    </package>
vesta ~ #
--8<--
Comment 9 Marius Mauch (RETIRED) gentoo-dev 2007-05-30 17:26:17 UTC
r403 of glsa-check has now some basic support for checking $SLOT when selecting/displaying upgrades. As for slot support in GLSAs, portage has now support for slot-deps, but for using this the second part of comment #7 must first be taken care of.
Comment 10 Robert Buchholz (RETIRED) gentoo-dev 2007-12-03 13:34:31 UTC
This also affects python 2.5 users for GLSA 200711-07.

Marius, what's the status of SLOT support or security support in portage?
Comment 11 Marius Mauch (RETIRED) gentoo-dev 2007-12-03 16:15:21 UTC
(In reply to comment #10)
> This also affects python 2.5 users for GLSA 200711-07.
> 
> Marius, what's the status of SLOT support or security support in portage?

Please define "SLOT support" and "security support in portage", unless you only refer to using slot deps in GLSAs, in that case my previous comments still apply. I guess the main problem there is that nobody feels responsible for glsa.dtd anymore.
Comment 12 Robert Buchholz (RETIRED) gentoo-dev 2007-12-03 16:22:33 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > This also affects python 2.5 users for GLSA 200711-07.
> > 
> > Marius, what's the status of SLOT support or security support in portage?
> 
> Please define "SLOT support" and "security support in portage", unless you only
> refer to using slot deps in GLSAs, in that case my previous comments still
> apply. I guess the main problem there is that nobody feels responsible for
> glsa.dtd anymore.

Sorry for being unclear. With SLOT support I meant this problem:
GLSA 200711-07 marks ">= 2.4.4-r6" as unafected, but because of SLOTing, Python 2.5* is found to be affected by glsa-check.

Is that what you call GLSA SLOT deps?

By security support in Portage I meant your integration of glsa checking and fixing without glsa-check, by "emerge security".

What changes in the DTD would you need?
Comment 13 Marius Mauch (RETIRED) gentoo-dev 2007-12-03 17:11:31 UTC
(In reply to comment #12)
> Sorry for being unclear. With SLOT support I meant this problem:
> GLSA 200711-07 marks ">= 2.4.4-r6" as unafected, but because of SLOTing, Python
> 2.5* is found to be affected by glsa-check.
> 
> Is that what you call GLSA SLOT deps?

You could use the "rge" operator in the GLSA to only include revisions of 2.4.4 (though if python-2.4.5 would come along you'd have the opposite problem)

> By security support in Portage I meant your integration of glsa checking and
> fixing without glsa-check, by "emerge security".

That's in portage-2.2

> What changes in the DTD would you need?

As I said, the first requirement would be some kind of versioning, otherwise we get into the same situation as with portage and ebuilds where format extensions break older versions of the application.
Only then can we talk about how to specify slot deps in the GLSA syntax.
Comment 14 Marius Mauch (RETIRED) gentoo-dev 2007-12-03 19:23:29 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > Sorry for being unclear. With SLOT support I meant this problem:
> > GLSA 200711-07 marks ">= 2.4.4-r6" as unafected, but because of SLOTing, Python
> > 2.5* is found to be affected by glsa-check.
> > 
> > Is that what you call GLSA SLOT deps?
> 
> You could use the "rge" operator in the GLSA to only include revisions of 2.4.4
> (though if python-2.4.5 would come along you'd have the opposite problem)

Actually forget what I said (I misread your statement, 2.5 should not be considered affected as its not matched by the <vulnerable> section. If it is please open a separate bug about it (including the exact commands you used and their full output)
Comment 15 Ewgenij Starostin 2007-12-03 19:46:09 UTC
Actually, never mind. Robert’s comment 10 was due to the situation on my machine, with Python 2.5 installed; glsa-check was justified in matching the GLSA, though, because there was also an old Python 2.4 that I didn’t know I had (and which had escaped updates until now). So no problem with that, and sorry to have wasted your time.
Comment 16 Sven 2008-07-19 16:04:04 UTC
Any updates on this?

Running "glsa-check -p affected" now looks like this for one my system:

# glsa-check -p affected
Checking GLSA 200804-20
The following updates will be performed for this GLSA:
     dev-java/sun-jdk-1.6.0.05 (1.6.0.07)

Checking GLSA 200806-10
The following updates will be performed for this GLSA:
     media-libs/freetype-2.3.6 (2.3.7)

Checking GLSA 200705-23
The following updates will be performed for this GLSA:
     dev-java/sun-jdk-1.5.0.15 (1.6.0.07)


# equery l freetype
[ Searching for package 'freetype' in all categories among: ]
 * installed packages
[I--] [  ] media-libs/freetype-1.4_pre20080316-r1 (1)
[I--] [  ] media-libs/freetype-2.3.7 (2)
# equery l sun-jdk
[ Searching for package 'sun-jdk' in all categories among: ]
 * installed packages
[I--] [ ~] dev-java/sun-jdk-1.4.2.18 (1.4)
[I--] [ ~] dev-java/sun-jdk-1.5.0.16 (1.5)
[I--] [ ~] dev-java/sun-jdk-1.6.0.07 (1.6)
Comment 17 Robert Buchholz (RETIRED) gentoo-dev 2008-07-19 16:17:07 UTC
Freetype being listed is an error in the GLSA, we will be issueing an Errata GLSA in bug 225851.

As for GLSA slot support, this has been discussed in the last security team meeting, and we will push forward a design proposal soon.
Comment 18 Robert Buchholz (RETIRED) gentoo-dev 2008-09-28 15:50:35 UTC
Created attachment 166686 [details, diff]
GLSA-SLOT-support-in-vulnerable-unaffected-package.patch

Patch to the GLSA DTD v2 to support SLOT definitions in affected/unaffected packages.
Comment 19 Wolfram Schlich (RETIRED) gentoo-dev 2009-11-13 12:56:53 UTC
any news on glsa-check + slotted packages?
Comment 20 Tobias Heinlein (RETIRED) gentoo-dev 2014-01-08 00:55:33 UTC
*** Bug 497322 has been marked as a duplicate of this bug. ***
Comment 21 Alex Xu (Hello71) 2014-10-03 00:47:01 UTC
*** Bug 522834 has been marked as a duplicate of this bug. ***
Comment 22 Aaron Bauman (RETIRED) gentoo-dev 2017-01-13 14:42:22 UTC
yay!  Thanks to Alex, Tobias, and Mart!