Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905869 - 'emerge --sync' does not update repository link after repos.conf update
Summary: 'emerge --sync' does not update repository link after repos.conf update
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
: 679040 915991 (view as bug list)
Depends on: 916031
Blocks:
  Show dependency tree
 
Reported: 2023-05-07 10:45 UTC by Sergei Trofimovich
Modified: 2023-11-04 23:17 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich 2023-05-07 10:45:00 UTC
In https://github.com/trofi/nix-guix-gentoo/issues/35 changed the link in repos.conf entry and did not observe overlay update.



Reproducible: Always

Steps to Reproduce:
User had the following sequence of events:

1. Set the overlay to point to the mirror:

  nix-guix
    location: /var/db/repos/nix-guix
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/nix-guix.git
    masters: gentoo
    volatile: False

2. emerge --sync

3. switch repos.conf entry to https://github.com/trofi/nix-guix-gentoo.git

4. emerge --sync
Actual Results:  
/var/db/repos/nix-guix still points to the stale https://github.com/gentoo-mirror/nix-guix.git

Expected Results:  
/var/db/repos/nix-guix points to the new https://github.com/trofi/nix-guix-gentoo.git
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-07 10:47:27 UTC
We can make it adjust it for volatile repos, sure. We can't really otherwise though.
Comment 2 Sergei Trofimovich 2023-05-07 12:10:54 UTC
If the data loss is a concern at least making the sync to fail might be more intuitive than silently succeeding.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-19 18:38:47 UTC
*** Bug 915991 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2023-10-22 19:03:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=3b8442d6683cad9debe9fce554e2bd958188ab7c

commit 3b8442d6683cad9debe9fce554e2bd958188ab7c
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2023-10-19 08:48:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-22 18:58:57 +0000

    sync/git: update git remote url with sync-uri when necessary
    
    If the repo is not volatile, update the URL of the git remote if it is
    not equal to the configured sync-uri.
    
    Closes: https://bugs.gentoo.org/905869
    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 NEWS                                |  3 +++
 lib/portage/sync/modules/git/git.py | 33 ++++++++++++++++++++++++++++++++-
 2 files changed, 35 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-10-25 05:49:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b9128b401def05cac46f9e6d66048e5a0d888b8

commit 2b9128b401def05cac46f9e6d66048e5a0d888b8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-25 05:48:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-25 05:48:40 +0000

    sys-apps/portage: add 3.0.54
    
    Closes: https://bugs.gentoo.org/905869
    Closes: https://bugs.gentoo.org/915551
    Closes: https://bugs.gentoo.org/915896
    Closes: https://bugs.gentoo.org/916106
    Closes: https://bugs.gentoo.org/916108
    Closes: https://bugs.gentoo.org/916112
    Closes: https://bugs.gentoo.org/916116
    Closes: https://bugs.gentoo.org/916139
    Closes: https://bugs.gentoo.org/916141
    Closes: https://bugs.gentoo.org/916142
    Closes: https://bugs.gentoo.org/916149
    Closes: https://bugs.gentoo.org/916182
    Closes: https://bugs.gentoo.org/916231
    Closes: https://bugs.gentoo.org/916235
    Closes: https://bugs.gentoo.org/916240
    Closes: https://bugs.gentoo.org/916242
    Closes: https://bugs.gentoo.org/916245
    Closes: https://bugs.gentoo.org/916248
    Closes: https://bugs.gentoo.org/899898
    Closes: https://bugs.gentoo.org/906129
    Closes: https://bugs.gentoo.org/906156
    Closes: https://bugs.gentoo.org/916031
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.54.ebuild | 238 +++++++++++++++++++++++++++++++++
 2 files changed, 239 insertions(+)
Comment 6 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2023-11-04 23:17:46 UTC
*** Bug 679040 has been marked as a duplicate of this bug. ***