484410 – dev-python/patsy: plays with python wrapping internals (unnecessarily)

Bug 484410 - dev-python/patsy: plays with python wrapping internals (unnecessarily)

Summary: dev-python/patsy: plays with python wrapping internals (unnecessarily)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Gentoo Science Mathematics related packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	484398
	Show dependency tree

Reported:	2013-09-09 21:21 UTC by Michał Górny
Modified:	2013-09-14 07:44 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch fixing the ebuild (patsy-0.2.0.ebuild.diff,563 bytes, patch) 2013-09-13 22:26 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2013-09-09 21:21:55 UTC

python_test() {
    cd ${BUILD_DIR}
                    ^ '|| die' missing here!
    nosetests-${EPYTHON} -v || die "Testing failed with ${EPYTHON}"
             ^^^^^^^^^^^
}

Please don't play with internals like this. 'nosetests' is a wrapper, and eclass sets up environment properly, so the wrapper will choose correct implementation.

Comment 1 Michał Górny archtester

2013-09-13 22:26:46 UTC

Created attachment 358606 [details, diff]
patch fixing the ebuild

I've confirmed that tests work fine after applying the patch. Please lemme know if it's ok to commit.

Comment 2 Mark Wright gentoo-dev

2013-09-14 02:48:28 UTC

Neat, it would be great if you'd like to commit that fix, thanks!

Comment 3 Michał Górny archtester

2013-09-14 07:44:30 UTC

Committed.