I'm attaching the ebuild and the patch (from Pine) to add the incoming mail check patch to Pine 4.58. When you hit ctl-H in the List it indicates which folders have new mail. For some reason epatch did not work so I used patch to apply the patch and applied it before the others. It didn't seem to work after. This works on my system but I use fetchmail->procmail->pine to get mail so I don't use all the features of pine. Let mw know how it works for you.
Created attachment 29586 [details] Ebuild with incoming mail patch.
Created attachment 29587 [details, diff] Incoming mail Patch
Created attachment 30492 [details] Tarball for Pine 4.58 - totally redone. After communicating with Pine's author I redid the ebuild entirely. I started with the latest all patch from the author, got rid of all the other patches in the ebuild and applied patches from the author's site that were not included in the all patch. The patches are now in the files directory instead of being part of the SRC_UI.
for quite a while i'm now using a UTF-8 patches from: http://www.suse.de/~bk/pine/iconv/4.58/ (see also bug #29093) with my PORTAGE_OVERLAY ebuild. I used versions 8k and 8o since my comment on that old bug without trouble (_almost_ all messages are displayed correctly -- only a few really clumpsy ones are still unreadable). Your version comments the 8o-version with a "non-working"-comment -- what's exactly the problem with it in our ebuild? I would like to see 2 additional things: 1. mailutil should be installed by adding the following 2 lines to src_install: dobin mailutil/mailutil doman imap/src/mailutil/mailutil.1 this (basically) allows users to move mailboxes betweens servers. 2. the patch for/against the really unhelpfull QP-enconding error -- see http://www.math.washington.edu/~chappa/pine/info/qpfilter.html for details. To make the update to the next major version of pine (4.60) easier: shouldn't we move the whole patches in ./files/ to ./files/4.58/?
On my system UTF8 dies with an error about variables defined - I don't have the exact message at this time but can reproduce it later. Pine's author mentions that SUSE's patch combines two patches in one which is not a good idea so I get a conflict in compose.c (if I remember correctly). As for the other two items I'd have to check into those - I haven't gotten that far into pine yet. I'll look at them when time permits. Where the patches go seems to vary. Gentoo's Pine ebuild downloaded some of the patches (but they weren't current) and kept others in files. Other package's ebuilds seem to mix versions in files. From what I remember in the Gentoo docs you can do it either way. I think version directories under files is neater. I may move them when I work on it next.
as 4.60 was released this week (with the qp.patch integrated) it may be better to focus on the new version. my (trivial) test-ebuild simply stripped out all patches and applied the all patch. the utf-8 patch seems not to be 4.60-ready yet nor are there any patches not included in the all-patch -- at least not marked 4.60-ready -- on http://www.math.washington.edu/~chappa/pine/patches/.
At this point I don't plan to do anything with 4.58 and before I start 4.60 I'll wait for it to stabalize a little. There have been several patches released for 4.60 already. Why apply the all patch? I would hope most of those were incorporated in 4.60 so there wouldn't be a need for the all patch anymore.
not all patches accumulated are incorporated in the newest release of pine, a few do not make it in and thus a new "all.patch" is available -- it does contain less patches, but it's there. I'll use the new version with the mentioned trivial ebuild and post my findings in a week or so.
no problems with 4.60 + all.patches -- it even fixed a problem with MS-Exchange (leading to minutes of "thinking" what to do next); now it works as fast as expected in a LAN. the question is: should we really apply the "all"-patch or rather apply each patch separately?
Apply the all patch. The author has said that sometimes the order of patches has made a difference as well as the fact that some distros, like Suse try mess with the patch and it causes problems. The author's all patch fixes bugs which we all want fixed and adds features that are used by almost everyone. By using his patch we'll have less hassle trying to apply a ton of separate patches - and there are a lot of them.
I posted an ebuild to bug 50696 a while back with a few of the old patches applied as well. Seems to work just fine.
Fixed Bug 50696
