Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 428410 - sys-apps/gptfdisk - make dev-libs/icu dependency optional
Summary: sys-apps/gptfdisk - make dev-libs/icu dependency optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexey Shvetsov
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-07-28 09:16 UTC by fdupoux
Modified: 2013-03-30 04:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make dependency on dev-libs/icu optional (gptfdisk-make-icu-optional.patch,557 bytes, patch)
2012-07-28 09:16 UTC, fdupoux
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fdupoux 2012-07-28 09:16:56 UTC
Created attachment 319502 [details, diff]
Patch to make dependency on dev-libs/icu optional

sys-apps/gptfdisk depends on dev-libs/icu for unicode support. gptfdisk installation is quite small (650 KB) but unfortunately dev-libs/icu is quite large (around 20MB, mostly because of libicudata.so).

So it makes it difficult to put gptfdisk on systems with limited storage such as rescue medias and this is a shame as the package itself is really small and quite useful. Hence the implementation of an use variable (USE='+icu') allows people to remove this dependency.

The README file in gptfdisk says how the unicode support can be removed:
<quote>
To compile without ICU support, you must modify the Makefile: Remove the "-D USE_UTF16" part from the CXXFLAGS line and remove references to -licuio, -licuuc, -licudata, and -licucore (details vary between platforms) from the compilation options. Suitable lines are present, but commented out, in the Makefile, Makefile.mac, and Makefile.bsd files.
</quote>

I have implemented this new USE variable for sys-apps/gptfdisk. The patch is extremely simple and clean, hence I hope it will be included in the official gptfdisk ebuild.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2012-10-26 11:56:17 UTC
Any progress.
Comment 2 Dave Armstrong 2013-03-29 13:46:21 UTC
(In reply to comment #1)
> Any progress.

There's a new version (0.8.6) of gptfdisk available.  I submitted a new ebuild that incorporates the changes from fdupoux's patch to an open version-bump request:
https://bugs.gentoo.org/show_bug.cgi?id=461454
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2013-03-29 16:44:50 UTC
+*gptfdisk-0.8.6 (29 Mar 2013)
+
+  29 Mar 2013; Justin Lecher <jlec@gentoo.org> gptfdisk-0.8.4.ebuild,
+  gptfdisk-0.8.5.ebuild, +gptfdisk-0.8.6.ebuild, metadata.xml:
+  Version BUmp and make icu support optional, #428410, #461454
+