391927 – autotools-utils.eclass: Don't ignore errors during attempts of changing of current directory

Bug 391927 - autotools-utils.eclass: Don't ignore errors during attempts of changing of current directory

Summary: autotools-utils.eclass: Don't ignore errors during attempts of changing of cu...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All All

Importance:	Normal normal (vote)
Assignee:	Maciej Mrozowski

URL:
Whiteboard:
Keywords:

Depends on:	392063
Blocks:
	Show dependency tree

Reported:	2011-11-26 01:03 UTC by Arfrever Frehtes Taifersar Arahesis
Modified:	2012-05-28 07:45 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
autotools-utils.eclass.patch (autotools-utils.eclass.patch,1.56 KB, text/plain) 2011-11-26 01:03 UTC, Arfrever Frehtes Taifersar Arahesis	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arfrever Frehtes Taifersar Arahesis 2011-11-26 01:03:10 UTC

Created attachment 293787 [details]
autotools-utils.eclass.patch

autotools-utils.eclass currently ignores some errors. I'm attaching the patch.

Comment 1 Michał Górny archtester

2011-11-26 08:45:32 UTC

Hrm, I'd move that directory changing into separate function TBH. Give me a while.

Comment 2 Maciej Mrozowski gentoo-dev

2011-11-26 19:45:42 UTC

Either way, I agree pushd/popd should die on error.

Comment 3 Michał Górny archtester

2011-11-26 20:42:12 UTC

/var/cvsroot/gentoo-x86/eclass/autotools-utils.eclass,v  <--  autotools-utils.eclass
new revision: 1.26; previous revision: 1.25
/var/cvsroot/gentoo-x86/eclass/ChangeLog,v  <--  ChangeLog
new revision: 1.27; previous revision: 1.26

Comment 4 Michał Górny archtester

2011-11-27 09:58:06 UTC

Reverted due to humongous breakage.

Comment 5 Michał Górny archtester

2012-05-28 07:45:32 UTC

Committed once again :P.