Bugzilla Bug 36771

when linking:

/usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lX11
collect2: ld returned 1 exit status

Reproducible: Always
Steps to Reproduce:
emerge transcode

which in turn attempts to merge mjpegtools
Actual Results:  
ar cru .libs/liblavplay.a  liblavplay_la-liblavplay.o liblavplay_la-audiolib.o
ranlib .libs/liblavplay.a
creating liblavplay.la
(cd .libs && rm -f liblavplay.la && ln -s ../liblavplay.la liblavplay.la)
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I/usr/include
-DG_LOG_DOMAIN=\"lavtools\" -DLAVPLAY_VERSION=\"1.6.1.91\" -I/usr/include   -I
/usr/X11R6/include -I../utils  -I/usr/include/jpeg-mmx    -mcpu=i686 -march=i686
-march=pentiumpro -O3 -pipe -mno-sse2 -Wall -Wunused -MT lavplay.o -MD -MP -MF
".deps/lavplay.Tpo" \
  -c -o lavplay.o `test -f 'lavplay.c' || echo './'`lavplay.c; \
then mv -f ".deps/lavplay.Tpo" ".deps/lavplay.Po"; \
else rm -f ".deps/lavplay.Tpo"; exit 1; \
fi
/bin/sh ../libtool --mode=link gcc  -mcpu=i686 -march=i686 -march=pentiumpro -O3
-pipe -mno-sse2 -Wall -Wunused   -o lavplay  lavplay.o ../utils/libmjpegutils.a
liblavplay.la liblavjpeg.la liblavfile.la -lpthread -L/usr/lib
-Wl,-rpath,/usr/lib -lSDL -lpthread  -lX11
gcc -mcpu=i686 -march=i686 -march=pentiumpro -O3 -pipe -mno-sse2 -Wall -Wunused
-o .libs/lavplay lavplay.o -Wl,-rpath -Wl,/usr/lib  ../utils/libmjpegutils.a
./.libs/liblavplay.so ./.libs/liblavjpeg.so -L/usr/include/jpeg-mmx
./.libs/liblavfile.so /usr/lib/libjpeg.so -L/usr/lib /usr/lib/libdv.so
/usr/lib/libglib.so /usr/lib/libSDL.so -lm -ldl /usr/lib/libasound.so -lpthread
-lX11
/usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.2/../../../../i686-pc-linux-gnu/bin/ld:
cannot find -lX11
collect2: ld returned 1 exit status
make[2]: *** [lavplay] Error 1
make[2]: Leaving directory
`/var/tmp/portage/mjpegtools-1.6.1.91/work/mjpegtools-1.6.1.91/lavtools'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/mjpegtools-1.6.1.91/work/mjpegtools-1.6.1.91'
make: *** [all] Error 2

!!! ERROR: media-video/mjpegtools-1.6.1.91 failed.
!!! Function src_compile, Line 66, Exitcode 2
!!! compile problem



Expected Results:  
compiled  :-)

bob / # emerge info
Portage 2.0.49-r18 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20031222-r0, 2.6.0)
=================================================================
System uname: 2.6.0 i686 Pentium Pro
Gentoo Base System version 1.4.3.12
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentiumpro -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /opt/tomcat/conf /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=pentiumpro -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acpi alsa apache2 apm avi berkdb cdr crypt cups curl doc dv dvd encode
ethereal fbcon foomaticdb gd gdbm gif gpm gtk2 imap imlib innodb ipv6 java jpeg
libg++ libwww mad maildir mbox mcal mikmod mmx mpeg mpi mysql ncurses nls odbc
oggvorbis oss pam pcmcia pda pdflib perl png pnp postgres python readline samba
sasl slang spell sse ssl tcpd tetex tiff transcode trusted usb wmf x86 xml xml2
xvid zlib"

Created an attachment (id=22854) [details]
Update patch to remove extra -lX11 for 1.6.1.91

Since the syntax in makefile.in for the x11 line hade changed the old patch
didn't work and was removed but unfortunatly the issue wasn't fixed upstream
just changed

*** Bug 38812 has been marked as a duplicate of this bug. ***

The above patch works perfectly for me. Thanks.

Using the patch for .93 if X is not in USE. Thanks.

*** Bug 44645 has been marked as a duplicate of this bug. ***